Completed Unable to Upload Webp

[iMaks533 2]

Can you tell me what could be the reason that when you try to upload a poster for a movie in the .webp format is the download icon spinning endlessly through image editing in the browser? With the format .jpg does not have such a problem, it downloads files of any size immediately.

[Luke 42097]

@iMaks533

Hi there, please attach the Emby server log from when the problem occurred:

How to Report a Problem

Thanks!

 

[brothom 190]

@iMaks533@LukeI'm currently also experiencing issues uploading a webp as an image (primary, logo, etc).

Looks like a check in the JS is failing:

apiclient.js:1 Uncaught Error: File must be an image.
    at ApiClient.uploadItemImage (apiclient.js:1:56394)
    at HTMLFormElement.onSubmit (imageuploader.js:1:2659)

Pinpointing this to `apiclient.js` on line :

        if ("image/png" !== file.type && "image/jpeg" !== file.type && "image/jpeg" !== file.type)
            throw new Error("File must be an image.");

Image/jpeg also exists twice in this line?
Did someone maybe accidentally remove image/webp?

If I can be so bold, I'd suggest rewriting this to an "includes" method:

        if (["image/jpeg", "image/jpg", "image/webp"].includes(file.type) == false)
            throw new Error("File must be an image.");

That keeps issues like this from happening because it's much more readable.

Edited 1 hour ago by brothom