sydlexius 297 Posted February 12 Posted February 12 1 minute ago, yocker said: Wouldn't that defeat the purpose of the plugin to just set a marker at 30 seconds from the end? Emby already does this. The thought process is that some shows don't have end credits, and rather than go through a re-detection loop or manually setting the offset, you could have a rule lazily do it for me
yocker 1253 Posted February 12 Author Posted February 12 The rules are overrides that can be added for movies with specific tags or studio metadata. For example many netflix shows have an annoying netflix logo and sound at the end that the chromaprint tends to pick up instead of the actual end credits. With the rules you can make it use another detection method or settings for those shows that work better.
yocker 1253 Posted February 12 Author Posted February 12 3 minutes ago, sydlexius said: The thought process is that some shows don't have end credits, and rather than go through a re-detection loop or manually setting the offset, you could have a rule lazily do it for me Ah you mean to avoid the detection of credits in already failed episodes. I am cooking up something for it, it might be a little while before i have a good system for it. Best i can recommend atm. is using OCR detection (with paddleORC) as it tends to not fail. 1
yocker 1253 Posted February 15 Author Posted February 15 New version up (v2.2.2.0) on yocksers/EmbyCredits github. Added: File validation, this will check files for errors before running any detections and skip to next file in queue if error found. Can be disabled or enabled in the settings. More API for remote control of the plugin. 1
Rykalout 5 Posted February 15 Posted February 15 Would it be possible to have a setting to choose whether the credit is applied x seconds before or after detection? For example, to have the credit applied before it arrives.
yocker 1253 Posted February 15 Author Posted February 15 7 hours ago, Rykalout said: Would it be possible to have a setting to choose whether the credit is applied x seconds before or after detection? For example, to have the credit applied before it arrives. Sure, i will look into.
Neminem 1523 Posted February 15 Posted February 15 7 hours ago, Rykalout said: Would it be possible to have a setting to choose whether the credit is applied x seconds before or after detection? For example, to have the credit applied before it arrives. Do you mean as an offset +x sec or -x sec. That would be interesting
Jutsch80 13 Posted Friday at 11:13 AM Posted Friday at 11:13 AM No matter what I try, I can't seem to make Emby "see" the OCR Server. The server is running and reachable by entering it's IP and port in the browser but testing the connection in the plugin settings returns: "OCR test failed: Error while copying content to a stream."
frankythedog 5 Posted Friday at 11:32 AM Posted Friday at 11:32 AM Hello, Great job until now. May I suggest a reset button? This would remove all chapters from the end credits, at the series and/or season level. When detection is inaccurate, it may be helpful to reset them and start again with different settings. What do you think ?
yocker 1253 Posted Friday at 12:11 PM Author Posted Friday at 12:11 PM 57 minutes ago, Jutsch80 said: No matter what I try, I can't seem to make Emby "see" the OCR Server. The server is running and reachable by entering it's IP and port in the browser but testing the connection in the plugin settings returns: "OCR test failed: Error while copying content to a stream." Please enable debugging in the settings and in Emby and then upload the emby log here.
Jutsch80 13 Posted Friday at 12:24 PM Posted Friday at 12:24 PM 6 minutes ago, yocker said: Please enable debugging in the settings and in Emby and then upload the emby log here. I will do that as soon as Emby logged anything there. The error does not seem to trigger a log of any kind. Btw I got a question. I wouldn't even mind not using OCR at all because it's possible to set markers manually but then I can't seem to find any option to actually skip the credits automatically. The marker just seems to set when the "next episode" pop up appears. Or do I miss anything super obvious here?
yocker 1253 Posted Friday at 12:32 PM Author Posted Friday at 12:32 PM 4 minutes ago, Jutsch80 said: I will do that as soon as Emby logged anything there. The error does not seem to trigger a log of any kind. Btw I got a question. I wouldn't even mind not using OCR at all because it's possible to set markers manually but then I can't seem to find any option to actually skip the credits automatically. The marker just seems to set when the "next episode" pop up appears. Or do I miss anything super obvious here? It should log it, did you enable debug logging in Emby? The end credit markers added by the plugin triggers the "next episode" pop ups to appear. While Emby automatically shows should them the plugin makes them much more precise in when they should appear. The "OCR test failed: Error while copying content to a stream." fault you are getting could point to you not having set a "custom folder", not having given the right permissions to that folder or enabled direct stream without having hardware capable of it.
Jutsch80 13 Posted Friday at 12:41 PM Posted Friday at 12:41 PM 7 minutes ago, yocker said: It should log it, did you enable debug logging in Emby? The end credit markers added by the plugin triggers the "next episode" pop ups to appear. While Emby automatically shows should them the plugin makes them much more precise in when they should appear. The "OCR test failed: Error while copying content to a stream." fault you are getting could point to you not having set a "custom folder", not having given the right permissions to that folder or enabled direct stream without having hardware capable of it. So there is no option to actually automatically skip the credits? Which would be fine, just would like to know. I did set a custom folder and also gave both containers full rights to the custom folder.
yocker 1253 Posted Friday at 01:08 PM Author Posted Friday at 01:08 PM 23 minutes ago, Jutsch80 said: So there is no option to actually automatically skip the credits? Which would be fine, just would like to know. I did set a custom folder and also gave both containers full rights to the custom folder. No option to automatically skip, it only adds a time stamp in the video metadata that tells Emby where the end credits are and Emby takes it from there. I sadly can't think of anything that might be wrong with out any logs. Give me some time and i will make a new version with some more logging to help diagnose the problem. For now though, can you please upload the EmbyCredits.xml file? That should at least help a bit.
Jutsch80 13 Posted Friday at 01:24 PM Posted Friday at 01:24 PM 13 minutes ago, yocker said: No option to automatically skip, it only adds a time stamp in the video metadata that tells Emby where the end credits are and Emby takes it from there. I sadly can't think of anything that might be wrong with out any logs. Give me some time and i will make a new version with some more logging to help diagnose the problem. For now though, can you please upload the EmbyCredits.xml file? That should at least help a bit. I hope it helps. Honestly, if actually skipping the credits is not an option anyway there's little reason for me to try to get the plugin to work properly EmbyCredits.xml
yocker 1253 Posted Friday at 03:57 PM Author Posted Friday at 03:57 PM (edited) 3 hours ago, Jutsch80 said: I hope it helps. Honestly, if actually skipping the credits is not an option anyway there's little reason for me to try to get the plugin to work properly EmbyCredits.xml 10.74 kB · 0 downloads I will look into it. Edited Friday at 04:24 PM by yocker
yocker 1253 Posted Friday at 05:33 PM Author Posted Friday at 05:33 PM 4 hours ago, Jutsch80 said: I hope it helps. Honestly, if actually skipping the credits is not an option anyway there's little reason for me to try to get the plugin to work properly EmbyCredits.xml 10.74 kB · 1 download Might have found the reason it failed. You can try this version to see if it's better. EmbyCredits.dll 1
Jutsch80 13 Posted Friday at 05:58 PM Posted Friday at 05:58 PM 24 minutes ago, yocker said: Might have found the reason it failed. You can try this version to see if it's better. EmbyCredits.dll 1001 kB · 1 download This version works, thank you so much. Would you mind explaining what the issue was? 1
yocker 1253 Posted Friday at 07:47 PM Author Posted Friday at 07:47 PM 1 hour ago, Jutsch80 said: This version works, thank you so much. Would you mind explaining what the issue was? It threw out some needed information too fast so it didn't get to the OCR server. Basically a timing issue.
yocker 1253 Posted Friday at 07:51 PM Author Posted Friday at 07:51 PM 8 hours ago, frankythedog said: Hello, Great job until now. May I suggest a reset button? This would remove all chapters from the end credits, at the series and/or season level. When detection is inaccurate, it may be helpful to reset them and start again with different settings. What do you think ? Thank you for the suggestion. I have been planning on making something like a chapter editor at some point but never got around to finish it because the plugin ChapterAPI already exists. Maybe i should get around to finishing it.
Jutsch80 13 Posted Friday at 09:28 PM Posted Friday at 09:28 PM One upside I didn't see coming was for using Infuse as a player. It does thave a "next episode" button but that only appears if one manually makes the timeline appear on screen and then the button can be pressed. The "Skip Credits" button on the other hand appears regardless and doesn't have to be put on screen manually. 1
Jutsch80 13 Posted yesterday at 02:26 AM Posted yesterday at 02:26 AM I know theres an easy way of setting a season wide timestamp but is there also a way to set a single time for a whole show?
yocker 1253 Posted yesterday at 02:40 AM Author Posted yesterday at 02:40 AM 11 minutes ago, Jutsch80 said: I know theres an easy way of setting a season wide timestamp but is there also a way to set a single time for a whole show? I didn't add one like that because shows tends to change a lot between seasons. I'm considering making a complete chapter editor in the near future, when/if that gets made i will make a function like that. 1
yocker 1253 Posted 11 hours ago Author Posted 11 hours ago New version up on yocksers/EmbyCredits Github. Added: Ability to set offset for time stamps.
rechigo 364 Posted 1 hour ago Posted 1 hour ago 9 hours ago, yocker said: New version up on yocksers/EmbyCredits Github. Added: Ability to set offset for time stamps. The DLL is missing !
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now