Response Code for Connect/Link

[adminExitium 355]

Would it be possible to fix the error code for Connect/Link to return 404 when the user doesn't exist?

Currently, it returns 500, but the response content is "NotFound". 404 for this would be better.

[ebr 16169]

Hi.  Exactly what is the situation?

We already should be returning 404 for a true not found.  The 500 either means that user is already connected or some other error is occurring.

[adminExitium 355]

404 seems to be the response from the upstream service but it's 500 from the Emby Server:

2025-11-14 19:35:14.851 Info ConnectService-0HNH1P8JQ7L41:00000003: http/1.1 POST http://url/emby/Users/d4e311421dce497aa87289e3d08058fc/Connect/Link?X-Emby-Client=Emby Web&X-Emby-Device-Name=Brave macOS&X-Emby-Device-Id=13c0fd22-0602-4ecc-98b7-a31e8ffd1222&X-Emby-Client-Version=4.9.2.6&X-Emby-Token=token&X-Emby-Language=en-us. Source Ip: ip, UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/142.0.0.0 Safari/537.36
2025-11-14 19:35:14.858 Info HttpClient: GET https://connect.emby.media/service/user?nameOrEmail=abc12345@xyz12345.com
2025-11-14 19:35:15.083 Info HttpClient: Http response 404 from https://connect.emby.media/service/user?nameOrEmail=abc12345@xyz12345.com after 224ms
2025-11-14 19:35:15.088 Error ConnectService-0HNH1P8JQ7L41:00000003: Error processing request
        *** Error Report ***
        Version: 4.9.2.6
        Command line: /app/emby/system/EmbyServer.dll -programdata /config -ffdetect /app/emby/bin/ffdetect -ffmpeg /app/emby/bin/ffmpeg -ffprobe /app/emby/bin/ffprobe -restartexitcode 3
        Operating system: Linux version 6.17.7-x64v3-xanmod1 (root@runner-vt1flt5ik-project-51590166-concurrent-0) (Debian clang version 19.1.7 (3), Debian LLD 19.1.7) #0~20251
        OS/Process: x64/x64
        Framework: .NET 8.0.11
        Runtime: app/emby/system/System.Private.CoreLib.dll
        Processor count: 20
        Data path: /config
        Application path: /app/emby/system
        MediaBrowser.Model.Net.HttpException: MediaBrowser.Model.Net.HttpException: NotFound
           at Emby.Server.Connect.ConnectManager.LinkUserInternal(User user, String connectUsername)
           at Emby.Server.Connect.ConnectManager.LinkUser(User user, String connectUsername)
           at Emby.Server.Connect.Api.ConnectService.Post(CreateConnectLink request)
           at Emby.Server.Implementations.Services.ServiceController.GetTaskResult(Task task)
           at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost httpHost, IServerApplicationHost appHost, IRequest httpReq, IResponse httpRes, IStreamHelper streamHelper, RestPath restPath, String responseContentType, CancellationToken cancellationToken)
           at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IRequest httpReq, RestPath restPath, String urlString, String localPath, String contentTypeInPath, CancellationToken cancellationToken)
        Source: Emby.Server.Connect
        TargetSite: Void MoveNext()

2025-11-14 19:35:15.088 Info ConnectService-0HNH1P8JQ7L41:00000003: http/1.1 Response 500 to ip. Time: 237ms. POST http://url/emby/Users/d4e311421dce497aa87289e3d08058fc/Connect/Link?X-Emby-Client=Emby Web&X-Emby-Device-Name=Brave macOS&X-Emby-Device-Id=13c0fd22-0602-4ecc-98b7-a31e8ffd1222&X-Emby-Client-Version=4.9.2.6&X-Emby-Token=token&X-Emby-Language=en-us.

 

[ebr 16169]

Ah, okay.  Thanks.