Adding 4.9 as a required version in package manager

[Amything 122]

Hey,

When I upload a NET 8 version of my plugin to the package manager and set 3.9 as the required version, will prior versions still see the previous versions of my plugin in the plugin catalog?

[softworkz 5066]

Plugins must always target netstandard2.0 

 

[Luke 42077]

15 minutes ago, Amything said:

Hey,

will prior versions still see the previous versions of my plugin in the plugin catalog?

HI, yes they will.

But yes, plugins should target .netstandard 2.0.

[Amything 122]

12 minutes ago, Luke said:

But yes, plugins should target .netstandard 2.0.

Can you please expand on why that is? I've already converted my plugin to NET 8 a while a go and been testing with previous beta version and the latest release. Everything works perfectly. It would be really sad to go back!

[softworkz 5066]

11 minutes ago, Amything said:

Can you please expand on why that is? I've already converted my plugin to NET 8 a while a go and been testing with previous beta version and the latest release. Everything works perfectly. It would be really sad to go back!

Unfortunately you have to. All plugins are netstandard2.0 - without exception. What works on your local machine is different from the reality. 
Just look at the latest beta release https://github.com/MediaBrowser/Emby.Releases/releases/tag/4.9.1.36 and expand the "Assets" section. There you will see 137 platform packages. Not all of those platforms are .net 8, and even then it would not be acceptable to have .net 8 plugins, because there might be still runtime differences and we might change the target frameworks at any time.

Please let me know which issues you have when changing to netstandard2.0, then we'll probably have solutions for this. 

[Luke 42077]

40 minutes ago, Amything said:

Can you please expand on why that is? I've already converted my plugin to NET 8 a while a go and been testing with previous beta version and the latest release. Everything works perfectly. It would be really sad to go back!

Because not all server platforms target dotnet 8 yet. What plugins are these? You're free to build this way, but we just won't put it in our catalog because it will probably cause a server crash on unsupported platforms.

[softworkz 5066]

7 minutes ago, Luke said:

because it will probably cause a server crash on unsupported platforms.

In that case it may land on the plugin blacklist (in the server, independent from the catalog) - which is regardles of platform, so I would really recommend to do it in the right way.

Please note that you are allowed to reference System.Memory 4.6.0, which bridges quite a number of gaps.

Unfortunately, our nuget packages are authored incorrectly and they are not indicating it like they should.

[Amything 122]

Thanks guys. I've not had any issues with 2.0. I knew Jellyfin recommends NET8 and just wrongly assumed you where going the same way so I started to change it. Was finishing up and getting ready to add it to the package manager when I posted this.

[Luke 42077]

Some of the older NAS's that we support can't even run dotnet. They run the mono runtime and netstandard 2.0 is as high as they can go. I'm sure there will come a day when we don't support those anymore and then we can bump everything up but we are not there yet.

[softworkz 5066]

31 minutes ago, Amything said:

I knew Jellyfin recommends NET8

Don't they require you to provide a source code repo for plugins?

23 minutes ago, Luke said:

we can bump everything up 

Internally yes, but for plugins we need to be careful with such a decision.

[Amything 122]

1 minute ago, softworkz said:

Don't they require you to provide a source code repo for plugins?

Yes, they do.

[softworkz 5066]

3 minutes ago, Amything said:

Yes, they do.

Then they have it easy to get plugins compiled for different target frameworks...