Web Client: ASS Render Improvement

[UnkNow404 3]

The ASS subtitle web render engine SubtitlesOctopus only need to bind video element, it doesn't need create canvas manually. Manually creating a canvas can easily cause issues with misalignment with the subtitle video.

It can remove the canvas and canvasParent two options in 'modules/htmlvideoplayer/plugin.js' while create SubtitlesOctopus instance.

self.currentSubtitlesOctopus = new responses({
    video: videoElement,
    subUrl: subContent ? null : textTrackUrl,
    subContent: subContent,
    workerUrl: _approuter.default.baseUrl() + "/bower_components/javascriptsubtitlesoctopus/dist/subtitles-octopus-worker.js",
    legacyWorkerUrl: _approuter.default.baseUrl() + "/bower_components/javascriptsubtitlesoctopus/dist/subtitles-octopus-worker-legacy.js",
    fallbackFont: function (track) {
        var fonts = [];
        !function (track) {
            var langsNotNeedingFont, track = (track.Language || "").toLowerCase();
            return !track || !(langsNotNeedingFont = ["dut", "nld", "nl", "eng", "en", "en-us", "en-gb", "fin", "fi", "fre", "fra", "fr", "ger", "deu", "de", "heb", "he", "hun", "hu", "ita", "it", "nor", "no", "pol", "pl", "por", "pt", "pob", "pt-br", "rus", "ru", "spa", "es", "es-mx", "es-419", "swe", "sv"]).includes(track) && !langsNotNeedingFont.includes(track.split("-")[0])
        }(track) || fonts.push(_approuter.default.baseUrl() + "/modules/fonts/GoNotoKurrent.woff2");
        return fonts
    }(track)[0],
    onError: function () {
        _htmlmediahelper.default.onErrorInternal(self, "mediadecodeerror")
    },
    lossyRender: null != window.createImageBitmap,
    renderMode: null != window.createImageBitmap ? "lossy" : "wasm-blend",
    detectAlphaBug: !_browser.default.chromecast,
    canvas: canvas,			# Should remove this
    canvasParent: canvasParent		# Should remove this
})

 

Edited July 22, 2025 by UnkNow404

[Abobader 3464]

Hello UnkNow404,

** This is an auto reply **

Please wait for someone from staff support or our members to reply to you.

It's recommended to provide more info, as it explain in this thread:

Thank you.

Emby Team

[Luke 42077]

Hi, Thanks. We'll take a look.