Jump to content

Cinema Intros - original player title name cannot be updated


Go to solution Solved by visproduction,

Recommended Posts

visproduction
Posted (edited)

Minor bug.  Player title for trailer automatically truncates after a dash, parathetical or tilde.  Once that happens, there is no way to clear the cache and fix the playback file name.  Editing metadata with Tools / More does not work.  Changing the name to no longer have a dash in the file name, does not work. Rescaning the library or restarting the server does not work.  Waiting several days does not work.  The original truncated name is stuck in cache, perhaps in Metadata and can never be fixed.

Media library directory

  The Tailor of Panama Trailer (2001)/The Tailor of Panama Trailer (2001) - 720P.mp4

Media library directory/Trailers

  First name of file: The Tailor of Panama - Trailer 2001.mp4

Creates the player title name (Lower left - overlay on mouse over): Trailer 2001

Changed the name to - no dash:  The Tailor of Panama Trailer 2001.mp4

This does not update the player title, even after Tool gear / More / Metadata edit, nor rescan, nor server restart.  The playback title is stuck at the first name just 'Trailer 2001'

How can the trailer names be cleared from cache and accept the new file name without the dash?
A better question: Why does the name get truncated, based on a dash, a tilde or parenthical?  - ~ (

All these cause the playback title name to be cut up, abbreviated and impossible to change.  Elsewhere with file name usage, the info after the dash, can hold just the '1080P' size for media page pull down selection.  The trailer playback name should not have this limitation.

Cinema Intros bug - Title cannot be updated.jpg

Edited by visproduction
Posted

Hi, can you try removing your custom css and then see how things compare?

visproduction
Posted (edited)

No change.  The initial truncated titles still remain.  CSS styles don't have extra js.  The creation of the title name, that is split up by - ( or  ~, has to be from inside the plugin and once it is created, the plugin never seems to update the title again.  It's in cache, perhaps added to a dbase entry for that media.  I would guess it needs a rescan function.  The plugin is pulling the code that truncates the audio and video pull down selector... Everything before a dash is removed.  But Cinema trailers don't need this and there should be a rescan option button.  It's minor and back-burner issue.  Thanks.

Edited by visproduction
visproduction
Posted (edited)

All the trailer videos have correct new names without dashes parenthetical or tildes.  I tried renaming all 'Trailers' subfolders to T0 with a batch file, rescanning the library, turning Cinema Intros off and on, restarting Emby, then switching the subfolders names back from T0 to Trailers again... Same problem, the original names are still truncated and stuck.  They must have been written to the dbase.  I don't see a plugin cache.

Maybe, if I switch them again, the trailers show up as new media content.  Then group delete them, rescan and restart.  That might clear the dbase.  Then I would have to grab from a back up and put the trailers all in again. I could write some batch files... Hmmm, maybe I will wait for possible fix... Ha!

 

Edited by visproduction
  • Solution
visproduction
Posted

Finally fixed with some file juggling...

  1. I ran batch files and backed up and removed all the trailers media in /trailers/[some movie or tv trailer.mp4] files.
  2. Rescanned all libraries. The Cinema intros no longer had any media to find in all the /trailers subfolders.
  3. Then I renamed all the trailers, took cleared out all dashes and parentheticals and tried adding a dash and a space at the beginning of the file names.  -  some movie trailer.mp4
  4. I let Cinema intros find the names on it's own without rescanning the libraries.

Finally the media player, hover, lower left titles now show the full name starting with the dash space.

The trailers had to be removed in order to reset the names.  Just changing all the trailers subdirectories to a temp name T0 and then back again, did not help.  The mp4 media were still in the directories and Emby just found them as additional extra media and no name reset happened.  I had to actually remove all the mp4 files.  Perhaps just turning then to .mp4.off might have worked.

It would still be nice to have a rescan trailer names button.  Probably no one else will ever run into this. But it is not very user friendly.  Maybe the next update, have a look.
Thanks.

  • Thanks 1
Posted

It's probably what's in your database. I don't think it's actually getting truncated in the UI. Thanks.

visproduction
Posted (edited)

I think the player title names is being parsed by the same code that creates the audio / video and subtitles fields in the media page pull down.  Video resolutions has the media name removed and only shows what comes after a dash:

Batman - 720P.mp4

Batman - 1080P.mp4

Only appears as:
720P

1080P

in the media page pull down selections.

Similar truncation happens with audio and subtitles.

This regex or similar text truncating, somewhere in the code, is also handling the player titles and it doesn't need to do this.  On top of this, there is no easy way to rescan and update these titles after the file name of the trailers are updated.  The rescan just skips looking at the trailer titles.

<h1 class="videoOsdParentTitle videoOsdParentTitle-large osdText-nowrap">- Locke and Key TV series trailer</h1>

Maybe in videooosd/videoosd.js code.  The ParentTitle is perhaps being split up like the other metadata info.  There is no need.  It's only the title and should match the file name and rescan should check a filename change and update correctly.  It doesn't.  You have to remove the trailers or turn them off by changing the extension to clear the cached name titles that appear in the player.

videooosd/videoosd.js

...
"nowplaying-backgroundcontainer-brighter")),videoOsdParentTitleLarge.classList.remove(
"osdText-nowrap"),videoOsdParentTitleLarge.classList.add(
"hide"),videoOsdParentTitle.classList.remove(
"hide","osdText-nowrap"),videoOsdSecondaryMediaInfo.classList.add(
"videoOsdSecondaryMediaInfo-remotecontrol"),mainLockButton.classList.add(
"hide")
...

Also noticed a possible code typos.  dash and lower case l.   The page class selector for this title uses:

videoOSParentTitle-large

But the code inside videoosd.js does not match and has the class without the dash and uses upper case L. 

videoOsdParentTitleLarge 

This would cause the js function to fail.

QA would miss checking this, because why would anyone look that deep?  A player title appears, QA check is approved.  Unless the user includes a dash, partenthetical or tilde the code maybe doesn't even notice an issue and delivers the complet title.  Once I started using the dash in the title or put parenthesis around a year (2022), the cached titles gets made, chopped up and the only way to fix this title is to remove the file or change it's extension.  QA misses this title caching quirk, becuase it's so random and rare to happen.

Anyway, it's still user unfriendly, but really a small issue,.

Thanks.

Edited by visproduction
visproduction
Posted

A different feature request for Cinema Intros.  Be able to add thumbnail posters to the placeholders.

 

Cinema Intros Up next cannot accept images.jpg

  • Thanks 1
visproduction
Posted (edited)

Whoops... a typo in the above post about style class name in .js not matching the name in the HTML DOM.  The names don't match but both have lower case 's' in videoOsP...
 

Also noticed a possible code typos.  dash and lower case l.   The page class selector for this title uses:

videoOsParentTitle-large

But the code inside videoosd.js does not match and has the class without the dash and uses upper case L. 

videoOsdParentTitleLarge 

Edited by visproduction
Posted
On 7/7/2025 at 9:01 AM, visproduction said:

Whoops... a typo in the above post about style class name in .js not matching the name in the HTML DOM.  The names don't match but both have lower case 's' in videoOsP...
 

Also noticed a possible code typos.  dash and lower case l.   The page class selector for this title uses:

videoOsParentTitle-large

But the code inside videoosd.js does not match and has the class without the dash and uses upper case L. 

videoOsdParentTitleLarge 

Thanks. There's no code typo though.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...