Jump to content

Plugin: EmbyIcons release.


Recommended Posts

Posted

Hi regarding this

I deleted to much of my post.
I dont have the option to select languages, everything works but the options aren't there, are they removed or do i have the wrong versions, i'm just confused since i've seen them from screenshots on this thread and can find no reference to them being removed 

  • Like 1
yocker
Posted
Just now, KRONZO said:

Hi regarding this

I deleted to much of my post.
I dont have the option to select languages, everything works but the options aren't there, are they removed or do i have the wrong versions, i'm just confused since i've seen them from screenshots on this thread and can find no reference to them being removed 

I removed the options to select languages as that can be controlled by what icons you give to the plugin anyway.

Eg.
If you only add eng.jpg then only english languages will be shown. You need to add an icon for each language you want. Like dan.jpg, ger.jpg and so on.
Same with srt.eng.jpg.

I will update the readme to be more broad, understandable and up to date a little later so that there shouldn't be anything wrong with it.

yocker
Posted (edited)

New version up.
EmbyIcons: Icons overlay plugin for Emby.

This is a major update that changes a lot, mostly the internals.
---
Added: 
Overlays for Resolution, HDR, Dolby Vision.
Added a "lite mode", this only scans the first episode in TV shows for information for the TV show posters, this will help smaller servers a lot by limiting scanning and resources needed.
Ability for overlays to be stacked horizontal and vertically.
Dynamic CPU scaling when drawing overlays so the plugin will never take 100% CPU, this also works in docker containers with CPU pinning enabled.
Added folder view button to the icon folder setting.
Better caching system.
Better performance.
Stability enhancements.

Removed:
Icon offset settings has been removed as the new horizontal/vertical setting should take over from that and to make the settings less cluttered.

Bug fixes: 
Fixed a rare crash that could happen when posters were not present like if Emby could not find any for a movies.
Overlays for TV posters should now update as soon as Emby sees a change in episodes.
Fixed a bug causing TV episodes to be scanned twice on each operation for the TV show posters effectively requiring double the CPU resources.

Bugs:  
Refresh icon folder setting may or may not work properly depending on system.
If you have problems with changes to the icons in the icon folder not showing up on the overlays and this button doesn't work then.
1) Try to change the position of the icon overlays you changed.
2) Reset the server.
---

A massive thanks to @Neminemfor his help with testing!!
Also many thanks to developers of CoverArt and Iconic for letting me copy some features!! I promise i won't copy more! ;)

Edited by yocker
Posted
On 5/12/2025 at 8:26 AM, yocker said:

New version up with some fixes inc. working in the beta and not having to restart the server for new settings to work.

Enjoy!

Just finally grabbed this to give it a spin. I run Arch based distros so it is a matter of shutting down the server, opening /var/lib/emby/ as administrator, opening the plugins folder and then dropping in the dll file, then sudo systemctl start emby-server. once that was done I went into plugins in the settings and it's not showing. I checked twice. 

 

Screenshot_20250614_074143.thumb.png.b9557dd1da069f62a311a831ab7b7b98.png

yocker
Posted (edited)
9 minutes ago, CummingCowGirl said:

Just finally grabbed this to give it a spin. I run Arch based distros so it is a matter of shutting down the server, opening /var/lib/emby/ as administrator, opening the plugins folder and then dropping in the dll file, then sudo systemctl start emby-server. once that was done I went into plugins in the settings and it's not showing. I checked twice. 

 

Screenshot_20250614_074143.thumb.png.b9557dd1da069f62a311a831ab7b7b98.png

Must admit i haven't tested it in an Emby version running directly in Linux, closest is a docker container.
I will look into it, in the mean time can you supply me with a log file from Emby, preferably a debug enabled log?

Just in case.
Emby tends to have two plugins folders, be sure to install it in the right one. Sorry don't know where that is located in Linux but in Windows it's: AppData\Roaming\Emby-Server\system\plugins

Edited by yocker
  • Like 1
BillOatman
Posted (edited)

On my windows server the latest is having issues.  From the debug log
 

Quote

2025-06-14 12:27:27.587 Info Skia: SkiaSharp version: 2.88.0.0

Quote

    *** Error Report ***
    Version: 4.8.11.0
    Command line: C:\Users\woatm\AppData\Roaming\Emby-Server\system\EmbyServer.dll -noautorunwebapp
    Operating system: Microsoft Windows 10.0.26100
    Framework: .NET 6.0.36
    OS/Process: x64/x64
    Runtime: C:/Users/woatm/AppData/Roaming/Emby-Server/system/System.Private.CoreLib.dll
    Processor count: 12
    Data path: C:\Users\woatm\AppData\Roaming\Emby-Server\programdata
    Application path: C:\Users\woatm\AppData\Roaming\Emby-Server\system
    System.IO.FileNotFoundException: System.IO.FileNotFoundException: Could not load file or assembly 'SkiaSharp, Version=3.119.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756'. The system cannot find the file specified.
    File name: 'SkiaSharp, Version=3.119.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756'
       at EmbyIcons.EmbyIconsEnhancer.EnhanceImageInternalWithOverlaysAsync(BaseItem item, String inputFile, String outputFile, CancellationToken cancellationToken)
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
       at EmbyIcons.EmbyIconsEnhancer.EnhanceImageInternalWithOverlaysAsync(BaseItem item, String inputFile, String outputFile, CancellationToken cancellationToken)
       at EmbyIcons.EmbyIconsEnhancer.EnhanceImageInternalAsync(BaseItem item, String inputFile, String outputFile, ImageType imageType, Int32 imageIndex, CancellationToken cancellationToken)
    Source: EmbyIcons
    TargetSite: Void MoveNext()

Plugin seems to be looking for a much newer version.  I also noticed that the plugin source wont build for me because the project is missing the skiasharp nuget.  When I add that it builds, but is has that newest version.

Also @Lukeand @ebr, Visual Studio shows that version of skiasharp to be vulnerable.
image.png.303641358b8e7c8a58449d21bd1cedcc.png

Edited by BillOatman
yocker
Posted (edited)
6 minutes ago, BillOatman said:

On my windows server the latest is having issues.  From the debug log
 

Plugin seems to be looking for a much newer version.  I also noticed that the plugin source wont build for me because the project is missing the skiasharp nuget.  When I add that it builds, but is has that newest version.

The Skiasharp is taken from the Emby server install and not the Nuget to ensure using a version that was compatible with Emby.

You can download the already compiled DLL or use the one i sent here.

 

EmbyIcons.dll

Edited by yocker
  • Like 1
Posted (edited)
2 hours ago, yocker said:

Must admit i haven't tested it in an Emby version running directly in Linux, closest is a docker container.
I will look into it, in the mean time can you supply me with a log file from Emby, preferably a debug enabled log?

Just in case.
Emby tends to have two plugins folders, be sure to install it in the right one. Sorry don't know where that is located in Linux but in Windows it's: AppData\Roaming\Emby-Server\system\plugins

LOL luckily I do. Thanks

https://pastebin.com/qD6jzkbF

 

I decided to try you copy from a couple of post above and looks like that did the trick. Thanks

Edited by CummingCowGirl
yocker
Posted
11 minutes ago, CummingCowGirl said:

LOL luckily I do. Thanks

https://pastebin.com/qD6jzkbF

Think i found the fault when using it on Linux.
Testing fix now.

  • Like 1
yocker
Posted
30 minutes ago, CummingCowGirl said:

LOL luckily I do. Thanks

https://pastebin.com/qD6jzkbF

 

I decided to try you copy from a couple of post above and looks like that did the trick. Thanks

Try this one.
I tested this in a Linux environment and it works. Sadly i don't have an Arch install i can test on.

EmbyIcons.dll

  • Like 1
keitaro26
Posted

@yockerThe new overlays don't seem to respect the "horizontal settings". (ignore the horrible overlay images, still playing with the aspect ratio to get that right)

image.thumb.png.0f1fe0bc8ccece87ef5e4c4ea50372d3.png

 

image.thumb.png.9a9629d1796816b325dad1898956fed1.png

yocker
Posted
1 hour ago, keitaro26 said:

@yockerThe new overlays don't seem to respect the "horizontal settings". (ignore the horrible overlay images, still playing with the aspect ratio to get that right)

image.thumb.png.0f1fe0bc8ccece87ef5e4c4ea50372d3.png

 

image.thumb.png.9a9629d1796816b325dad1898956fed1.png

Wops, forgotten some stuff when i added that feature.

This should fix it.

EmbyIcons.dll

yocker
Posted
5 minutes ago, keitaro26 said:

Still vertical stacked for me no matter what settings I select.

That's strange, it should absolutely work now.

Try:
1) Temporary moving the overlays to another corner.
2) Refreshing metadata on a movie/TV show.

This forces the cache to empty and redraws the overlays.

keitaro26
Posted
3 minutes ago, yocker said:

That's strange, it should absolutely work now.

Try:
1) Temporary moving the overlays to another corner.
2) Refreshing metadata on a movie/TV show.

This forces the cache to empty and redraws the overlays.

Moving them to another corner worked, but switching it back made it vertical again (even after metadata refresh) until I edited the images and downloaded the cover again, but now it is working on that item. Just have to do the rest of them now, haha.

 

image.thumb.png.ec964881300a9b509c844ee56540267c.png

yocker
Posted

Yeah that will be the cache. I will look into making it update better. It will take a while though.
It's simply using an old poster drawing and not giving you a new one, this can happen in a few occasions.

If you have the nerve for it you can try manually clearing the cache in Embys folder.
I usually do this when testing, but it's still at your own risk! ;)

keitaro26
Posted

Would there be a way to have a setting to use the actual overlay image sizes instead of calculating them based on the short side of the poster?

keitaro26
Posted
17 minutes ago, keitaro26 said:

Would there be a way to have a setting to use the actual overlay image sizes instead of calculating them based on the short side of the poster?

Looking through the code, I realize this would be a major revision. I can work around the limitation, but if you feel like it would be a good enhancement in the future, it would make it so we could use non-square images. 😀

yocker
Posted

You can do what ever with the code you want, even release you open version of that is what you want. :)

  • Like 1
keitaro26
Posted
1 minute ago, yocker said:

You can do what ever with the code you want, even release you open version of that is what you want. :)

Its a bit beyond my experience level to make that size of a change at the moment, but I might tinker with it here and there. I'm perfectly happy with what you've done so far, just wanted to throw an idea at you. Carry on good sir!

yocker
Posted
1 minute ago, keitaro26 said:

Its a bit beyond my experience level to make that size of a change at the moment, but I might tinker with it here and there. I'm perfectly happy with what you've done so far, just wanted to throw an idea at you. Carry on good sir!

It's very much appreciated! :)

Btw. forgot to say.
The plugin was made to calculate the icon sizes that way because posters are different sizes and would affect the overlays.

keitaro26
Posted
1 minute ago, yocker said:

It's very much appreciated! :)

Btw. forgot to say.
The plugin was made to calculate the icon sizes that way because posters are different sizes and would affect the overlays.

Any idea how CoverArt is doing it? They seem to allow any width with a set height.

yocker
Posted
14 minutes ago, keitaro26 said:

Any idea how CoverArt is doing it? They seem to allow any width with a set height.

No, sorry.

CoverArt is closed source so it hard to know. You can try and ask Ebr if he wants to tell that secret.

Posted
17 hours ago, yocker said:

Try this one.
I tested this in a Linux environment and it works. Sadly i don't have an Arch install i can test on.

EmbyIcons.dll 1.55 MB · 2 downloads

Ok I tested that one and under plugins it shows up, but I'm not seeing any added setting on the context menu, nor getting anything of I right click various spots on a poster. I created a folder in my downloads for icons and downloaded a test icon. I sized it to 100x100, made sure to save it a png, pointed EmbyIcons to that folder and nothing still. It's not a huge deal, but would be nice for shows and movies I have that aren't in English so others would know what to expect before selecting them to watch.

yocker
Posted
31 minutes ago, CummingCowGirl said:

Ok I tested that one and under plugins it shows up, but I'm not seeing any added setting on the context menu, nor getting anything of I right click various spots on a poster. I created a folder in my downloads for icons and downloaded a test icon. I sized it to 100x100, made sure to save it a png, pointed EmbyIcons to that folder and nothing still. It's not a huge deal, but would be nice for shows and movies I have that aren't in English so others would know what to expect before selecting them to watch.

Luke did mention that my user of Skiasharp might make it incompatible with some versions of Emby.

It might also be a permutations problem on your side where emby and there for the plugin doesn't have access to the icons. 

I'm still looking into it but I sadly have little idea what to look for.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...