yocker 1247 Posted May 19, 2025 Author Posted May 19, 2025 (edited) 4 minutes ago, keitaro26 said: No worries at all, I appreciate how quick you are! It seems like something may have gotten messed up or disconnected with CoverArt, not sure exactly why, but its working now after a fresh install of the CoverArt plugin. 7 minutes ago, keitaro26 said: Uninstalling and reinstalling CoverArt fixed the problem. Nice, can you try the last version as well? Just for good measure. Edited May 19, 2025 by yocker
keitaro26 22 Posted May 19, 2025 Posted May 19, 2025 16 minutes ago, yocker said: Nice, can you try the last version as well? Just for good measure. Looks like it is working.
yocker 1247 Posted May 19, 2025 Author Posted May 19, 2025 Thank you. It's not much but will add a thank you in the readme as well.
yocker 1247 Posted May 20, 2025 Author Posted May 20, 2025 (edited) @Neminem Can you test this version please? Give it a real hard test as well as i changed some caching. No more refresh metadata should be needed (unless it's the first time a file is being scanned like normal) No more server restarts needed for anything. When changing icon files, you will need to change their position for it to take effect. Haven't figured out how to refresh it without needed to do that. But at least no server restart needed so huge improvement! Unknown: When added new icons for new languages still need a metadata refresh, i don't have any files with foreign languages to test with. It should work without metadata refresh though. EmbyIcons.dll Edited May 20, 2025 by yocker
GrimReaper 4739 Posted May 20, 2025 Posted May 20, 2025 While you're at it, would it be possible do add vertical positioning setting (either as an offset from default badge position or top/bottom poster edge padding)? Thanks
yocker 1247 Posted May 20, 2025 Author Posted May 20, 2025 1 hour ago, GrimReaper said: While you're at it, would it be possible do add vertical positioning setting (either as an offset from default badge position or top/bottom poster edge padding)? Thanks Will add it to the Todo list. Doing som major changes though so don't know when it will be done. 1
yocker 1247 Posted May 20, 2025 Author Posted May 20, 2025 (edited) 1 hour ago, GrimReaper said: While you're at it, would it be possible do add vertical positioning setting (either as an offset from default badge position or top/bottom poster edge padding)? Thanks A friend had already made it or has a red glowing keyboard after he read your post. So i added it to the code. It's beta though as i'm trying to fix so this Plugin and CoverArt don't have to wait for each other. It will 100% work but will give errors reports in the log that it had to wait for files since they were in use. Quite funny seeing what plugin gets to the files the fastest and what plugin has to try again. @NeminemIgnore the last .dll, try this one please if you are willing and have the time. EmbyIcons.dll Edited May 20, 2025 by yocker
GrimReaper 4739 Posted May 20, 2025 Posted May 20, 2025 2 minutes ago, yocker said: A friend had already made it or has a red glowing keyboard after he read your post. So i added it to the code. Thanks, will test it once in front of a PC. Appreciate it (and kudos to the friend). Cheers
Neminem 1518 Posted May 20, 2025 Posted May 20, 2025 54 minutes ago, yocker said: Ignore the last .dll, try this one please if you are willing and have the time. Will test later or tomorrow, heading out with customer for diner.
yocker 1247 Posted May 20, 2025 Author Posted May 20, 2025 8 minutes ago, Neminem said: Will test later or tomorrow, heading out with customer for diner. With a customer? Isn't that usually a big no no? Jokes aside, there's no rush. You have already helped more than i could ask for.
Neminem 1518 Posted May 20, 2025 Posted May 20, 2025 1 minute ago, yocker said: With a customer? Isn't that usually a big no no? Its a work customer. I don't have Emby customers, only family or friends. And Emby is not my work, well anyways they don't pay me
yocker 1247 Posted May 20, 2025 Author Posted May 20, 2025 6 minutes ago, Neminem said: Its a work customer. I don't have Emby customers, only family or friends. And Emby is not my work, well anyways they don't pay me I did mean your work, not Emby! Enjoy! 1
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 (edited) New version up. Added: More icon placement options. Fixed: Metadata refresh or server restart no longer needed for icon placement changes. Fixed: Better file handling and optimizations. Note: Changing an icon to another of the same name might still need a server restart or metadata refresh before the change will show. Note: When used together with other plugins that draw in the video poster errors might show in the Emby log. These can be safely ignored as they are about the plugins trying to basically compete about who gets to the files first, this is not a problem so unless you experience any problems just ignore the errors. This plugin is made with best practice file handling to be able to handle these situations. Edited May 21, 2025 by yocker
Neminem 1518 Posted May 21, 2025 Posted May 21, 2025 What version did you want me to test. I see v1.17 is the latest on github but that was updated 13 hours ago
Neminem 1518 Posted May 21, 2025 Posted May 21, 2025 I have done some testing with placement of flags. This looks a little strange. TV show : The images that look good, has a size range between 900 - 1300 height. Where the 1 that looks off has a height 2160. Movies : These are all over the place
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 3 hours ago, Neminem said: I have done some testing with placement of flags. This looks a little strange. TV show : The images that look good, has a size range between 900 - 1300 height. Where the 1 that looks off has a height 2160. Movies : These are all over the place Haha, think i see the problem, the vertical setting doesn't follow the same size normalizing as the other settings. Looking into it now.
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 New release up. Changed the vertical positioning setting to use procentage based positioning instead. Should fix the problem with the positioning being different based on different sized posters. EmbyIcons.dll 2
Neminem 1518 Posted May 21, 2025 Posted May 21, 2025 (edited) Nice I think that did it. It looks a lot better. I did have to fiddle with the numbers, now that they are % Movies : Tv Show : Edited May 21, 2025 by Neminem 1 1
Neminem 1518 Posted May 21, 2025 Posted May 21, 2025 Is there any way of excluding extra folders, as I don't have subs for all the extras. So that only season 1 - xx is used, when creating flags for tv show poster. I would guess this is not easy to do
MagicDoubleM 121 Posted May 21, 2025 Posted May 21, 2025 Very nice work here man, thank you very much! It might or might not be of interest for you, but we have this little gem hidden in the forum: If you would drop a DLL into the GitHub-releases, this should pick your plugin up.
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 (edited) 52 minutes ago, MagicDoubleM said: Very nice work here man, thank you very much! It might or might not be of interest for you, but we have this little gem hidden in the forum: If you would drop a DLL into the GitHub-releases, this should pick your plugin up. You mean instead of the normal .zip files i release or a .dll together with the code? Put a .dll into the release, will try and remember to do that from now if that's what you mean. Edited May 21, 2025 by yocker 1
MagicDoubleM 121 Posted May 21, 2025 Posted May 21, 2025 44 minutes ago, yocker said: You mean instead of the normal .zip files i release or a .dll together with the code? Put a .dll into the release, will try and remember to do that from now if that's what you mean. Thanks! Yes exactly, the plugin picks up dlls and auto-updates them. 1
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 @MagicDoubleM Did a little test of that plugin. I changed the nuget packages and some version numbers in the csproj, seems to work stable on non beta version 4.8.11.0 of Emby in case you are interested. At your own risk if you do this but works fine here as far a i can see. 1
Neminem 1518 Posted May 21, 2025 Posted May 21, 2025 According to plugin creator its to be used by 4.9 only
yocker 1247 Posted May 21, 2025 Author Posted May 21, 2025 39 minutes ago, Neminem said: According to plugin creator its to be used by 4.9 only Yeah, it why i said to do it on your own risk. Works fine with the change here though, ofc. doesn't mean it will for all. 1 1
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now