Jump to content

Plugin: EmbyIcons release.


Recommended Posts

Posted (edited)

Nevermind, looks like you updated while I was typing that out.

Edited by WJCuffe
Redundant
  • Like 1
Posted

@yockerHa did not notice that 😂🤣

Here is what I see now 👍

image.png.a261f042b7544349b4de0d57b4ce2cf2.png

  • Like 1
Posted
2 minutes ago, WJCuffe said:

@yocker Not urgent, but you might want to nudge the percentage for splat/tomato to 60%.  That's the actual variance point (official percentages here: https://www.rottentomatoes.com/about )

You're right, i will change that!
Maybe i should remove the fresh as well as that has whole other criteria's that i thought and just leave it at the two icons.
What do you think?

I thought i knew the ratings system for Rotten Tomatoes, apparently i knew nothing. :D 

Posted

Here are some transparent pngs for icons.  While I was at it, threw in the popcornmeter icons too, in case they're ever usable.

t.fresh.png

t.splat.png

t.tomato.png

t.spilled.png

t.popcorn.png

  • Like 1
  • Thanks 1
Posted

I'd say leave the Certified Fresh rating.  It's just a matter of time for the requisite number of reviews to come in, and by that time it's generally pretty clear if it will drop to just Fresh.  Drawback I see is that users might have to wait or do a manual refresh to find out that score has changed.

  • Like 1
Posted

@WJCuffe
WOW! Thanks for the icons! I will put them to good use. :) 

Thanks for the input, i will think it over and see if my OCD will let keep the fresh if people want it.

Thanks again for the icons!

Posted (edited)

New release v5.40.3.

Added Rotten Tomatoes Rating.
This will use t.splat.png and t.tomato.png in the icons folder if using custom icons.

To work you have to enable The Open Movie Database metadata as that is where Emby gets the ratings from.
image.thumb.png.6a49f704c2397fe66f0bce6823a04733.png

Download here or on EmbyIcons Github 

Thank you to @Neminemand @WJCuffefor helping!!!
Btw. WJCuffe sorry for not including the fresh icon, i talked to my friends and they all advised me to not use it as it was not correct and to avoid any confusion.
I can look into readding it as an option or making it better if you want it.

EmbyIcons.dll

Edited by yocker
  • Like 1
Posted (edited)

For some reason, the RT rating font does not align with the community rating value in terms top margin or am I missing something? Dimensions of both icons are the same. Could the comma in community rating be the culprit? It seems the RT rating aligns with the comma.

image.png.cc51ca544e5de9591a0448f545d6e814.png

 

One other suggestion: It would be nice the be able to not display the % in RT rating as an option.

Edited by sh0rty
  • Thanks 1
Posted
3 minutes ago, sh0rty said:

For some reason, the RT rating font does not align with the community rating value in terms top margin or am I missing something? Dimensions of both icons are then same. Could the comma in community rating be the culprit? It seems the RT rating aligns with the comma.

image.png.cc51ca544e5de9591a0448f545d6e814.png

I some how missed this, i will look into it.
Thanks for reporting! :) 

  • Like 1
Posted
15 minutes ago, sh0rty said:

For some reason, the RT rating font does not align with the community rating value in terms top margin or am I missing something? Dimensions of both icons are the same. Could the comma in community rating be the culprit? It seems the RT rating aligns with the comma.

image.png.cc51ca544e5de9591a0448f545d6e814.png

 

One other suggestion: It would be nice the be able to not display the % in RT rating as an option.

That is strange, i can't replicate it at all and i use a "." in the numbers for the IMBd ratings.
I need to ask:
Are you using another plugin for the IMDb ratings?
Did you download the latest version above your post?
Are you using custom icons? I can't replicate it my self with this either but you might have hit a size for the icon that doesn't play well with the rest.

image.png.5ed1f534881249c3e79cf0edfcbdd302.png

Posted (edited)
6 minutes ago, yocker said:

That is strange, i can't replicate it at all and i use a "." in the numbers for the IMBd ratings.
I need to ask:
Are you using another plugin for the IMDb ratings?
Did you download the latest version above your post?
Are you using custom icons? I can't replicate it my self with this either but you might have hit a size for the icon that doesn't play well with the rest.

image.png.5ed1f534881249c3e79cf0edfcbdd302.png

No, no other plugin for ratings. This is what Emby gives me... 

image.png.38da44b4793596791ea746c6443fb0a3.png image.png.b2ea28445b8fd25f2e673cdefbfeaed0.png

Movie Metadata:
image.png.a8464f9ffceb5e2fcb8ce7d56d7a37de.png

TV Show Metadata:
image.png.882946f8ba852780aa84d5e66574cc5d.png

Yes I use the latest plugin version. But it was always a comma since day one with your plugin.

And yes, I use custom icons.

Edited by sh0rty
Posted
2 minutes ago, sh0rty said:

No, no other plugin for ratings. This is what Emby gives me... 

image.png.38da44b4793596791ea746c6443fb0a3.png image.png.b2ea28445b8fd25f2e673cdefbfeaed0.png

Movie Metadata:
image.png.a8464f9ffceb5e2fcb8ce7d56d7a37de.png

TV Show Metadata:
image.png.882946f8ba852780aa84d5e66574cc5d.png

Yes I use the latest plugin version. But it was always a comma since day one with your plugin.

And yes, I use custom icons.

Thank you, all the info i need for now. :) 

  • Like 1
Posted (edited)
3 minutes ago, yocker said:

Thank you, all the info i need for now. :) 

Could it be the language setting? Germans love their comma for everything 🤣 @softworkz

Edited by sh0rty
Posted
1 minute ago, sh0rty said:

Could it be the language setting? Germans love their comma for everything 🤣

That is my guess too.
The plugin uses it's own font so in theory it shouldn't be able to happen but the way i set it up it might just nudge the line up a bit.

I will fix it as soon as i can, i'm very busy at the moment so might take a little while but if i get the time it will be dedicated to this!

  • Like 1
Posted (edited)
2 hours ago, yocker said:

That is my guess too.
The plugin uses it's own font so in theory it shouldn't be able to happen but the way i set it up it might just nudge the line up a bit.

I will fix it as soon as i can, i'm very busy at the moment so might take a little while but if i get the time it will be dedicated to this!

I guess the cleanest way would be to substitute the , with a . I made it this way with the spotlight banner. 

For the comma vs. period (line 283 and 371 in ImageOverlayService.cs):
 

scoreText = rating.Score.ToString("F1", System.Globalization.CultureInfo.InvariantCulture);

System.Globalization.CultureInfo.InvariantCulture substitutes the comma with period.

image.png.069b39449e516a5f0fb2c1642e41c2fd.png

I removed the % for RT by myself, an option would be nice nevertheless.

Thanks for the new version with RT and take your time!

Edited by sh0rty
Posted (edited)
25 minutes ago, sh0rty said:

I guess the cleanest way would be to substitute the , with a . I made it this way with the spotlight banner. 

You are a genius! I was about to make so it couldn't go past this and this scale. I have a tendency to overthink things at times. :)
A simple replace "," with "." fixed it. Very fast way to fix it.

image.png.afcb5eaf5cdc8b032ac9c85a92139c55.png

Will add it to Github later but for now back to the things i have to do before people get annoyed with me.
Please report if i messed up again. 👍

EmbyIcons.dll

Edited by yocker
  • Like 2
Posted

@sh0rty Do you by chance know where Emby controls the context menu when right clicking a video?
Trying to make some report system or something.

Posted
5 minutes ago, yocker said:

@sh0rty Do you by chance know where Emby controls the context menu when right clicking a video?
Trying to make some report system or something.

Should be the contents of /modules/actionsheet/ (actionsheet.js and actionsheet.css).

  • Thanks 1
Posted

Many thanks!

Posted
3 hours ago, sh0rty said:

Should be the contents of /modules/actionsheet/ (actionsheet.js and actionsheet.css).

Thanks to you, me and a friend got this made 👍:

image.png.a0f6d2520251853ffcecac95d7a6f5e3.png
image.png.eb60169b3f3c6dd295acd8cb5cf2f4bd.pngimage.png.43a4da8d29319c077682b6631f5a4ef4.png

  • Like 2
Posted
16 hours ago, sh0rty said:

Could it be the language setting? Germans love their comma for everything 🤣 @softworkz

16 hours ago, sh0rty said:
scoreText = rating.Score.ToString("F1", System.Globalization.CultureInfo.InvariantCulture);

System.Globalization.CultureInfo.InvariantCulture substitutes the comma with period.

This is the right way!

  • Like 2
GrimReaper
Posted (edited)
8 hours ago, yocker said:


image.png.43a4da8d29319c077682b6631f5a4ef4.png

Where does that message appear for the Admin? It'd be great if it were Alerts section of the Dashboard. Though I suppose dedicated tab in plugin settings would work just as well, so all reports would be grouped and easy to follow. Or both. 😬

Edited by GrimReaper
Posted
3 hours ago, GrimReaper said:

Where does that message appear for the Admin? It'd be great if it were Alerts section of the Dashboard. Though I suppose dedicated tab in plugin settings would work just as well, so all reports would be grouped and easy to follow. Or both. 😬

For now It shows up in the plugin settings and on push over notifications to the phone.

  • Thanks 1
Posted

Maybe someone already reply to this request, buy i didn't find it.

Is it possible to install on a synology version of emby?

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...