Jump to content

Plugin: EmbyIcons release.


Recommended Posts

IAmHugh
Posted
2 hours ago, yocker said:

while not Arch i have tested on other Linux systems without problems.

For some reason in Arch the Emby folder is locked while Emby's systemd service is running. From what Luke has implied more than a few times with other Linux variations it's not locked.

MagicDoubleM
Posted

Wow, very cool!

yocker
Posted
3 hours ago, CummingCowGirl said:

For some reason in Arch the Emby folder is locked while Emby's systemd service is running. From what Luke has implied more than a few times with other Linux variations it's not locked.

I found this:

Arch Linux's default systemd service file for Emby uses ProtectSystem=full and ProtectHome=yes and other sandboxing options.

You  can relax or customize the systemd sandbox for Emby.

Edit the service files:
Run:
  sudo systemctl edit emby-server

Add an [Service] override:
   [Service]
   ProtectSystem=off
   ProtectHome=off

Save and reload:

Use at your own risk as i don't have much, if any, knowledge of Arch.

  • Like 1
yocker
Posted (edited)

For the people wanting to test here's a quick beta.

It should be bug free as i havn't touched any of the underlying stuff but always good with more people looking at it.
Also some icons to test with, you can ofc. replace them with your own.
The tag.png is needed for the preview, debating with my self if i should embed it in the code or leave it like this so people can customize.

WARNING!! WARNING!! WARNING!!
Beta, so there might be unforeseen problems!!

Edit:
Forgot the change list.

Added:
Overlays for audio and video formats.
Overlays for custom tags. For example add a tag named "bob" to a video and the plugin will look for a "bob.png" (or jpg) in the icons folder to overlay.
The readme in the settings page explains all the icon names.

EmbyIcons.dll Icons.zip

Edited by yocker
  • Like 1
sh0rty
Posted (edited)

The Tag setting seems to do nothing when generating the images. I setup the tag "IMAX" in EmbyIcons setting and pushed the file IMAX.png into the icon folder, but The icon is not shown on the cover for the specific movies. tag.png for the preview is working though. Cleared Browser cache end even deleted contents in enhanced-images folder in image cache. Log is attached. Movies that should show IMAX logo are Blood & Sinners + Tron Legacy in log.

embyserver (1).txt

Edited by sh0rty
  • Thanks 1
yocker
Posted (edited)
1 hour ago, sh0rty said:

The Tag setting seems to do nothing when generating the images. I setup the tag "IMAX" in EmbyIcons setting and pushed the file IMAX.png into the icon folder, but The icon is not shown on the cover for the specific movies. tag.png for the preview is working though. Cleared Browser cache end even deleted contents in enhanced-images folder in image cache. Log is attached. Movies that should show IMAX logo are Blood & Sinners + Tron Legacy in log.

embyserver (1).txt 2.15 MB · 0 downloads

That's because i'm yet again an idiot and posted the wrong version.
Very sorry for that, i gave a version the wrong version number in my files so it ended up here by mistake.

Here's the right one.

EmbyIcons.dll

Edited by yocker
  • Haha 1
sh0rty
Posted

Working now! Man this is super dope!

image.png.49787cacc6f4b79caa8168ca8249ab7e.png

  • Like 1
sh0rty
Posted (edited)

@yockerAre the 97x76 dimensions fixed for the icons? If yes, is it possible in a future update to increase the width of the used icons dynamically? For example my IMAX logo just fits into the 97x76 template if I make it a lot smaller than e.g. the Dolby Vision icon.

image.png.394f2a8bd18179baad8d2b7b201ac244.png

It would be really cool if just the height of 76 would be fixed and the width would be dynamic so I could use a 130x76 logo e.g. Currently it seems that a logo larger than the 97x76 value gets squeezed into that dimension and gets a bit distorted.

e.g. 140x76 icon:
image.png.51feca5cc5ff139a803eb1c83c0ee91d.png

Edited by sh0rty
yocker
Posted
1 hour ago, sh0rty said:

@yockerAre the 97x76 dimensions fixed for the icons? If yes, is it possible in a future update to increase the width of the used icons dynamically? For example my IMAX logo just fits into the 97x76 template if I make it a lot smaller than e.g. the Dolby Vision icon.

image.png.394f2a8bd18179baad8d2b7b201ac244.png

It would be really cool if just the height of 76 would be fixed and the width would be dynamic so I could use a 130x76 logo e.g. Currently it seems that a logo larger than the 97x76 value gets squeezed into that dimension and gets a bit distorted.

e.g. 140x76 icon:
image.png.51feca5cc5ff139a803eb1c83c0ee91d.png

Good point.
Will look at it in the next version.

  • Thanks 1
yocker
Posted
5 hours ago, sh0rty said:

@yockerAre the 97x76 dimensions fixed for the icons? If yes, is it possible in a future update to increase the width of the used icons dynamically? For example my IMAX logo just fits into the 97x76 template if I make it a lot smaller than e.g. the Dolby Vision icon.

image.png.394f2a8bd18179baad8d2b7b201ac244.png

It would be really cool if just the height of 76 would be fixed and the width would be dynamic so I could use a 130x76 logo e.g. Currently it seems that a logo larger than the 97x76 value gets squeezed into that dimension and gets a bit distorted.

e.g. 140x76 icon:
image.png.51feca5cc5ff139a803eb1c83c0ee91d.png

Please see if this in an improvement.

EmbyIcons.dll

sh0rty
Posted (edited)
3 hours ago, yocker said:

Please see if this in an improvement.

EmbyIcons.dll 2.11 MB · 1 download

It seems there is no significant change to the produced coverart image. Seems the image is still streched vertically.

original Aspect ratio (image size 186x76px):
image.png.d0a6dab6aa758449fc1ef854bd739810.png

aspect ratio in cover:
image.png.6b115567b6757cef653077d53b151a45.png

Edited by sh0rty
yocker
Posted
46 minutes ago, sh0rty said:

It seems there is no significant change to the produced coverart image. Seems the image is still streched vertically.

original Aspect ratio (image size 186x76px):
image.png.d0a6dab6aa758449fc1ef854bd739810.png

aspect ratio in cover:
image.png.6b115567b6757cef653077d53b151a45.png

Try this.
Not sure i like the outcome though. Might just be my icons.

EmbyIcons.dll

sh0rty
Posted (edited)
46 minutes ago, yocker said:

Try this.
Not sure i like the outcome though. Might just be my icons.

EmbyIcons.dll 2.11 MB · 0 downloads

I'm a dumbfuck, I forgot to restart Emby Server after downloading your next-to-last dll. Nevertheless with both last dlls tag icons are not inserted into the image. Do you need a log?

But the icons I see now are not distorted anymore and have the exact aspect ratio as the source pngs. So it seems you're on a good way.
Now:
image.png.8351a98bb13585fe859a8cc37dc6c606.png

Before:
image.png.16497a5f02cae2681ae09afc1f61a961.png

Edited by sh0rty
yocker
Posted (edited)
33 minutes ago, sh0rty said:

I'm a dumbfuck, I forgot to restart Emby Server after downloading your next-to-last dll. Nevertheless with both last dlls tag icons are not inserted into the image. Do you need a log?

But the images I see are not distorted anymore. So it seems you're on a good way.
Now:
image.png.8351a98bb13585fe859a8cc37dc6c606.png

Before:
image.png.16497a5f02cae2681ae09afc1f61a961.png

That damn f.ing version number..
I did all that work on the wrong version again.. Deleted that now! :)

Some quick copy and paste of the icon size stuff and it should work now.

EmbyIcons.dll

Edited by yocker
  • Thanks 1
sh0rty
Posted
12 minutes ago, yocker said:

That damn f.ing version number..
I did all that work on the wrong version again.. Deleted that now! :)

Some quick copy and paste of the icon size stuff and it should work now.

EmbyIcons.dll 2.11 MB · 0 downloads

Yes, now the aspect ratio is correct! Well done!

image.png.df0184a1aeae1b00373fd944b4443ae9.png

  • Like 1
yocker
Posted

The new version is up.

Added:

Ability to show audio and video codec overlays.
Overlays for tags.
Read the readme in the settings for how to use these.

Changed:
Changed the overlay sizing slightly so they scale based on height only.

Download at EmbyIcons Github or here.

EmbyIcons.zip

  • Like 1
keitaro26
Posted
2 hours ago, yocker said:

The new version is up.

Added:

Ability to show audio and video codec overlays.
Overlays for tags.
Read the readme in the settings for how to use these.

Changed:
Changed the overlay sizing slightly so they scale based on height only.

Download at EmbyIcons Github or here.

EmbyIcons.zip 2.41 MB · 0 downloads

Tested on both stable and beta, working great!

keitaro26
Posted (edited)
8 minutes ago, keitaro26 said:

Tested on both stable and beta, working great!

@yockerspoke too soon, getting some false positives on 4K detection:

image.thumb.png.b8b04d846acf1d635090f6d04a4df091.png

image.png.1cf7f70374d13e041c5aa6e316672f4f.png

Edited by keitaro26
yocker
Posted
23 minutes ago, keitaro26 said:

@yockerspoke too soon, getting some false positives on 4K detection:

image.thumb.png.b8b04d846acf1d635090f6d04a4df091.png

image.png.1cf7f70374d13e041c5aa6e316672f4f.png

That should not be possible.
The detecting is:

            if (width >= 3200 || height >= 1500) return "4k";
            if (width >= 1800 || height >= 780) return "1080p";
            if (width >= 1200 || height >= 650) return "720p";
            if (height >= 540) return "576p";
            if (height >= 400) return "480p";

So that video should correctly be detected as 1080p.
Does the video by chance have multiple video streams or imbedded pictures?

keitaro26
Posted
6 minutes ago, yocker said:

That should not be possible.
The detecting is:

            if (width >= 3200 || height >= 1500) return "4k";
            if (width >= 1800 || height >= 780) return "1080p";
            if (width >= 1200 || height >= 650) return "720p";
            if (height >= 540) return "576p";
            if (height >= 400) return "480p";

So that video should correctly be detected as 1080p.
Does the video by chance have multiple video streams or imbedded pictures?

Good guess, I guess the one's with the false positives have embedded covers that are reading as mjpeg by Emby at a higher resolution. I can fix that on my end. :)

yocker
Posted
3 minutes ago, keitaro26 said:

Good guess, I guess the one's with the false positives have embedded covers that are reading as mjpeg by Emby at a higher resolution. I can fix that on my end. :)

Please report beck on that.

It does raise an issue though, i will make so it only checks the first media stream in the next version.

keitaro26
Posted
1 minute ago, yocker said:

Please report beck on that.

It does raise an issue though, i will make so it only checks the first media stream in the next version.

Removing the embedded image fixed the false positive. All good for now.

  • Like 1
yocker
Posted
1 minute ago, keitaro26 said:

Removing the embedded image fixed the false positive. All good for now.

Thank you.

Hadn't thought about embedded pictures until now tbh. :)

sh0rty
Posted
4 hours ago, keitaro26 said:

Removing the embedded image fixed the false positive. All good for now.

Had that phenomenon also previously. The mjpeg embeddings are messing some things up sometimes, e.g. my PotPlayer is not able to play a file with mjpeg embeddings.

 

4 hours ago, yocker said:

Thank you.

Hadn't thought about embedded pictures until now tbh. :)

Some Release Groups embed the cover into the file this way, but it's more of a hustle instead of a benefit (at least at my end).

sh0rty
Posted (edited)

At least, the plugin outcome looks awesome! I encourage everyone profiting from this to support such committed devs like @yockerand buy him a ☕ via his GH page. Or two!

image.png.c71b25740c29bb71802994caaa4d279d.png

I just use it for HDR, Rating and IMAX as Tag. I just modified the image size to fit with the coverart plugin. In case someone finds the icons useful (I use MetroCase, EmbyIcons icon size: 8%):
hdr.png.354b31391ee45f41c56da98671036a9b.pnghdr10plus.png.0e51d1687ea277a36458d956e20e6a75.pngIMAX.png.26112291689aedd5065187b1fdc65761.pngimdb.png.31082f8a110750e1e10913cb4c7b2cf6.png   dv.png.9483ecbd68af2758c772526694bf2a36.png

Edited by sh0rty
  • Thanks 1

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...