Jump to content

Plugin: EmbyIcons release.


Recommended Posts

keitaro26
Posted
3 hours ago, yocker said:

Wops, you are right.
Don't know why i wrote your name, sorry about that!

Sadly to late to change it now.
@keitaro26
As you can see the message was for you. :)

 

Still crashing on a fresh install of the beta with both the github version and the special version above. I monitored my system resources as I rebooted the docker and it doesn't look like I am getting hit too hard. I gave the container full access to the system, so it should have been able to grab the entire CPU if it wanted to, but that didn't seem to happen.

keitaro26
Posted (edited)
25 minutes ago, keitaro26 said:

Still crashing on a fresh install of the beta with both the github version and the special version above. I monitored my system resources as I rebooted the docker and it doesn't look like I am getting hit too hard. I gave the container full access to the system, so it should have been able to grab the entire CPU if it wanted to, but that didn't seem to happen.

@yockerDone some further tinkering. If I load the DLL and start the server and do not save settings on the plugin page, no crashing. Obviously there is not any icons being applied since the default icon location is not matching where my icon files are at, but I do see it processing in the logs. If I save the settings without changing anything, it generates the XML file and no crashing. If I swap the folder to my icon location without any other changes, icons start showing up, no crashing. When I add the library restriction to only apply to my Anime or my Movies library, boom, constant crashing.

 

Edit: If I don't restrict libraries, I can even disable lite mode and caching and it works pretty instantly, so definitely not a resource issue.

Edited by keitaro26
yocker
Posted (edited)
1 hour ago, keitaro26 said:

@yockerDone some further tinkering. If I load the DLL and start the server and do not save settings on the plugin page, no crashing. Obviously there is not any icons being applied since the default icon location is not matching where my icon files are at, but I do see it processing in the logs. If I save the settings without changing anything, it generates the XML file and no crashing. If I swap the folder to my icon location without any other changes, icons start showing up, no crashing. When I add the library restriction to only apply to my Anime or my Movies library, boom, constant crashing.

 

Edit: If I don't restrict libraries, I can even disable lite mode and caching and it works pretty instantly, so definitely not a resource issue.

Yeah that not a resource problem as i thought.


And i just got mine to replicate the problem, will look into it.

Edited by yocker
yocker
Posted

@keitaro26
This should fix the bug.
Plus while i was at it anyway i have added some more user friendly way of enabling/disabling the libraries i have made for a later time.

Thank you for your wonderful debugging with this! :)

EmbyIcons.dll

  • Like 1
keitaro26
Posted
7 minutes ago, yocker said:

@keitaro26
This should fix the bug.
Plus while i was at it anyway i have added some more user friendly way of enabling/disabling the libraries i have made for a later time.

Thank you for your wonderful debugging with this! :)

EmbyIcons.dll 2.08 MB · 0 downloads

This is working perfectly! I also really like the check boxes for the libraries, I think it is a good UI improvement!

  • Like 1
yocker
Posted (edited)
1 hour ago, keitaro26 said:

This is working perfectly! I also really like the check boxes for the libraries, I think it is a good UI improvement!

Great to hear!
I'm afraid of saying what the fault was as it would make me feel extremely stupid, so i wont! ;)

What i will say is, many thanks again!

Edited by yocker
  • Like 1
  • Thanks 1
MediaIntelNUC
Posted

Hi!

Thanx 4 what looks like an AWESOME plug-in!

Im trying to get everything working on my Windows server, a few questions that might help me:)

Does it read .xml or .nfo or both formats?

My files have nfo attached and it gets some info wrong,  for instance it displays 720p instead of 1080.

Also, i dont get the option to select language in the settings, like eng, etc..

I would just like to confirm the language code for Swedish, is it  sve,sv or swe?

Cause it doesnt show swedish subtitles, some are Swedish Subrip but most are external srt with sv.srt namned and Emby does regonice them as subtitles with Swedish as preset in server-settings.

Thanx!

yocker
Posted
15 minutes ago, MediaIntelNUC said:

Hi!

Thanx 4 what looks like an AWESOME plug-in!

Im trying to get everything working on my Windows server, a few questions that might help me:)

Does it read .xml or .nfo or both formats?

My files have nfo attached and it gets some info wrong,  for instance it displays 720p instead of 1080.

Also, i dont get the option to select language in the settings, like eng, etc..

I would just like to confirm the language code for Swedish, is it  sve,sv or swe?

Cause it doesnt show swedish subtitles, some are Swedish Subrip but most are external srt with sv.srt namned and Emby does regonice them as subtitles with Swedish as preset in server-settings.

Thanx!

Thank you! :)

It gets it info straight from Emby, so everything relevant Emby reports the plugin sees.

            if (height >= 1500) return "4k";
            if (height >= 1440) return "1440p";
            if (height >= 1080) return "1080p";
            if (height >= 720) return "720p";
            if (height >= 576) return "576p";
            if (height >= 480) return "480p";

It uses this to determine the resolution of the files. What's causing your problem might be wide formats, i can look into making it a bit better with those.

Something i already did with the 4K as you can see.

I removed the option to choose languages as it can easily be controlled by simply what icons you add to the plugin.

List of ISO 639 language codes - Wikipedia
It uses the 3 letter language codes, it also supports most 2 letter once.
As long as you have the "srt.swe.jpg"(or png) file in the icons folder it should work.

Neminem
Posted

Also seeing some weird resolution display. 

Chosen icon is 720p, but the movie is 1080p with aspect ratio 40:17 = 2.35:1.

Width :    1920 pixels
Height :    816 pixels

Guess the aspect ratio is messing with the icon selection.

image.png.e384c58f25070df60530d0b92c2b88b4.png

image.png.7a5552cf425b143254aa0a440567a73b.png

yocker
Posted (edited)
2 hours ago, Neminem said:

Also seeing some weird resolution display. 

Chosen icon is 720p, but the movie is 1080p with aspect ratio 40:17 = 2.35:1.

Width :    1920 pixels
Height :    816 pixels

Guess the aspect ratio is messing with the icon selection.

image.png.e384c58f25070df60530d0b92c2b88b4.png

image.png.7a5552cf425b143254aa0a440567a73b.png

Yes, it's closer to 720p by it's calculation.
Will fix it as soon as i'm done with what i'm working on.

Edit:
F. it, it's such an easy edit to do and with it you guys can test the new caching as well.
So i just edited what width it uses in the detection, see if this reduces the "false" detections, if not i will have to write something else as i never thought of wide screen resolutions when i originally made it.

I removed the "Ignore Cache" and timer option and added better cache.
When having TV show overlays on the TV shows will still be scanned every time you enter the library, nothing i can do about that as it's an Emby limitation, but it will not redraw the overlays each time with this cache and the overlays will actually update instantly when changed have been made to the episodes, just like Emby normally does.

If for some reason people don't want that scanning to happen there is still "lite-mode", it returns everything back to how things normally work but only ever checks the first episode.
Of cause there is also the option of not turning on TV show posters. ;)

I have tested it a lot my self so it should be crash safe.
 

EmbyIcons.dll

Edited by yocker
Neminem
Posted

Nice 👍thank you.

That works with this 1.

image.png.3a2b0426ae4923a761492e153b236ac2.png

image.png.229d975984ceb0c51edb95e12184ab6f.png

These still does in at 720p.

image.png.b1748722cbae771c9caaeda425e8da9d.png

image.png.d0db26536f026dca94d015e1b9d266db.png

image.png.464e99407bc45893d05498742585572d.png

image.png.ff84bd0285a4383e368273e7281c0911.png

It could be done as a select / type in what height users want.

That way you don't have to worry about it, and users need to lower there max height.

4K = user defined.

1080p = user defined.

720p = user defined.

etc. 

Not sure how easy that would be 🤣😂, not a dev my self.

Neminem
Posted

I love the new way of selecting library's 

image.png.d817e36a217d90cdeb539ffcade5450d.png

But I guess the following library types would not work.

"Audio books" , "Music" and "Collections"

I have enabled them all to see what happens 😂🤣

And will let it sit and do its job, and look again in a couple of hours.

yocker
Posted
21 minutes ago, Neminem said:

These still does in at 720p.

image.png.b1748722cbae771c9caaeda425e8da9d.png

 

image.png.464e99407bc45893d05498742585572d.png

I will set it a little lower, i set the limit at x800 so you are just at the limit with those.
I'm no resolution expert so don't know what wide screens videos use so a little guess work for me this, it's very easy to edit though. :)

 

  • Like 1
yocker
Posted
13 minutes ago, Neminem said:

I love the new way of selecting library's 

image.png.d817e36a217d90cdeb539ffcade5450d.png

But I guess the following library types would not work.

"Audio books" , "Music" and "Collections"

I have enabled them all to see what happens 😂🤣

And will let it sit and do its job, and look again in a couple of hours.

The plugin doesn't support Audio book, music or collections.
I will look into having so those don't show up in the future, plus changing it to not just be a vertical list.
low prio right now though, sorry.

Hmmm i just thought of something, maybe i should explain the library buttons a bit better.
Activating them is actually a "ignore this library" button and not a "Enable this library" button. :)

 

Neminem
Posted

I'm no expert either just follow the filters in Emby.

Setting it to 1080p and some of my movies had 720p icon 🤣😂

yocker
Posted (edited)

@Neminem
You can try this version for the resolutions.
I have a friend i will talk with later that will know how to eliminate all "false positives" in the resolutions for sure.

Had some quick copy and paste HTML done to add a readme as well, it's not done yet though but as it's not critical at all to the plugin you can just ignore it. ;)

 

EmbyIcons.dll

Edited by yocker
  • Like 1
Neminem
Posted (edited)
19 minutes ago, yocker said:

Activating them is actually a "ignore this library" button and not a "Enable this library" button.

Hmm are you sure, I have just enabled my cartoons and music video library and get icons.

image.png.f59952c56151ec7d4912344011d26283.png

image.png.104c7177cbbf03c6e0ae1d316ccaf756.png

image.thumb.png.bbdb36433649c48a3c85c3bc2cc9497b.png

 

Edited by Neminem
  • Like 1
yocker
Posted (edited)
2 minutes ago, Neminem said:

Hmm are you sure, I have just enabled my cartoons and music video library and get icons.

image.png.f59952c56151ec7d4912344011d26283.png

image.png.104c7177cbbf03c6e0ae1d316ccaf756.png

image.thumb.png.bbdb36433649c48a3c85c3bc2cc9497b.png

 

image.png

Gaaah.. Yes, i'm behind in my thinking, i actually did fix that.

It's been a busy month. 🤪

Edited by yocker
  • Haha 1
Neminem
Posted

😂🤣😂🤣 Just found an extreme out lier.

Are you sure that Emby uses height to determine this.

And not Width ?

image.png.1cad767c883993f1c00e7d6dffe9959a.png

image.thumb.png.69932c917c65f255e49b3aad8e5243e2.png

I think there is a issue with Emby 🤔

image.thumb.png.ae85a5c3a80d7e4565884a522757eda1.png

Then I see 

image.thumb.png.8056af9df5824a0074a979dfd5340fce.png

image.png.1960a2c0bd421e5ddb08b526169de8fe.png

yocker
Posted
3 minutes ago, Neminem said:

😂🤣😂🤣 Just found an extreme out lier.

Are you sure that Emby uses height to determine this.

And not Width ?

image.png.1cad767c883993f1c00e7d6dffe9959a.png

image.thumb.png.69932c917c65f255e49b3aad8e5243e2.png

I think there is a issue with Emby 🤔

image.thumb.png.ae85a5c3a80d7e4565884a522757eda1.png

Then I see 

image.thumb.png.8056af9df5824a0074a979dfd5340fce.png

image.png.1960a2c0bd421e5ddb08b526169de8fe.png

The plugin reads the height of the videos it self and doesn't really rely on emby for that so still a problem with my definitions of resolution

Neminem
Posted

But how can you fix that if height of 1080p movie is 696 and 720p is up to height 720 🤔

yocker
Posted (edited)
15 minutes ago, Neminem said:

But how can you fix that if height of 1080p movie is 696 and 720p is up to height 720 🤔

That why I need my friend to look at it :)

 But I figure a mix of of equal or greater than on both height and width

I could also just hook into emby, what I'm doing ATM is basically just what I put into the plugin when I first made it

Edited by yocker
  • Like 1
Neminem
Posted

Thanks for looking into it 👍

  • Like 1
yocker
Posted (edited)
1 hour ago, Neminem said:

Thanks for looking into it 👍

            if (width >= 3200 || height >= 1500) return "4k";
            if (width >= 1800 || height >= 780) return "1080p";
            if (width >= 1200 || height >= 650) return "720p";
            if (height >= 540) return "576p";
            if (height >= 400) return "480p";

Would this work for you?
Example, anything above 1800 or 780 will be seen as 1080p, anything above 3200 or 1500 will be seen as 4K.
This *should* account for most resolutions.

Your "Sinners" movie will be seen as 1080p,

Edited by yocker
  • Like 1
Neminem
Posted

Lets give it a shoot 😁

Poke me and I will test 👍

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...