yocker 1262 Posted Tuesday at 09:48 AM Author Posted Tuesday at 09:48 AM (edited) 9 hours ago, liuhangbj said: The same habbit. I really want a SDR icon, when there are no DV/HDR10/HDR format in the video files. By the way, are you planning to working on reorder the filename rules by priority? Even can display on the different position of the poster? I want the source icons like bluray/WEB-DL/REMUX can be separated with edition icons like CC/MoC/DC/TC. Adding a SDR indicator just to show something is not HDR, which there are indicators for any way, just seems unnecessary and like more clutter. So i don't personally see a use for it and will most likely not add it. Individual filename rule placements on the other hand is an excellent idea and i will look into adding it. Edited Tuesday at 09:52 AM by yocker
eMoOak 8 Posted Tuesday at 06:43 PM Posted Tuesday at 06:43 PM This is what I do with an overlay on posters: It could be an idea, because having tons of icons on posters makes them look like christmas trees
eMoOak 8 Posted Tuesday at 06:47 PM Posted Tuesday at 06:47 PM By the way, it would be a nice feature to add a banner like that with custom tags!
chander421 16 Posted Tuesday at 07:40 PM Posted Tuesday at 07:40 PM +1 for banners! with "coming soon" banners, release in <x> days, released <x> days ago, etc. 1
yocker 1262 Posted Tuesday at 10:25 PM Author Posted Tuesday at 10:25 PM 2 hours ago, chander421 said: +1 for banners! with "coming soon" banners, release in <x> days, released <x> days ago, etc. The plugin has no way of knowing when something is coming out, it's a purely reactive plugin (or at least was meant to be ) I personally don't see the need for them either as the plugin originally was just made to show icons for subtitle languages so my parents could see what videos had danish subtitles as they don't speak english. More icons were added to see what videos had Dolby Vision, surround and so on as i found them useful for quickly scanning with the mark 1 eyeball what videos had what. It was never meant to pretty up Emby. With that said, i will look into it but it will be low priority for now. Don't get me wrong, i love that you guys like the plugin and all the suggestions you are coming with but the plugin is getting a little out of hand with features. It's gotten so bloated that some people see the settings and just instantly give up. You are welcome to make the features your self if you can/want, the plugin code is free for all use.
yocker 1262 Posted Tuesday at 10:32 PM Author Posted Tuesday at 10:32 PM 3 hours ago, eMoOak said: This is what I do with an overlay on posters: It could be an idea, because having tons of icons on posters makes them look like christmas trees I also also limit the amount of icons shown. Upper left corner: HDR and Resolution. Lower right corner Subtitle languages. We are all different so i can understand if people want other icons. As for the green bar banners, as said in the post above i will look into it but it will be low priority. It would require scaling the posters in ways that doesn't make the characters in the posters look fat.
eMoOak 8 Posted Tuesday at 10:48 PM Posted Tuesday at 10:48 PM (edited) It's just an overlay applied on posters like icons, without resizing (so no cropping and nobody's looking fat). I do it manually when a TV show is "on air" or when a new season is available.This could be based on tags I think. No problem for the low priority. Your plugin is already much appreciated, it was just an idea Edited Tuesday at 10:49 PM by eMoOak 1
WJCuffe 14 Posted yesterday at 12:27 AM Posted yesterday at 12:27 AM Quick question: Does EmbyIcons filter out image files when it scans a movie/series directory? I ask because I've gone through the long list of needed Frame Rate and Aspect Ratio icons as reported by the Icon Manager troubleshooter. I've clicked on each entry individually and made icons for all the found files. However that leaves the majority of reported "missing icons" (647 and 313 needed respectively) returning "No items found using this icon". Then I noticed that the last frame rate icon on the list of needed was "fps.90000.png". This is the frame rate that Emby displays for embedded images: This seems to hint that embedded images and/or images stored in the same directory as the video file (generated thumbnails, backgrounds, logos, etc) are triggering the plugin -- at least the Icon Manager part. It might explain the long list of slightly different aspect ratios, as logos especially would be different sizes.
yocker 1262 Posted 15 hours ago Author Posted 15 hours ago 9 hours ago, WJCuffe said: Quick question: Does EmbyIcons filter out image files when it scans a movie/series directory? I ask because I've gone through the long list of needed Frame Rate and Aspect Ratio icons as reported by the Icon Manager troubleshooter. I've clicked on each entry individually and made icons for all the found files. However that leaves the majority of reported "missing icons" (647 and 313 needed respectively) returning "No items found using this icon". Then I noticed that the last frame rate icon on the list of needed was "fps.90000.png". This is the frame rate that Emby displays for embedded images: This seems to hint that embedded images and/or images stored in the same directory as the video file (generated thumbnails, backgrounds, logos, etc) are triggering the plugin -- at least the Icon Manager part. It might explain the long list of slightly different aspect ratios, as logos especially would be different sizes. The plugin works by getting it's info from Emby. So if Emby says a frame rate of 90.0000 then that's what the plugin will want. I can look into adding a filter to catch problems like these.
liuhangbj 2 Posted 10 hours ago Posted 10 hours ago 17 hours ago, yocker said: The plugin has no way of knowing when something is coming out, it's a purely reactive plugin (or at least was meant to be ) 插件无法知道什么时候会发布,它是一个纯反应式插件(至少本来就是这样 设计的)。 I personally don't see the need for them either as the plugin originally was just made to show icons for subtitle languages so my parents could see what videos had danish subtitles as they don't speak english. More icons were added to see what videos had Dolby Vision, surround and so on as i found them useful for quickly scanning with the mark 1 eyeball what videos had what. It was never meant to pretty up Emby. 我个人也觉得没必要,因为插件最初只是为了显示字幕语言的图标,让我父母能看到哪些视频有丹麦语字幕,因为他们不会说英语。我发现用 Mark 1 快速扫描哪些视频有 Dolby Vision、环绕声等,增加了更多图标,方便快速扫描哪些视频有 Dolby Vision、环绕声等。这从来不是为了美化恩比。 With that said, i will look into it but it will be low priority for now. 话虽如此,我会去了解一下,但目前优先级不高。 Don't get me wrong, i love that you guys like the plugin and all the suggestions you are coming with but the plugin is getting a little out of hand with features. 别误会,我很喜欢你们喜欢这个插件和大家提出的所有建议,但插件的功能有点过头了。 It's gotten so bloated that some people see the settings and just instantly give up. 它已经膨胀到有些人看到设置后立刻放弃。 You are welcome to make the features your self if you can/want, the plugin code is free for all use. 如果你愿意,也可以自己做这些功能,插件代码是免费的。 Agree about your opinion. just focus on the overlays of posters, and just work on customize positions and priority. It's good enough and also light enough. I like this very much
liuhangbj 2 Posted 10 hours ago Posted 10 hours ago 5 hours ago, yocker said: The plugin works by getting it's info from Emby. So if Emby says a frame rate of 90.0000 then that's what the plugin will want. 插件的工作原理是从 Emby 获取信息。所以如果 Emby 说帧率是 90,0000,那插件就会要求这个帧率。 I can look into adding a filter to catch problems like these. 我可以考虑加个过滤器来捕捉这类问题。 the resolution icons still have problem, sometimes think the 1080p as 720p,or can't display 4K icon for 4K movie I think the problem is: for example the resoution is 1440*1080 the plugin only take the width pixels = 1440, less than 1920, so it think it as 720p. But if the heighth is 1080, ut should be 1080p the 4k is the same, if the heighth is 2160, it should be 4k
liuhangbj 2 Posted 10 hours ago Posted 10 hours ago 5 hours ago, yocker said: The plugin works by getting it's info from Emby. So if Emby says a frame rate of 90.0000 then that's what the plugin will want. 插件的工作原理是从 Emby 获取信息。所以如果 Emby 说帧率是 90,0000,那插件就会要求这个帧率。 I can look into adding a filter to catch problems like these. 我可以考虑加个过滤器来捕捉这类问题。 and also, can you add DTS-HD MA and DTS-X as different as DTS, and displayed a different icon?
TMCsw 250 Posted 3 hours ago Posted 3 hours ago 7 hours ago, liuhangbj said: the plugin only take the width pixels = 1440, less than 1920, so it think it as 720p. But if the heighth is 1080, ut should be 1080p Incorrect, @yockerhas it correct, Emby has it wrong! Many sources confirm this. Here is one: https://www.lifewire.com/what-is-1080p-resolution-8757574
liuhangbj 2 Posted 1 hour ago Posted 1 hour ago 1 hour ago, TMCsw said: Incorrect, @yockerhas it correct, Emby has it wrong! Many sources confirm this. Here is one: https://www.lifewire.com/what-is-1080p-resolution-8757574 You decide it too simple, the fact is maybe emby is right. The reason make the width less than 1920 is: The blueray disk's resolution is always 1920×1080, but there is a wide black side at the top and bottom(21:9), or at the left and right(3:2/4:3). So in ISO/BDMV/REMUX, 1080p must be 1920×1080. But we always download encoded files, we call it BDrip. In the encoding process, the application program will cut the wide black side automatically, which made the width less than 1920 or made the height less than 1080. But actually they are the same resolution. The advintage of BDrip is you can get bigger display area even full screen without black side area on widescreen display. So I think emby is right, @TMCswmentioned the definition is right, but is not suitable with the real situation
yocker 1262 Posted 1 hour ago Author Posted 1 hour ago (edited) 1 hour ago, TMCsw said: Incorrect, @yockerhas it correct, Emby has it wrong! Many sources confirm this. Here is one: https://www.lifewire.com/what-is-1080p-resolution-8757574 Hes 1420 x 1080 video shouldn't be shown as 720p which was caused by trying to combine different resolutions so that for example 4:3, 16:9 and so on would always show a "correct" resolution. So you are both correct but the implementation wrong. I have changed it to just use what Emby shows now and in missing that a normal height range will be used, 4K = 2160, 1440p = 1440, 1080p = 1080 and so on and sticking to the closest match. This should be more reliable but might cause some problems with none standard resolutions. Edited 1 hour ago by yocker
yocker 1262 Posted 1 hour ago Author Posted 1 hour ago The new version is up on yocksers/EmbyIcons github. Added: Icon overlays for if series has ended or still running. Filename rules now support movies, TV shows, seasons and/or episodes. The resolution fix is also there but didn't feel it was worth mentioning. 1
liuhangbj 2 Posted 1 hour ago Posted 1 hour ago 14 minutes ago, yocker said: Hes 1420 x 1080 video shouldn't be shown as 720p which was caused by trying to combine different resolutions so that for example 4:3, 16:9 and so on would always show a "correct" resolution. 他的 1420 x 1080 视频不应该显示为 720p,这是因为试图组合不同分辨率,比如 4:3、16:9 等分辨率总是显示“正确”的。 So you are both correct but the implementation wrong. 所以你们俩都对,但实现上有误。 I have changed it to just use what Emby shows now and in missing that a normal height range will be used, 4K = 2160, 1440p = 1440, 1080p = 1080 and so on and sticking to the closest match. 我改成只用 Emby 显示的,并且缺少一个正常的高度范围,比如 4K = 2160,1440p = 1440,1080p = 1080,依此类推,并且坚持使用最接近的匹配。 This should be more reliable but might cause some problems with none standard resolutions. 这样应该更可靠,但可能会在非标准分辨率下出现一些问题。 thank you so much. I really like your plugin. I think I don't need KOMETA now. I think you should make it online in plugin store, so I can buy it. It's really powerful! I have a small thought, the video files always have many audio/subtitle tracks with different language, I don't want to reeocode them after download. The plugin always show the first 5 audio/subtitle tracks' language icons, but they are not what I want to see on the poster. Can it only show the selected language if it is icluded in the movie file, like zh/en//de/dm e.g.? You can add a filter by country in language option.
GrimReaper 4767 Posted 50 minutes ago Posted 50 minutes ago 23 minutes ago, yocker said: Added: Icon overlays for if series has ended or still running. Thanks for this, working good - but it appears that Status logic is tied to Subtitle Language logic, i.e. this scenario: does not produce an icon (as example poster does); only if Subtitle Language Icons enabled, it shows.
TMCsw 250 Posted 48 minutes ago Posted 48 minutes ago 29 minutes ago, yocker said: Hes 1420 x 1080 video shouldn't be shown as 720p Guess I really should have said it's neither 720p nor 1080p (like a few others), it really should just be called "HD", with an aspect ratio? 1
yocker 1262 Posted 48 minutes ago Author Posted 48 minutes ago 7 minutes ago, liuhangbj said: thank you so much. I really like your plugin. I think I don't need KOMETA now. I think you should make it online in plugin store, so I can buy it. It's really powerful! I have a small thought, the video files always have many audio/subtitle tracks with different language, I don't want to reeocode them after download. The plugin always show the first 5 audio/subtitle tracks' language icons, but they are not what I want to see on the poster. Can it only show the selected language if it is icluded in the movie file, like zh/en//de/dm e.g.? You can add a filter by country in language option. Thank you for the kind words. I don't really want this in the store as if i some day abandon the plugin (sickness or what ever) it would look bad on the Emby team to have it in the store. The fact that it's free also eases things a little as i don't have to be scared of cheating people out of their money some how. I have been toying with the ideer of making a white list for languages and will add it at some point. For now a solution would be to set the plugin to only use custom icons and only add the languages you want to use, you can find the icons the plugin uses in the github under "Embededicons" It will require you to change the names of the icons from eg. ac.truehd.png to ac_truehd.png though, so bit of work.
yocker 1262 Posted 47 minutes ago Author Posted 47 minutes ago 3 minutes ago, GrimReaper said: Thanks for this, working good - but it appears that Status logic is tied to Subtitle Language logic, i.e. this scenario: does not produce an icon (as example poster does); only if Subtitle Language Icons enabled, it shows. Yeah, i had no idea where to put it so put it there for now.
GrimReaper 4767 Posted 44 minutes ago Posted 44 minutes ago 1 minute ago, yocker said: Yeah, i had no idea where to put it so put it there for now. Not sure if I explained the issue properly: there's no Status icon if Subtitle Languages are not enabled - that should be decoupled. Setting placement is minor, I don't mind it there as long it exists.
yocker 1262 Posted 42 minutes ago Author Posted 42 minutes ago 2 minutes ago, TMCsw said: Guess I really should have said it's neither 720p nor 1080p (like a few others), it really should just be called "HD", with an aspect ratio? You were as said not really wrong.. Resolutions do my head in tbh., so many different kinds and even TV manufactures cheating with them, for example calling 3840 x 1080 for 4K, I got scammed by Sony once with a TV like that, the X800H i think it was called, it was a big scandal at the time but no one ever got their money back from Sony. Sony, if you are reading this... F*** YOU! I WANT MY MONEY BACK STILL!
yocker 1262 Posted 40 minutes ago Author Posted 40 minutes ago 1 minute ago, GrimReaper said: Not sure if I explained the issue properly: there's no Status icon if Subtitle Languages are not enabled - that should be decoupled. Setting placement is minor, I don't mind it there as long it exists. Strange..
GrimReaper 4767 Posted 36 minutes ago Posted 36 minutes ago 2 minutes ago, yocker said: Strange.. Yes, that works. This doesn't: That is what cannot be achieved/does not produce Status icon: no Subtitle Language, no Original Language, yes Status. 14 minutes ago, GrimReaper said: Thanks for this, working good - but it appears that Status logic is tied to Subtitle Language logic, i.e. this scenario: does not produce an icon (as example poster does); only if Subtitle Language Icons enabled, it shows.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now