xnappo 1611 Posted January 13 Posted January 13 (edited) 15 minutes ago, Neminem said: Do you have any age restriction on the user you are using? I was going to get annoyed, because I already said I did not, but that was it - with a caveat! It was set like this: Note that unrecognized was set to NOT block. This item is setting a rating of '16' which I suppose wasn't recognized. I am guessing that in my previous cases, why it fixed it to turn off TVDB then back on is the rating was set to a recognized type by another service that did not get overriden when I turned it back on. Setting the rating to 'BLANK' fixed it. Please check the code on the 'unrecognized' option guys - but *THANK YOU* for the support in finding the problem. Edited January 13 by xnappo 1
Neminem 1518 Posted January 13 Posted January 13 (edited) Have a look at this plugin That will help you with those classification that does not fit anywhere. Edited January 13 by Neminem
xnappo 1611 Posted January 13 Posted January 13 Co-Pilot says: ## Summary I've identified and fixed the parental ratings bug in the Emby media server codebase. ### Root Cause The bug was in SqliteItemRepository.cs at line 4466. When a user had: - **MaxParentalRating** set to allow high-rated content (e.g., AO/RP/UR/X/XXX) - **Block items with no or unrecognized rating information** set to OFF (empty `BlockUnratedItems` list) A TV show with an unrecognized rating like "16" would still be blocked. The issue was that items with unrecognized ratings have an `InheritedParentalRatingValue` of 0 (since the rating "16" doesn't exist in any ratings dictionary). The original SQL WHERE clause was: ```sql InheritedParentalRatingValue<=@MaxParentalRating ``` This clause would evaluate to `0 <= MaxValue` which should be TRUE and allow the item. However, the problem is that unrated/unrecognized items (with value 0) were being subjected to the `MaxParentalRating` restriction, when they should only be controlled by the `BlockUnratedItems` setting. ### The Fix Changed the WHERE clause from: ```sql InheritedParentalRatingValue<=@MaxParentalRating ``` To: ```sql (InheritedParentalRatingValue<=@MaxParentalRating or InheritedParentalRatingValue=0) ``` This ensures that: 1. Items with recognized ratings are checked against the `MaxParentalRating` threshold 2. Items with unrecognized ratings (`InheritedParentalRatingValue=0`) are **always allowed** when evaluating `MaxParentalRating`, and are only blocked if their type is in the `BlockUnratedItems` list (which is handled by separate logic further down) With this fix, a TV show with an unrecognized rating of "16" will now be visible when `BlockUnratedItems` for TV shows is set to OFF, regardless of the `MaxParentalRating` setting. Made changes. 1
Neminem 1518 Posted January 13 Posted January 13 8 minutes ago, xnappo said: The issue was that items with unrecognized ratings have an `InheritedParentalRatingValue` of 0 (since the rating "16" doesn't exist in any ratings dictionary). Then your beef is with metadata provider
Neminem 1518 Posted January 13 Posted January 13 But then, again you can edit the source of you issue here. Login - TheTVDB.com Or here Login — The Movie Database (TMDB) If you want to, now that you know the issue, and help the whole community
xnappo 1611 Posted January 13 Posted January 13 6 minutes ago, Neminem said: But then, again you can edit the source of you issue here. Login - TheTVDB.com Or here Login — The Movie Database (TMDB) If you want to, now that you know the issue, and help the whole community No - the problem is that the rating wasn't recognized, and Emby is set to allow unrecognized ratings to display - and the logic is wrong., 1
Neminem 1518 Posted January 13 Posted January 13 Well I'm happy to have helped you I'm just another helpful user, trying to help you with what us users have to work with I will reframe from helping you again.
xnappo 1611 Posted January 13 Posted January 13 Just now, Neminem said: Well I'm happy to have helped you I'm just another helpful user, trying to help you with what us users have to work with I will reframe from helping you again. I appreciate the help, you just didn't understand that it is a bug, not user error. No problem there, but it is a bug.
Luke 42077 Posted January 14 Posted January 14 10 hours ago, xnappo said: No - the problem is that the rating wasn't recognized, and Emby is set to allow unrecognized ratings to display - and the logic is wrong., A numeric value is considered recognized by being parsed to an integer.
xnappo 1611 Posted January 14 Posted January 14 9 hours ago, Luke said: A numeric value is considered recognized by being parsed to an integer. Surely though if one has it set the way I did - up to XXX - the max - and unrecognized ratings are set to display, the expected behavior is it should be the same as having 'blank' selected.
Luke 42077 Posted January 14 Posted January 14 6 hours ago, xnappo said: Surely though if one has it set the way I did - up to XXX - the max - and unrecognized ratings are set to display, the expected behavior is it should be the same as having 'blank' selected. What makes you so sure about it?
xnappo 1611 Posted January 14 Posted January 14 (edited) 17 hours ago, Luke said: What makes you so sure about it? Because it is the highest rating? Because the ratings are a fixed list and not an open input? Because '16' isn't listed as a known rating? Because no matter what you select in the ratings, '16' will never show, therefore it IS an unknown rating. Because Jellyfin had the same bug and fixed it? Known ratings exhibit A: Exhibit B: 16 is not in these lists, therefore it is an unknown rating. The code taking it as a known rating is a bug. Edited January 15 by xnappo
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now