Teredactle 37 Posted November 22, 2024 Author Posted November 22, 2024 1 hour ago, TeamB said: @Teredactle The Playback reporting plugin is an open source 3rd party plugin for Emby, it is not included in Emby by default, you can install it using the Emby plugin catalogue though. Normally for the main version of the plugin i.e. the one I complied and uploaded to the catalogue, users can just install from the catalogue. However if you want to create a custom version the plugin needs to be compiled from source into a DLL that needs to be copied to the plugins directory of the Emby install. To compile the plugin into a DLL you will need to use a compiler. I recommend Visual Studio Community Edition https://visualstudio.microsoft.com/vs/community/ To edit and compile the DLL you will need to check out the source code from github, install git first https://git-scm.com/downloads Then check out the code using git clone https://github.com/faush01/playback_reporting.git Open the SLN file in visual studio and build the source. Make your changes, build the source and then copy the DLL to your Emby plugins directory. It looks like there is a closed pull request for basically the same sort of thing that I'm asking, but ford Audio, which seems to have been accepted in the main release (not sure that's the right word). https://github.com/faush01/playback_reporting/pull/12 So can I not do the same for video?
Teredactle 37 Posted November 22, 2024 Author Posted November 22, 2024 33 minutes ago, Luke said: The item type for home Videos is Video, but I wouldn’t query just on that because you’ll get other things back. What I would do instead is filler your results on library. I understand, I plan on filtering by library, but it would be great also to cover all videos so that other libraries like Music Videos and Mixed Contents (which I assume would also be video?) could be included in the new media report.
Luke 42077 Posted November 23, 2024 Posted November 23, 2024 23 hours ago, Teredactle said: I understand, I plan on filtering by library, but it would be great also to cover all videos so that other libraries like Music Videos and Mixed Contents (which I assume would also be video?) could be included in the new media report. There isn't really a way to just do that on item type alone because you may get additional things back that you don't want. More filters are going to be needed, and library is a good choice.
Teredactle 37 Posted December 4, 2024 Author Posted December 4, 2024 Could someone please help me with a Pull Request to add VIDEO to the playback_reporting addin? It looks like it would be very similar to this pull request for Audio (https://github.com/faush01/playback_reporting/pull/12); I'm not a developer and find Github very confusing. Tried to create a Pull Request but I don't know how to suggest/request the changes to the code; do I just paste the below?? I guess there are 2 changes: 1) query.IncludeItemTypes = new string[] {"Movie", "Episode", "Audio"}; changed to this line to include Video category query.IncludeItemTypes = new string[] {"Movie", "Episode", "Audio", "Video"}; 2) Not sure where and what I should put in this section (below): else if (typeof(Movie).Equals(item.GetType())) { view_message_data += " - (" + type + ") " + name + " (" + item.ProductionYear + ")\r\n"; } else if (typeof(Audio).Equals(item.GetType())) { Audio audio = item as Audio; string album = audio.Album; string artist = audio.Artists.Length > 0 ? audio.Artists[0] : "Unknown Artist"; view_message_data += " - (" + type + ") " + artist + " - " + name + " - " + album + " (" + item.ProductionYear + ")\r\n"; } Is this the right part to add syntax wise? Where does it need to go above? else if (typeof(Video).Equals(item.GetType())) { view_message_data += " - (" + type + ") " + name + "\r\n"; It seems like a simple change request, I don't understand how to create it. TY
Teredactle 37 Posted December 12, 2024 Author Posted December 12, 2024 On 11/23/2024 at 4:58 PM, Luke said: There isn't really a way to just do that on item type alone because you may get additional things back that you don't want. More filters are going to be needed, and library is a good choice. Yes this is the plan, filter by library so it would only report on new content (Video) from the home video/photo libraries. The Video format would handle both type of media in this home library? I.E. If this was added, would it report both photos and videos that have been added to the home p/v libraries, or just videos? Would one also need to add "Photo" to the reporting addon too? TY
Luke 42077 Posted December 12, 2024 Posted December 12, 2024 38 minutes ago, Teredactle said: Yes this is the plan, filter by library so it would only report on new content (Video) from the home video/photo libraries. The Video format would handle both type of media in this home library? I.E. If this was added, would it report both photos and videos that have been added to the home p/v libraries, or just videos? Would one also need to add "Photo" to the reporting addon too? TY When you filter on library, yes that will catch both videos and photos. If you're talking about if and when something gets added to the playback reporting plugin, that's all up to TeamB and how many filters he wants to add. 1
Teredactle 37 Posted March 18, 2025 Author Posted March 18, 2025 On 10/23/2024 at 10:04 AM, Luke said: Hi, yes it’s a good idea. Thanks for the feedback. Hi Luke, any chance this could get traction? TY
Luke 42077 Posted March 31, 2025 Posted March 31, 2025 On 3/18/2025 at 2:04 AM, Teredactle said: Hi Luke, any chance this could get traction? TY I don't have an ETA but yes it's something we can do.
Teredactle 37 Posted April 2, 2025 Author Posted April 2, 2025 On 10/24/2024 at 4:25 PM, TeamB said: 1. it only includes movies, tv show episodes and music https://github.com/faush01/playback_reporting/blob/9bfc4680983e99eed964bc6f4bca58cc8c829b72/playback_reporting/Tasks/TaskNotifictionMediaReport.cs#L123 2. it should include movies and tv show episodes that were added since the last time it was run https://github.com/faush01/playback_reporting/blob/9bfc4680983e99eed964bc6f4bca58cc8c829b72/playback_reporting/Tasks/TaskNotifictionMediaReport.cs#L144 you are seeing the log lines because they are output before the time cutoff check Hi @TeamBI've added a pull request and I'm hoping I did it correctly. I hope that it's accepted and rolled into an update of this addon, I hope others will also benefit from this request. Thank you
Teredactle 37 Posted April 3, 2025 Author Posted April 3, 2025 @Lukeor @TeamBor anyone else that knows github well (I guess any developer using it) What happens when pull requests are accepted and merged? ie "merged #17 into develop" Does it mean the requested code change has been accepted? In this particular case then, what does it mean as to timing when a new release (with these changes) will be made available for Emby as a plugin update? TY
Luke 42077 Posted April 3, 2025 Posted April 3, 2025 If he merged your changes then I assume they’ll be part of the next plugin update.
Teredactle 37 Posted April 3, 2025 Author Posted April 3, 2025 YESSSSSSS!!!! I hope there is an update soon!
TeamB 2438 Posted April 3, 2025 Posted April 3, 2025 sorry i forgot to update you here, yes i merged, and yes it will be in the next release probably over the weekend when i get a chance to test.
Teredactle 37 Posted April 10, 2025 Author Posted April 10, 2025 Nice, thanks!! looking forward to this! From the Emby logs I see I'm running Playback Reporting v2.1.0.6, how do I know (other than checking there) when an upgrade is available/done? I checked github but did not find any version log anywhere? Is there such a thing that has any release notes? Cheers
Teredactle 37 Posted April 13, 2025 Author Posted April 13, 2025 The other day, the New Media Report ran, and showed all the Audiobooks added in the Audiobooks library, a library that is not selected in the notifications for this reporting. @Lukeor @TeamBany idea why that would happen? Ty
Luke 42077 Posted April 13, 2025 Posted April 13, 2025 3 hours ago, Teredactle said: The other day, the New Media Report ran, and showed all the Audiobooks added in the Audiobooks library, a library that is not selected in the notifications for this reporting. @Lukeor @TeamBany idea why that would happen? Ty HI there, can you please provide a specific example? How to Report a Problem Thanks !
Mac18 7 Posted May 13, 2025 Posted May 13, 2025 Discord newly added media same as Radarr and Sonarr, sample below
Teredactle 37 Posted June 3, 2025 Author Posted June 3, 2025 On 4/3/2025 at 4:23 PM, TeamB said: sorry i forgot to update you here, yes i merged, and yes it will be in the next release probably over the weekend when i get a chance to test. Hi, I was wondering if a new release will be coming, anxious to test this added feature!! Cheers and thank you!
TeamB 2438 Posted June 3, 2025 Posted June 3, 2025 10 hours ago, Teredactle said: Hi, I was wondering if a new release will be coming, anxious to test this added feature!! Cheers and thank you! 2.1.0.7 released
Teredactle 37 Posted June 4, 2025 Author Posted June 4, 2025 Wow, ok this plugin seems to no longer work for me at all. I've added media to test and manually ran scan library and then check for new media. Also, new media added on home page stopped working properly as well...media not showing on there
Teredactle 37 Posted June 6, 2025 Author Posted June 6, 2025 On 6/4/2025 at 3:51 PM, Teredactle said: Wow, ok this plugin seems to no longer work for me at all. I've added media to test and manually ran scan library and then check for new media. Also, new media added on home page stopped working properly as well...media not showing on there Ok nevermind, all is working fine.. .not sure why it wasn't working yesterday, there was an almost 24hr delay on getting the notifications. And I can't find a way to delete the post... Thank you @TeamBthis is working as I anticipated and I can now get notifications to my family again @LukeYou mentioned the following: "The item type for home Videos is Video, but I wouldn’t query just on that because you’ll get other things back. What I would do instead is filler your results on library. " when I was asking about adding more lines to this plugin (pull request). Should I assume based on the above, that only videos from home library will be listed, or photos too? If the home video library has checked "photos" in the settings, will it also detect those and list them in new media? Thanks!
Luke 42077 Posted June 8, 2025 Posted June 8, 2025 On 6/6/2025 at 1:08 PM, Teredactle said: @LukeYou mentioned the following: "The item type for home Videos is Video, but I wouldn’t query just on that because you’ll get other things back. What I would do instead is filler your results on library. " when I was asking about adding more lines to this plugin (pull request). Should I assume based on the above, that only videos from home library will be listed, or photos too? If the home video library has checked "photos" in the settings, will it also detect those and list them in new media? Thanks! Are you asking about the plugin or core feature?
Teredactle 37 Posted June 9, 2025 Author Posted June 9, 2025 I'm asking about the plugin, how it sees media in home video libraries. I asked about this before and you responded with the part i quoted. Here it is in context, maybe i misunderstood
Luke 42077 Posted June 9, 2025 Posted June 9, 2025 2 hours ago, Teredactle said: I'm asking about the plugin, how it sees media in home video libraries. I asked about this before and you responded with the part i quoted. Here it is in context, maybe i misunderstood Hi, sorry I don't really know how to answer that. I think we need input from @TeamBas he is the plugin developer, and then if he needs help with a core function then that's where I come in. 1
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now