Beannsss 10 Posted September 5, 2024 Posted September 5, 2024 Hello Emby Team, I recently developed this plugin as a subtitle provider for jimaku.cc, which is for Japanese subtitles. I have a few external tools available for people to help learn Japanese through Japanese Media through Emby (i.e. AsbPlayer), and this would facilitate the downloading of subtitles to help with this. I think I am pretty close to this being ready to publish on the Emby Plugin Repository. There are a few things I need to Iron out before publishing: Actually honor the language code instead of hardcoding "jpn" Prevent it from working if "Japanese" not selected Clean up a few UI related things Fix one call to an external github hosted csv to be on a scheduled task instead getting it and parsing it on every search. (low prio) Prevent Automatic Grabbing in the library settings? Not sure if this is possible? But would like to "release" this later once there is a higher confidence level, and once I communicate with the Jimaku team about it. But I want to get the ball rolling to be able to publish in the future instead of asking people to stick the assembly into the plugin folder. I also have plans in the future to adapt my Anilist Scrobbling Script to be an Emby plugin. Let me know if you have any questions/concerns. Thanks for your hard work as always. bpwhelan/Emby.Jimaku: Emby Plugin to download subtitles from Jimaku.cc (github.com)
Luke 42077 Posted September 11, 2024 Posted September 11, 2024 Hi, the language should be easy as that info is in the search request, so you can just have it return empty data when something other than Japanese is requested. Quote Prevent Automatic Grabbing in the library settings? Hi, this isn't possible. What is the use case for wanting to do this?
Beannsss 10 Posted September 11, 2024 Author Posted September 11, 2024 3 hours ago, Luke said: Hi, the language should be easy as that info is in the search request, so you can just have it return empty data when something other than Japanese is requested. I saw this, I just need to implement it. Thanks 3 hours ago, Luke said: Hi, this isn't possible. What is the use case for wanting to do this? When I wrote that, my idea was just being friendly to their API, unwillingness to implement a rate-limit handler, and confidence level in my plugin. Now it's more on the fact that Jimaku doesn't have any kind of hashing information available, and there are many different uploaders with different timings and everything. Of course, there is never going to be a *perfect* automated system, but I have a feeling that grabbing subtitles automatically from Jimaku would do more harm than good. But I guess the power is in the user either way... And I will need to handle the rate limit either way as well
Luke 42077 Posted September 12, 2024 Posted September 12, 2024 Right so basically when a filter is enabled on the search request that the provider doesn't support, then I would return empty results.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now