embyforkodi (next-gen) 11.X.X support

[quickmic 1703]

58 minutes ago, brainbrain said:

In my library i have one or 2 .iso files. If I open them directly in kodi (via file manager), they open and work, if I open them via library (emby), they say file not found. 

In the log it says 
EMBY.core.common: No mediastreams found for movie: 74014 / (link).iso

is this a known issue?

 

Iso are played nativ via direct file access even in addon mode.

You must configure Kodi (and probably Emby server) accordingly so the native file path are valid -> can be tricky.

 

Edited December 14, 2024 by quickmic

[quickmic 1703]

New BETA version available 11.1.10:

Delta changelog 11.1.9 -> 11.1.10

fix photo nodes

 

Comment:

I'm still holding back the more serious changes, until 11.1.X is tagged as stable. Currently planned for this Friday.

[quickmic 1703]

I tagged 11.1.10 now as stable.

Still holding back next beta as I chase a serious http communication bug. It affects http communication in chunked transfer mode (not very common) and only in very special cases (even less common).

However this bug affects all versions since 9.X or even earlier and will be fixed in next beta.

Special thanks to user @reggifor countless tests and still ongoing.

Edited December 20, 2024 by quickmic

[quickmic 1703]

New BETA version available 11.1.13:

Delta changelog 11.1.10 -> 11.1.13

minor http improvements
fix server reconnect when using proxies
fix dynamic content issue
fix Kodi shutdown issue
fix sync timing issue
faster http communication
fix http chunked transfer encoding
fix song selection via dynamic nodes when same song is assigned to multiple Emby libraries
improve playlists
fix subcontent realtime updates
improve sync locks
fix egde case sync and logging issues
improve http request locks
fix async commands ping
improve progress updates when playback ended or seek
workaround for Kodi bug when seekposition is higher than runtime -> Kodi stalls for couple of seconds unless stop is pressed
increase subtitle download timeout to 30 seconds
fix edge case sync issue, when init sync is in progress, incoming updates might not be processed and results in a sync loop

[brainbrain 1]

Does the addon support credits chapters? Eg you need to push a button to skip credits? If so, in which formats do the credits need to be saved?

[quickmic 1703]

2 hours ago, brainbrain said:

Does the addon support credits chapters? Eg you need to push a button to skip credits? If so, in which formats do the credits need to be saved?

Credit markers is not an Emby default feature, but yes the plugin supports it if you MANUALLY set the credit markers. Did you?

[brainbrain 1]

I did not manually set them. I saw that infuse seems to detect them and asked to skip, so I assumed they were in the database. I just checked and they are not. I can try to make .edl files, would that be a possibility?

[quickmic 1703]

36 minutes ago, brainbrain said:

.edl files, would that be a possibility?

Only in native mode, Emby server does not support edl.

[brainbrain 1]

Ok, clear. Thank you for the quick answers as always. Hopefully this gets implemented by Emby in the future. 

[CrazedWeevil 1]

I currently have the latest BETA version of this installed on Kodi 21 on a Nvidia Shield Pro, and I having trouble with the Emby playlists I've made. They all seem only sort Alphabetically rather than by the Playlist. I've looked at the sorting options available, but there doesn't seem to be one for 'Playlist' only Default, Epsiode, Title, Year, etc. They do change the order of the playlist, but none of them will allow me choose the order I made when I created the playlist.

Is there some trick to getting them working correctly?

[quickmic 1703]

How do you access the playlists?

Also Kodi has a bug when you selected sorting manually. It cannot be undone, but when new loaded it should be correct (unsorted) exactly how Emby server reports the order.

Edited December 23, 2024 by quickmic

[CrazedWeevil 1]

Via the 'Video' option on the left-hand menu. If I select the 'Emby DYNAMIC Playlists' it lists all the playlists that I created in Emby, but the order of files in the playlists are all in the wrong order and I cannot change them to original playlist's order.

However if I select the 'Playlists' option I only see some of the playlists I created in Emby not all the them (they show up as .m3u files as well), but these playlist's files are in the order I set them as in Emby and work. 

I tried using different skins as well (the default one, Emburay (Matrix) & Estuary MOD V2 Omega), but the effect is the same.

[quickmic 1703]

The m3u are the "synced" playlists, but I don't recommend using them as you lose proper metadata. Kodi cannot deal with that in m3u's (even it accesses Kodis's video db (synced) content).

Quote

However if I select the 'Playlists' option I only see some of the playlists

(Dynamic) playlists are splitted by content type. If you have mixed content (video and audio) in one playlist, it will result in 2 playlists accessible by audio helper plugin and video helper plugin. Kodi has also major issues with mixed content.

Accessing the playlists via synced nodes seems to be broken and I probably remove them in next version.

I need to review it again, but the concept is as described. m3u's are available and playlists via dynamic nodes.

I'll also check the sorting of dynamic nodes playlist again...

Edited December 23, 2024 by quickmic

[quickmic 1703]

I found the playlist sorting issue, will be fixed in next version.

[seashell 42]

So I haven't looked at my movies tab in a while, so I don't know when this started happening, but I'm now seeing lots of movie extras showing up as movies in the default Kodi movies tab (default estuary skin).  Oddly it's not all extras though.  Seems to be extras from my more recently added movies so I don't know if something changed on the emby side when adding movies with extras.

Emby 4.8.10, Kodi 21.1, E4K 11.1.10 and 11.1.13, Add-on mode.

I've done a factory reset in E4K and it doesn't fix the problem.  I've limited it to just importing the default Emby Movies library.

Looking at the logs it doesn't look like extras are being added the same way as movies.  For the movie I see

-12-25 14:31:31.383 T:1467196   debug <general>: EMBY.core.movies: Process item: A Movie
2024-12-25 14:31:31.386 T:1467196   debug <general>: EMBY.core.common: Use items chapterimages False
2024-12-25 14:31:31.388 T:1467196    info <general>: Skipped 1 duplicate messages..
2024-12-25 14:31:31.388 T:1467196   debug <general>: EMBY.core.movies: ADD [167 / 166 / 141] 560672: A Movie

For an extra from that movie I see

2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.videos: Process item: An Extra
2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.common: Use items chapterimages False
2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.videos: ADD 560673: An Extra

Extras don't get the [x,y,z]

Also the extras do show up as extras if you go to the movie in Kodi.   (Click the movie, a choose version comes up, go to extras tab).

[quickmic 1703]

On 12/25/2024 at 10:58 PM, seashell said:

So I haven't looked at my movies tab in a while, so I don't know when this started happening, but I'm now seeing lots of movie extras showing up as movies in the default Kodi movies tab (default estuary skin).  Oddly it's not all extras though.  Seems to be extras from my more recently added movies so I don't know if something changed on the emby side when adding movies with extras.

Emby 4.8.10, Kodi 21.1, E4K 11.1.10 and 11.1.13, Add-on mode.

I've done a factory reset in E4K and it doesn't fix the problem.  I've limited it to just importing the default Emby Movies library.

Looking at the logs it doesn't look like extras are being added the same way as movies.  For the movie I see

-12-25 14:31:31.383 T:1467196   debug <general>: EMBY.core.movies: Process item: A Movie
2024-12-25 14:31:31.386 T:1467196   debug <general>: EMBY.core.common: Use items chapterimages False
2024-12-25 14:31:31.388 T:1467196    info <general>: Skipped 1 duplicate messages..
2024-12-25 14:31:31.388 T:1467196   debug <general>: EMBY.core.movies: ADD [167 / 166 / 141] 560672: A Movie

For an extra from that movie I see

2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.videos: Process item: An Extra
2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.common: Use items chapterimages False
2024-12-25 14:31:31.026 T:1467196   debug <general>: EMBY.core.videos: ADD 560673: An Extra

Extras don't get the [x,y,z]

Also the extras do show up as extras if you go to the movie in Kodi.   (Click the movie, a choose version comes up, go to extras tab).

I just checked seems to be basically ok on my setup.

You know, extras are handled differently in Kodi 21 and 11.X plugin, right? -> Kodi native integration.

Missing [x,y,z] is fine, as it's now a "videoversion" in Kodi's terms.

Edited December 27, 2024 by quickmic

[seashell 42]

I assume I'm getting Kodi's native implementation though I'm not super familiar with how it was before, but it's not getting to extras that's the problem.  As I said that works.  The problem is extras are being listed as movies themselves in the default Kodi Movies section.  This is with just a vanilla Kodi 21.1 with the default skin.  Install e4k, import Emby default Movies library (so no mixed media or the like) and the result is extras showing up as movies in Kodi.  They also show up as extras under the proper movie but it's the movie list being filled with movie extras that's the problem.

The missing [x,y,z] was just to say they seem to be getting imported differently than the top level movie in case that was helpful.  I guess I'll have to poke at how the extension stores movies and extras to see why extras are being listed as full movies.  In case it's not obvious they do not show up as full movies in Emby.

Edit 1:  Ok, I can clearly see in the Kodi videoversion table lots of extras with itemType 0 which means movie.  It's not all the extras though.  Some do get correctly marked with a value of 1.

Edit 2:  Extras showing up as movies have double entries in the Kodi files table.  The extras as movies all seem to be assigned the lowest values.  (This is from a brand new database.)  So it's like they're getting imported first somehow as movies then later as movie extras.\

Edit 3:  I added a new movie and the problem didn't occur.  So moved all the broken ones out of emby's view and then put the back.  Problem gone.  Probably an emby problem, or more an edge case where E4K and emby don't agree since it didn't break emby itself.  Oddly everytime I said "repair" the database in e4k it would not remove those extra extras and instead add additional copies.  It required a factory reset to remove the extra extras (false movies).

Edited December 28, 2024 by seashell

[quickmic 1703]

7 hours ago, seashell said:

I assume I'm getting Kodi's native implementation though I'm not super familiar with how it was before, but it's not getting to extras that's the problem.  As I said that works.  The problem is extras are being listed as movies themselves in the default Kodi Movies section.  This is with just a vanilla Kodi 21.1 with the default skin.  Install e4k, import Emby default Movies library (so no mixed media or the like) and the result is extras showing up as movies in Kodi.  They also show up as extras under the proper movie but it's the movie list being filled with movie extras that's the problem.

The missing [x,y,z] was just to say they seem to be getting imported differently than the top level movie in case that was helpful.  I guess I'll have to poke at how the extension stores movies and extras to see why extras are being listed as full movies.  In case it's not obvious they do not show up as full movies in Emby.

Edit 1:  Ok, I can clearly see in the Kodi videoversion table lots of extras with itemType 0 which means movie.  It's not all the extras though.  Some do get correctly marked with a value of 1.

Edit 2:  Extras showing up as movies have double entries in the Kodi files table.  The extras as movies all seem to be assigned the lowest values.  (This is from a brand new database.)  So it's like they're getting imported first somehow as movies then later as movie extras.\

Edit 3:  I added a new movie and the problem didn't occur.  So moved all the broken ones out of emby's view and then put the back.  Problem gone.  Probably an emby problem, or more an edge case where E4K and emby don't agree since it didn't break emby itself.  Oddly everytime I said "repair" the database in e4k it would not remove those extra extras and instead add additional copies.  It required a factory reset to remove the extra extras (false movies).

I'll run a few tests but not expecting too much...

Also I keep an eye on extras, if you find any pattern, let me know.

Do you have older Kodi logs? Any crashes reported? That's usually the first thing I always check.

Edited December 28, 2024 by quickmic

[seashell 42]

10 hours ago, quickmic said:

I'll run a few tests but not expecting too much...

Also I keep an eye on extras, if you find any pattern, let me know.

Do you have older Kodi logs? Any crashes reported? That's usually the first thing I always check.

I don't have a kodi log with the bad imports as it got wiped as I cleaned things out testing.  Where are extras stored in the emby database?  I could see if anything is obviously different between the current state and the state a couple days ago from the emby backups.

Also you might look at your code for importing a library vs removing a library and see if there is a difference there that would lead to the extra extras being added on import but not removed on delete.

[quickmic 1703]

1 minute ago, seashell said:

I don't have a kodi log with the bad imports as it got wiped as I cleaned things out testing.  Where are extras stored in the emby database?  I could see if anything is obviously different between the current state and the state a couple days ago from the emby backups.

Also you might look at your code for importing a library vs removing a library and see if there is a difference there that would lead to the extra extras being added on import but not removed on delete.

In (Kodi's) emby db it's in the Video table when tagged as "isSpecial".

One limitation/issue I know, Emby does not report any changes of specials. e.g. name change of a special. At least not via realtime (websocket) updates. The specials are reloaded by each change of the core item e.g. a movie, but not specials only.

[seashell 42]

So I just looked at the emby library.db from when the problem existed.  Checking an extra extra that I remembered it does indeed show up in the database twice, once with the "Extra Type" column as a 1 and once with it as null.  So I'd guess you're picking up the one with a null and listing that as a movie.  And the reason emby got away with this error is probably because both entries have the correct parent Id pointing to the movie whereas the movie itself points to the movies library as the parent.  So emby probably uses that parent Id to gather the library entries and thus didn't show the duplicate.

There still might be difference in your code relating to this on import vs delete as the behavior was different.

Edit:  Although I'm not sure how you picked it up given I only requested the one library and the bad entry doesn't have that parent as its parent.  Hmm.

Edited December 28, 2024 by seashell

[quickmic 1703]

15 minutes ago, seashell said:

So I just looked at the emby library.db from when the problem existed.  Checking an extra extra that I remembered it does indeed show up in the database twice, once with the "Extra Type" column as a 1 and once with it as null.  So I'd guess you're picking up the one with a null and listing that as a movie.  And the reason emby got away with this error is probably because both entries have the correct parent Id pointing to the movie whereas the movie itself points to the movies library as the parent.  So emby probably uses that parent Id to gather the library entries and thus didn't show the duplicate.

There still might be difference in your code relating to this on import vs delete as the behavior was different.

Well could also be that video was once reported as a regular video and turned into a special at some point. As mentioned, Emby does not report changes of specials and might also not report deletion. I know from other scenarios, (e.g. remove content from playlist), emby does not report that.

So might be correctly handled by plugin, hard to say at this point. At least a library repair should have fixed the problem, I'll check that. However, modifications of specials after init sync is problematic and I cannot fix it in reliable way.

btw, it's also not good that Emby has no separate content type for specials (e.g. like they do have for trailers). Specials are "Video" content same as homevideos.

Both are "Video", that's why I need the "isSpecial" tag at this point.

Edited December 28, 2024 by quickmic

[quickmic 1703]

8 minutes ago, quickmic said:

Well could also be that video was once reported as a regular video and turned into a special at some point. As mentioned, Emby does not report changes of specials and might also not report deletion. I know from other scenarios, (e.g. remove content from playlist), emby does not report that.

So might be correctly handled by plugin, hard to say at this point. At least a library repair should have fixed the problem, I'll check that. However, modifications of specials after init sync is problematic and I cannot fix it in reliable way.

btw, it's also not good that Emby has no separate content type for specials (e.g. like they do have for trailers). Specials are "Video" content same as homevideos.

Both are "Video", that's why I need the "isSpecial" tag at this point.

Just came to mind, I might can change the receive update procedure on startup sync for videos. This could at least be a better workaround, however, nothing short term.

[seashell 42]

This was definitely an emby problem (the double entries) nothing changed in the structure of the directories from when I moved them to emby's library folder the first time and when I then moved the folder out and back the second time to fix it.  It might be related to which files got copied in first when I moved them into the emby library folder.

The key question to me is how did you pick up an item whose parent Id in emby wasn't the library you were importing?  Probably by following down a tree from library to movies to extras.  I don't know the Emby api, so maybe this isn't possible, but the database itself has a column "ExtraType" and if that's null but the parent isn't a library you probably shouldn't import it as a top entry for that library.

[quickmic 1703]

1 hour ago, seashell said:

The key question to me is how did you pick up an item whose parent Id in emby wasn't the library you were importing? 

Good question at this point, no answer at the moment.

Quote

I don't know the Emby api, so maybe this isn't possible, but the database itself has a column "ExtraType" and if that's null but the parent isn't a library you probably shouldn't import it as a top entry for that library.

Well currently, I request extras for each e.g. movie when the "SpecialFeatureCount" parameter/counter is > 0 for a movie.

Once a movie is deleted, it also deletes all videos with the ParentId of this movie. This should work, meanwhile I also tested the library removal. No issue found here.

Anyway, it might be much better, if I request on a e.g. movie library sync additionally all "Video" content as they must be a special (at least I hope so) . It would spare additional Emby queries on sync and probably fixes the specials update on startup. I see what I can do...

Seems not working...

Edited December 28, 2024 by quickmic