embyforkodi (next-gen) 11.X.X support

[quickmic 1703]

4 minutes ago, dapharsyde said:

In the case of this log file, I navigated from the Add-on menu, selecting Emby Video add on -> Dynamic Nodes -> [MyRootFolder]->Folder, then I navigate around my content from there. 

My typical use case is accessing the Dynamic nodes from a skin shortcut, but I thought I'd test this first.

I am in Addon mode (assuming that's the default)

Dio you try to delete a complete folder, or a single e.g. movie file?

[quickmic 1703]

11 minutes ago, dapharsyde said:

In the case of this log file, I navigated from the Add-on menu, selecting Emby Video add on -> Dynamic Nodes -> [MyRootFolder]->Folder, then I navigate around my content from there. 

My typical use case is accessing the Dynamic nodes from a skin shortcut, but I thought I'd test this first.

I am in Addon mode (assuming that's the default)

Another question, do you try to delete via contect menu -> Emby: delete or via keyboard -> del key?

[dapharsyde 12]

6 minutes ago, quickmic said:

Another question, do you try to delete via contect menu -> Emby: delete or via keyboard -> del key?

I tried deleting a single video file via Context menu, by selecting "EMBY: Delete Item" - normally a popup appears asking me to confirm, but instead the context menu just closes.

(Deleting files works on 10.0.47 with this same setup)

Edited December 3, 2024 by dapharsyde

[quickmic 1703]

6 minutes ago, dapharsyde said:

(Deleting files works on 10.0.47 with this same setup)

Same Kodi skin? Anything changed from Kodi side?

[dapharsyde 12]

1 minute ago, quickmic said:

Same Kodi skin? Anything changed from Kodi side?

No changes at all.  I can go back and forth between versions to restore and remove this functionality.

[quickmic 1703]

4 minutes ago, dapharsyde said:

No changes at all.  I can go back and forth between versions to restore and remove this functionality.

Does the delete warning message come up?

[dapharsyde 12]

Just now, quickmic said:

Does the delete warning message come up?

No it does not.  The context menu just closes.

[quickmic 1703]

11 minutes ago, dapharsyde said:

No it does not.  The context menu just closes.

Please replace this file ../addons/plugin.service.emby-next-gen/helper/context.py

Restart Kodi and trigger the delete again. Then send me the log.

fyi, I disabled the actual delete function, it's just a simulation but it should bring up the warning message etc.

thanks

context.py

Edited December 3, 2024 by quickmic

[dapharsyde 12]

4 hours ago, quickmic said:

Please replace this file ../addons/plugin.service.emby-next-gen/helper/context.py

Restart Kodi and trigger the delete again. Then send me the log.

fyi, I disabled the actual delete function, it's just a simulation but it should bring up the warning message etc.

thanks

context.py 18.31 kB · 0 downloads

here is a log file as requested - note that it still did not bring up the warning message confirming if i want to delete the file.

kodi.log

Edited December 3, 2024 by dapharsyde

[quickmic 1703]

12 minutes ago, dapharsyde said:

here is a log file as requested - note that it still did not bring up the warning message confirming if i want to delete the file.

kodi.log 320.71 kB · 0 downloads

And now, I see the problem. The content you are about to delete is a "video" and not a "movie", "episode" or "musicvideo" etc.

Is the file from a Emby homevideos library?

I'll add support for that too.

[dapharsyde 12]

1 minute ago, quickmic said:

And now, I see the problem. The content you are about to delete is a "video" and not a "movie", "episode" or "musicvideo" etc.

Is the file from a Emby homevideos library?

I'll add support for that too.

yes, it is home video & photos content - thank you for your efforts.

[quickmic 1703]

New BETA version available 11.1.9:

Delta changelog 11.1.8 -> 11.1.9

fix delete homevideos via dyanmic nodes
fix download homevideos
fix progress updates for homevideo in native mode

[rotational467 43]

21 hours ago, quickmic said:

In my skin there is an option to change the default version in the info screen -> versions.

 

 

 

In plugin's config menu -> sync -> there is an option "Set highest video resolution as default". If you disable, it will be the same order as Emby server lists the versions.

 

 

OK great, thanks for the info and the screenshot, all questions answered.  Thanks again for all the hard work.

I think you've mentioned it before but I can't find it, which skin are you using?

Edited December 4, 2024 by rotational467

[dapharsyde 12]

10 hours ago, quickmic said:

New BETA version available 11.1.9:

Delta changelog 11.1.8 -> 11.1.9

fix delete homevideos via dyanmic nodes
fix download homevideos
fix progress updates for homevideo in native mode

confirmed that deleting homevideos via dynamic nodes is working now

I did notice in this version, the popup menu warns "No path info available, be careful what you do!", whereas previously the warning read, "Delete file from Emby?" - this new warning sounded scary, but the delete still worked as expected.

[quickmic 1703]

1 hour ago, dapharsyde said:

this new warning sounded scary

Yes, and it should. There is no easy way to verify which file actually will be delete by dynamic nodes. A tiny mistake in the code or awkward Emby server scenarios could lead into deleting the wrong file(s).

For synced nodes at least you can see the path of the deleted file. The plugin sends only the EmbyId to the server as a delete request. If this ID is assigned to another file (and the plugin did not update the EmbyId for some reason) it would delete the wrong file.

I tested the code very carefully but in the end it's up to you using this function.

[quickmic 1703]

3 hours ago, rotational467 said:

which skin are you using?

estuarymodv2 from Kodinerds withe some custom patches

.

Edited December 4, 2024 by quickmic

[quickmic 1703]

fyi, if there are no major issues reported in the next two week, I'll tag 11.1.9 as stable.

 

known limitations of 11.1.9:

- musicalbum are not updated in realtime

- several playlist (sync and nodes) issues

I'll fix it in next version but requires some code modifications which I'm not gonna risk adding as long no stable version is released.

Edited December 7, 2024 by quickmic

[rotational467 43]

On 03/12/2024 at 22:27, quickmic said:

estuarymodv2 from Kodinerds withe some custom patches

.

Wanted to say thanks, and what a shocking difference switching to this skin has made.  I figured I was safe because the Arctic skin has been around in some form or another forever and so "must be" mature, but effectively every little annoyance and major problem I've had, all with no obvious source, has stopped with this skin (I would assume stock would be fine too?  But boring!).  In particular some time back I reported issues with autoplay next episode causing hangs and crashes, and while some of those were resolved (particularly for Roku clients) by emby updates, Kodi was basically unstable for me if I had autoplay/play from here enabled, including random mid-playback CTD's for no explicable reason.

So the two lessons here are - When troubleshooting "random" kodi problems, try again without the fancy skin.  And Arctic Zephyr Reloaded does not play nice with E4K.

[whisperer 11]

Hi, I'm having two issues:

1. In addon mode, external subtitles don't auto-load (works fine in native mode)

2. In native mode, multi-version TV shows have playback issues - only first version works. Other versions fail because Kodi uses original media library path instead of Emby's "Shared network folder" path (e.g. nfs://192.168.50.222/volume2/video2/NasTool/TV)

Any ideas to fix any of these? Thanks

kodi2.log

[quickmic 1703]

1 hour ago, whisperer said:

1. In addon mode, external subtitles don't auto-load (works fine in native mode)

What do you mean with autoload? If you are talking about dvdsub, it's a Emby server issue.

 

Quote

2. In native mode, multi-version TV shows have playback issues - only first version works. Other versions fail because Kodi uses original media library path instead of Emby's "Shared network folder" path (e.g. nfs://192.168.50.222/volume2/video2/NasTool/TV)

@LukeThat's also a known Emby server bug.

 

 

 

 

Edited December 14, 2024 by quickmic

[whisperer 11]

Hi, the second issue matches what I’m experiencing.

For the first issue, my case is a bit different:

I have an external subtitle file (same name as the video) in the same directory as the video (P1).
In native mode, the external subtitle appears in the subtitle list and is selected by default (P2).
In addon mode, the external subtitle doesn’t show up in the subtitle list at all (P3).

[quickmic 1703]

1 hour ago, whisperer said:

Hi, the second issue matches what I’m experiencing.

For the first issue, my case is a bit different:

I have an external subtitle file (same name as the video) in the same directory as the video (P1).
In native mode, the external subtitle appears in the subtitle list and is selected by default (P2).
In addon mode, the external subtitle doesn’t show up in the subtitle list at all (P3).

Please upload the subtitle file for review.

[whisperer 11]

22 minutes ago, quickmic said:

Please upload the subtitle file for review.

Thanks, here is a sample subtitle.

pgs_subtitle_sample.sup

[quickmic 1703]

1 hour ago, whisperer said:

Thanks, here is a sample subtitle.

pgs_subtitle_sample.sup 27.6 MB · 0 downloads

Thanks, I can see the problem. The subtitle size is quite big and the download times out after 6 seconds.

I'll increase the timeout for subtitle download in next version, but frankly not sure if it's a great idea to use pgs subtitles.

Edited December 14, 2024 by quickmic

[brainbrain 1]

In my library i have one or 2 .iso files. If I open them directly in kodi (via file manager), they open and work, if I open them via library (emby), they say file not found. 

In the log it says 
EMBY.core.common: No mediastreams found for movie: 74014 / (link).iso

is this a known issue?