Intro Detection not working

[rbjtech 5284]

4 minutes ago, crusher11 said:

Time to create a thread in the Plugins forum?

Yep - just coding my changes as we speak - Chapter task no longer spams the debug logs ..  

I'll take a look at the other changes needed .. but yea, will open a new topic in the Plugins forum.

[ryderjj89 33]

Uhh glad I could help y'all get going on this then LOL. I guess I'll check out the plugin when its updated.

[rbjtech 5284]

1 hour ago, ryderjj89 said:

Uhh glad I could help y'all get going on this then LOL. I guess I'll check out the plugin when its updated.

I'm not doing anything re the Plex import  - it just so happens I'm working on the previous Introskip Plugin making a few changes now it's open source.

 

[chef 3810]

16 hours ago, rbjtech said:

Ah cool ok - I see it's now Public - Thanks @chef- I hope you are well

The source builds ok with the latest 4.8 Nuget so lets see if it still works ok .. 

There are changes in 4.8 to some internal methods. Keep an eye out for build errors around the .AsSpan() methods on strings.

Guess the core devs decided not to use them again... Until the next release when they'll put it back.

[rbjtech 5284]

7 hours ago, chef said:

There are changes in 4.8 to some internal methods. Keep an eye out for build errors around the .AsSpan() methods on strings.

Guess the core devs decided not to use them again... Until the next release when they'll put it back.

Luckily It's all working fine thus far, I made a few changes and it compiled ok with no errors.   Thanks @chef

[Junglejim 385]

23 hours ago, rbjtech said:

Yep - just coding my changes as we speak - Chapter task no longer spams the debug logs ..  

I'll take a look at the other changes needed .. but yea, will open a new topic in the Plugins forum.

What happened to the original thread? I can't seem to find now. That had a wealth of information in there.

[TeamB 2438]

On 3/17/2024 at 8:30 PM, rbjtech said:

Yep - just coding my changes as we speak - Chapter task no longer spams the debug logs ..  

I'll take a look at the other changes needed .. but yea, will open a new topic in the Plugins forum.

What is the address of the Github repo for the original source, the one that was made public a few weeks ago?

[rbjtech 5284]

10 hours ago, TeamB said:

What is the address of the Github repo for the original source, the one that was made public a few weeks ago?

https://github.com/chefbennyj1/Emby.IntroSkip

 

[crusher11 1101]

On 3/17/2024 at 5:23 PM, crusher11 said:

Time to create a thread in the Plugins forum?

No?

[rbjtech 5284]

47 minutes ago, crusher11 said:

No?

When I've got something to share - then I'll create a new thread.. 

[stevehoffman203 19]

On 3/14/2024 at 8:20 AM, ryderjj89 said:

Yeah the intro does start late into the show. Fire Country is another example. Plenty of episodes with no intros but they do happen sometimes later in the show.

As for supernatural, there is over 300 episodes but only 11% have the markers. That's definitely not right. Almost every single episode features the intro in a different style for that season. It's the same for that season, just a different style basically. Like all of season 1 will be in one style, season 2 in another, etc.

Wouldn't be an issue if the task would run but it doesn't. I'm not sure what I'm missing here.

Another example is Evil.  It's Intro doesn't start until around the 13 1/2 minute mark and totally gets missed.

[rbjtech 5284]

2 hours ago, stevehoffman203 said:

Another example is Evil.  It's Intro doesn't start until around the 13 1/2 minute mark and totally gets missed.

It will do because the cutoff for Intro's is 10 or so minutes.

Otherwise for the other 99.9% of shows, you'll just slow down detection for each one by adding and extra 5 minutes of 'fingerprint' to scan through.

[stevehoffman203 19]

Maybe it's just me, but I prefer accuracy over speed.  The seems the old plugin did better.

[ebr 16178]

20 hours ago, stevehoffman203 said:

Maybe it's just me, but I prefer accuracy over speed

Well, at what cost?  The above is not really a fair statement of the situation.  One of the biggest complaints we get is the length of the scans so many are very concerned about speed.

As RBJ pointed out, the current setting will work for 99% of content.  Changing it makes the scans much longer for that 99% in order to find this 1%.  In general, that is a bad trade-off in the world of computer systems.

[stevehoffman203 19]

Is there not a way that we can decide for ourselves?  Perhaps an option to change that setting so that those of us who don't care about the length of the scans can capture the so called 1%?

[seanbuff 1316]

3 hours ago, stevehoffman203 said:

Perhaps an option to change that setting

ebr already linked to the hidden setting that controls this on the previous page of this thread.

[stevehoffman203 19]

On 7/20/2024 at 7:17 PM, seanbuff said:

ebr already linked to the hidden setting that controls this on the previous page of this thread.

I saw that and attempted to use it, but it didn't appear to work for me.  I shut down Emby, added the line.  Refreshed MetaData on Season 4 of the show Evil, rescanned the library.  

It sill finds nothing.  The intro for this show is about a minute and a half long.

Since that thread had some age to it, I figured that the option had been removed by now.

<IntroDetectionFingerprintLength>30</IntroDetectionFingerprintLength>