Don't trim common names of multi-version

[siakasa 0]

I made an original post in github Multi version panel filter same characters of version part from the title · Issue #3769 · MediaBrowser/Emby (github.com)

You can check the link for my guess about how emby handles the muti-version naming. I'm not a developer so if there's any thing wrong please point it out and I'm happy to hear from you.

I'll do more explanation about my request.

Under current logic, when comes to multi-version movies organized like

Quote

/media1/movie/jpn/Movie/Pulp Fiction (1994) [tmdbid=680]/Pulp Fiction (1994) [tmdbid=680] - 1080p_Wiki.mkv

/media1/movie/jpn/Movie/Pulp Fiction (1994) [tmdbid=680]/Pulp Fiction (1994) [tmdbid=680] - 1080p_beast.mkv

the drop-down menu text will be 

Quote

Wiki

beast

instead of 

Quote

1080p_Wiki

1080p_beast

 

After comparing with Jellyfin's code, it seems that emby doing extra name trim.
From what I learned from source code, firstly emby will cut the folder name from filename since multi-version video's prefix must be the same as folder name. Secondly, trim blank space and hyphen. Finally trim common string which raise my problem.
Generally speaking, I don't get the benefit of trimming because it will lose information anyway. I use hard-link/renaming script to reorgnaized my file like this:

Quote

{Movie name} ({year}) [tmdbid={idstr}] - {videosource}_{resolution}_{videoformat}_{effect}(optional)_{groupname}
Pulp Fiction (1994) [tmdbdi=680] - BluRay_1080p_H265_HDR_Wiki
Pulp Fiction (1994) [tmdbdi=680] - BluRay_1080p_REMUX_Wiki

It's too complicated to adjust the multi-verison's field order if I want to show all the info since fileds differ almost everytime.

 

Feature Request
Just don't trim common names in multi-version files.

[GrimReaper 4740]

Been mentioned number of times, some progress has been made, not all the way there yet. Will eventually be sorted in one of the upcoming releases. 

[RedWings 15]

I don't want this feature i like the way emby handle it right now.

[ebr 16184]

11 hours ago, siakasa said:

From what I learned from source code, firstly emby will cut the folder name from filename since multi-version video's prefix must be the same as folder name. Secondly, trim blank space and hyphen. Finally trim common string which raise my problem.

Actually, it is much simpler than that.  Everything that matches is discarded - leaving only the unique parts of each file. That really is the only logical way I could see to do this.  Knowing that, you should be able to name the files in such a way to display the way you wish.

[Cheesegeezer 3104]

13 minutes ago, ebr said:

Actually, it is much simpler than that.  Everything that matches is discarded - leaving only the unique parts of each file. That really is the only logical way I could see to do this.  Knowing that, you should be able to name the files in such a way to display the way you wish.

Agreed, but the purpose of Emby multiversions is that its only the quality that should change.. is that correct? And it’s actually not intended for different cuts, such as director, extended, theatrical, etc.  
 

i always get muddled up on this. But i think I’m correct 

[ebr 16184]

Just now, Cheesegeezer said:

but the purpose of Emby multiversions is that its only the quality that should change.. is that correct?

That is what the feature was designed for and how it works best.  It is possible to use it for different cuts but with some limitations, like chapters and other meta information not necessarily matching up properly.

[crusher11 1101]

2 hours ago, ebr said:

Actually, it is much simpler than that.  Everything that matches is discarded - leaving only the unique parts of each file. That really is the only logical way I could see to do this.  Knowing that, you should be able to name the files in such a way to display the way you wish.

Or just remove everything up to and including the space-hyphen-space, like it did for years. 

[siakasa 0]

10 hours ago, ebr said:

Actually, it is much simpler than that.  Everything that matches is discarded - leaving only the unique parts of each file. That really is the only logical way I could see to do this.  Knowing that, you should be able to name the files in such a way to display the way you wish.

I decompiled the dll metioned in the issue before and delete the 'TrimCommonNames' logic. Finally it works as I expected.