chef 3810 Posted October 21, 2024 Author Posted October 21, 2024 42 minutes ago, Quincarter said: The missing thumb is for the original content @chef! Also they seem to be duping TV Shows in the currently watching section. I edited my post you replied to showing the movies also losing their thumb image. Would you mind running the scheduled task to refresh the top picks, then send me a log file. I am home tomorrow and have some spare time. This plugin has been at the top of my list of shit I have to take care of. I can t do much about the duping of content thumbs. Emby is treating the top pick item as if it were a secondary version. So they will share watched states. But, top picks created a new db entry it will show a second thumb. I'm very sorry I can fix that issue, but I can try and fix the missing thumbs.
Quincarter 0 Posted October 21, 2024 Posted October 21, 2024 How would you like me to send that to you @chef? As a DM or something? Or just add it here in the forum?
Quincarter 0 Posted October 21, 2024 Posted October 21, 2024 Nvm i just scraped it for any identifiable content and it should be good. Sending. It does look like an error report happened at the end when i opened up my home page and it logged it. embyserver.txt
kjhedges 67 Posted October 22, 2024 Posted October 22, 2024 I use TopPicks as a Movie Top 10 kind of thing. I normally select the movie for the TopPicks to display and everything good. Today, I tried to change the Top Picks Items, but something seems to be going wrong. Above is my selection of movies to add to Top Picks. I then Update Top Picks and also Run the scheduled Task Update Top Picks. This is the result for Top Picks. It has put 2 TV Series in the list which I didnt add and also has previous Top Picks items. Any ideas welcomed
chef 3810 Posted October 26, 2024 Author Posted October 26, 2024 (edited) On 10/22/2024 at 9:49 AM, kjhedges said: I use TopPicks as a Movie Top 10 kind of thing. I normally select the movie for the TopPicks to display and everything good. Today, I tried to change the Top Picks Items, but something seems to be going wrong. Above is my selection of movies to add to Top Picks. I then Update Top Picks and also Run the scheduled Task Update Top Picks. This is the result for Top Picks. It has put 2 TV Series in the list which I didnt add and also has previous Top Picks items. Any ideas welcomed Okay. Thank you for reporting this. Please try to remove the entire list of items and run refresh on the empty list. Then add your items back and run refresh again. Please let me know how you do. Edited October 26, 2024 by chef
kjhedges 67 Posted October 26, 2024 Posted October 26, 2024 @chef I tried as you said, but it still had the items there even though none were in top picks list. I then went /emby/data/top-picks and manually deleted the items in there and done a refresh on the Top-Picks library, then Top-Picks was empty. So I then added some new items to Top-Picks in settings and refreshed again and I now have the correct items in the Top-Picks list. Somewhere, the permissions seemed to have changed, and the items couldn't be removed by Top-Picks I then changed a couple of items in Top-Picks and refreshed and everything seems to be working correctly. 1
Suliamu 36 Posted October 28, 2024 Posted October 28, 2024 (edited) On 10/19/2024 at 8:40 AM, Suliamu said: Yip it also stopped working for me. When i try to update the top picks i get forever spinning and nothing gets updated. Restarting server doesn't help. Keeps spinning. But worse of it is that now all libraries are not longer visible in the backend. Shows "0 libraries". Restarting server also doesn't help with this. I will have to uninstall the plugin for now sadly. Hopefully there will be a fix soon. I've by now tried basically everything, besides reinstalling emby. Removing the plugin, removing the library, reinstalling, restarting, removing files in /emby/data/top-picks, i have tried every combination, but i always get same symptoms: After restart i can go to my libraries in setting. They show. When i open the settings-tab for the plugin, i only see a forever turning blue circle. The bottom button to update the top-picks-library does nothing. After i visited this settings-tab of the plugin, my libraries don't show up anymore in the library-view in settings. The most striking thing is that this worked until at least the last update without problems. Can you advise maybe any fix on file-system base since nobody else seems to have those problems it seems? Could it be that there is a bug with a certain amount of libraries? I have 14. Added couple some time ago. I am not exactly sure if the update broke it or adding those new libraries. Thanks in advance Edited October 28, 2024 by Suliamu
Bottles51 74 Posted October 30, 2024 Posted October 30, 2024 @SuliamuYou are not the only one with this problem. For me if I add a movie manually to the list it will stop the loading spin. Then to update Top Picks I go to Embys Scheduled Tasks and update Top Picks from there. That my work around for now. I create my list manually and have not tested anything else. Hope this helps. 1
chef 3810 Posted October 30, 2024 Author Posted October 30, 2024 I have a fix. I will put it up today. 1
chef 3810 Posted October 30, 2024 Author Posted October 30, 2024 Hmmm... It's not a compatibility issue. I'll have to examine this further. 1
chef 3810 Posted October 30, 2024 Author Posted October 30, 2024 This is taking forever. I'm going to put together a test file here if that is okay. 1
chef 3810 Posted October 31, 2024 Author Posted October 31, 2024 Okay, I have found an issue. I just have to figure out what changed the task library. That will stop the constant load of the config page. 1
chef 3810 Posted October 31, 2024 Author Posted October 31, 2024 (edited) @Luke, Hello sir. I think I am have found something in taskbutton.js. My initial findings: there is a condition referring to the instance of the TaskButton's "resume" method, which seems to have been removed or changed. I haven't looked at TaskButton in a long, long time, but it is causing a loading issue with my configuration page. Thanks again, edit: sorry it doesn't matter, I can handle this error... not a biggie! Edited October 31, 2024 by chef
chef 3810 Posted October 31, 2024 Author Posted October 31, 2024 (edited) Okay I've fixed the loading issue. Before I update the catalog, I'd best try to fix some of the other stuff. If you want to test it, please try this : Emby.TopPicks 1.0.0.61b.zip (Please remember to clear the browser cache to load the new js properly.) - config page to load properly td: - error checking list creation on the config page. (kjhedges) - what to do when missing thumbnail (Quincarter) default: image - check emby's form elements, and style components (name may have changed): Textbox, Select Edited October 31, 2024 by chef 2
Angel273 9 Posted October 31, 2024 Posted October 31, 2024 Aun sigue tieniedo errores no los muestra en el inicio si agrega aparentemente las peliculas pero desaparece labliblioteca 1
Suliamu 36 Posted October 31, 2024 Posted October 31, 2024 5 hours ago, chef said: Okay I've fixed the loading issue. Before I update the catalog, I'd best try to fix some of the other stuff. If you want to test it, please try this : Emby.TopPicks 1.0.0.61b.zip 9.77 MB · 1 download (Please remember to clear the browser cache to load the new js properly.) - config page to load properly td: - error checking list creation on the config page. (kjhedges) - what to do when missing thumbnail (Quincarter) default: image - check emby's form elements, and style components (name may have changed): Textbox, Select Thanks for your time and support and those fixes.
chef 3810 Posted October 31, 2024 Author Posted October 31, 2024 I have also fixed the styles issue for checkboxes. I've gotta check to see if that task button error is going to cause issues. I'm not sure the event handler gets attached since the task button errors.
chef 3810 Posted October 31, 2024 Author Posted October 31, 2024 10 hours ago, Angel273 said: Aun sigue tieniedo errores no los muestra en el inicio si agrega aparentemente las peliculas pero desaparece labliblioteca I wonder if this is a UI thing or an API thing... I've got to try and replicate this. I'll randomly add and remove list items to try and break it. 1
Suliamu 36 Posted November 1, 2024 Posted November 1, 2024 Hey there, thanks again for your support. I installed the latest plugin-version 1.0.0.62 and unfortunately there is still no functionality for me. I can put items into the list. This works and there is no constant loading anymore. But the button to "Update Top Picks" is unfortunately non functional. Also the library overview in the server-settings again is fully empty unfortunately. When i go to my normal library-view of Movies, all the selected Top-Picks have the little label in the corner, so that at least works. But the library, the plugin created, that shows on the start page, is also empty.
chef 3810 Posted November 1, 2024 Author Posted November 1, 2024 43 minutes ago, Suliamu said: Hey there, thanks again for your support. I installed the latest plugin-version 1.0.0.62 and unfortunately there is still no functionality for me. I can put items into the list. This works and there is no constant loading anymore. But the button to "Update Top Picks" is unfortunately non functional. Also the library overview in the server-settings again is fully empty unfortunately. When i go to my normal library-view of Movies, all the selected Top-Picks have the little label in the corner, so that at least works. But the library, the plugin created, that shows on the start page, is also empty. I see that as well. This is because the task button library may have changed in the core. I'm currently looking into it further. 1
chef 3810 Posted November 2, 2024 Author Posted November 2, 2024 (edited) I found the button issue. I know what happened. The core developers on the Web interface fixed the taskButton library file location issue... finally. LOL. We use to have to add the path for "components" to the taskButton library when defining it.It seems we no longer have to do that... I think. That's nice. EDIT: although that change has happened, it is not the cause for the task button to error. Edited November 2, 2024 by chef 1
chef 3810 Posted November 2, 2024 Author Posted November 2, 2024 I am having a heck of a time with taskButton library. I think I have to temporarily disable the button on the plugin in page, and you'll have to run it from the scheduled task page. At least until I can figure out how taskButton is working now. I can see that auto organize utilizes that library. I'll see what it does now, and hopefully understand it enough to implement it in Top Picks. 1 2
SanderA 0 Posted November 5, 2024 Posted November 5, 2024 (edited) Cool idea for this plugin, I'm so far testing it in the trial version. I skimmed through this thread and see that the hiding of watched movies is tied to the whole "Hide Played Media From Latest media" checkbox and that can't be chosen on a per-library basis for now, fair enough. But since I still want to keep this setting on and not see recently watched items on the homepage, could you make an option to remove the numbers from the thumbnails? That way yes, I might have less than 9 items on the home page sometimes but at least they are not numbered and some missing from between. And also when checking the library itself with all the entries, the sorting by name wouldn't affect the visual look and numbers wouldn't be out of order there as well. To be fair, I don't actually care for the numbered list anyway since if I use User Engagement, it's not a definite "top 10 list" anyway but should be more like a semi-random suggestion of stuff other users like, in no particular order so the numbers don't really make sense in my mind anyway. Along with this option it could then use the original thumbnails of media items and not build them from the backdrop and logo, maybe speed up the job that way as well. Removing the numbers from thumbnails should actually make it easier to expand the list too, right? I'm guessing the 9 item limit is mostly because of the number not fitting on the thumbnail (or more so on the primary image). With no numbers there could also more easily be a higher limit (even 10 would be better as a nice round number). Edited November 5, 2024 by SanderA
kjhedges 67 Posted November 6, 2024 Posted November 6, 2024 @chefI have a question regarding Video Backdrops. I notice that if I view a Top Picks media item, the video backdrop does not play. Should this do so? If not, will you be implementing it? Cheers 1
chef 3810 Posted November 7, 2024 Author Posted November 7, 2024 23 hours ago, kjhedges said: @chefI have a question regarding Video Backdrops. I notice that if I view a Top Picks media item, the video backdrop does not play. Should this do so? If not, will you be implementing it? Cheers I'll have to look at that. Video backdrops may not be implemented for top picks. It's probably doable, I'll have to look for those backdrops and copy them into the top pick folder. 1
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now