chef 3810 Posted December 4, 2022 Author Posted December 4, 2022 Just now, woenk said: tvshow. nfo from original folder: tvshow.nfo 6.06 kB · 0 downloads From TopPicksfolder: tvshow.nfo 5.87 kB · 0 downloads Epsiode info drom original folder: S01E01 - Rosie the Robot.nfo 5.07 kB · 0 downloads From Topipicks folder (season 1): The Jetsons - 1x01 - Rosie the Robot.nfo 2.42 kB · 0 downloads but as already stated it also stuff like this: The Jetsons - 1x01 - Elroy Meets Orbitty.nfo 2.33 kB · 0 downloads As said, it creates those for every episode when one does not have season folders in the original place, meaning you have all episodes as dupilcates in every season folder. and logfiles:D embyserver (2).txt 3.54 MB · 0 downloads I think this! <season>-1</season> <episode>-1</episode> So I have removed this data from the nfos. I think it's messing with Emby. I'm just going to let the library scan take care of this data for us. I'll be back with an update shortly.
chef 3810 Posted December 4, 2022 Author Posted December 4, 2022 (edited) I've moved the virtual folder selection into the Engagement task. This should make it a ,little more clear about what these options do. And Yes @TheUrbanXplorer they stop items from appearing in the user engagement task results.... I'm 99% sure... @horstepipe I haven't forgotten you. I've laid the ground work to recreate the original Alpha-picker for the media select. It won't be in this new release, but probably the next one. @woenk I am pretty sure, that those nfo tags were the issue. It's a really trick thing. I'll release this now. Edited December 4, 2022 by chef 1
chef 3810 Posted December 4, 2022 Author Posted December 4, 2022 1 hour ago, woenk said: tvshow. nfo from original folder: tvshow.nfo 6.06 kB · 2 downloads From TopPicksfolder: tvshow.nfo 5.87 kB · 0 downloads Epsiode info drom original folder: S01E01 - Rosie the Robot.nfo 5.07 kB · 0 downloads From Topipicks folder (season 1): The Jetsons - 1x01 - Rosie the Robot.nfo 2.42 kB · 0 downloads but as already stated it also stuff like this: The Jetsons - 1x01 - Elroy Meets Orbitty.nfo 2.33 kB · 0 downloads As said, it creates those for every episode when one does not have season folders in the original place, meaning you have all episodes as dupilcates in every season folder. and logfiles:D embyserver (2).txt 3.54 MB · 0 downloads Well, now it's obvious it is the way we are writing them in the folder structure. So, it's probabaly not fixed in that last release, and I haven't completely wrapped my head around the entire problem yet. Bare with me here. All the episodes in the entire series initially lives in one folder. So, when we recursively get episodes that aren't broken up into seasons, then everything copies over into each season folder. so, a condition needs to check each episode and what season it belongs too before creating the strm file and the path it belongs in? @woenk I think you might make my brain explode before this is over
woenk 62 Posted December 4, 2022 Posted December 4, 2022 7 minutes ago, chef said: Well, now it's obvious it is the way we are writing them in the folder structure. So, it's probabaly not fixed in that last release, and I haven't completely wrapped my head around the entire problem yet. Bare with me here. All the episodes in the entire series initially lives in one folder. So, when we recursively get episodes that aren't broken up into seasons, then everything copies over into each season folder. so, a condition needs to check each episode and what season it belongs too before creating the strm file and the path it belongs in? @woenk I think you might make my brain explode before this is over I think the really best way would be to leave emby handle it The seasons get split by emby automatically, no matter if one has seasons folder or not. Don't know who Emby does it, but I think a database query should give you the result. If Emby already knows it, you should not need to check in which season each episode is in Somewhere you created those new episode infos.... their name greatly differs from the original (Series - 1x01 instead of S01E01), I do not think rewriting those info is necessary. If it is correct in the original folder, you do not need to change that.
chef 3810 Posted December 5, 2022 Author Posted December 5, 2022 5 hours ago, woenk said: Somewhere you created those new episode infos.... their name greatly differs from the original (Series - 1x01 instead of S01E01), I do not think rewriting those info is necessary. Those file names won't make any difference. It's just how they are getting copied. I've set up a test library it'll be fixed shortly.
Happy2Play 9780 Posted December 5, 2022 Posted December 5, 2022 7 hours ago, chef said: I think this! <season>-1</season> <episode>-1</episode> So I have removed this data from the nfos. I think it's messing with Emby. I'm just going to let the library scan take care of this data for us. I'll be back with an update shortly. Don't think this is the issue as Emby tvshow.nfo has the same. But testing this I get the same results as everything is combine per season. Library Top Picks Items are multi-versioned even though there nfo file shows (Sorry didn't change file episode name but doesn't matter) So there is an issue somewhere in the plugin with show\episode structure. 1
chef 3810 Posted December 5, 2022 Author Posted December 5, 2022 please let me know if I have fixed the episode duplication issue in .33 released this morning. if it is still an issue, I have a separate fix to put in place, however I think it will be fix.... 99% sure.
Fretawekakoep 3 Posted December 5, 2022 Posted December 5, 2022 Hi guys, I was wondering if anyone else noticed that the scheduled task 'calculate user engagement' suddenly stopped working and is giving me errors? *** Error Report *** Version: 4.7.10.0 Command line: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/system/EmbyServer.dll -programdata /share/CACHEDEV1_DATA/.qpkg/EmbyServer/programdata -ffdetect /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffdetect -ffmpeg /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffmpeg -ffprobe /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffprobe -defaultdirectory /share/CACHEDEV1_DATA/Public -updatepackage emby-server-qnap_{version}_x86_64.qpkg -noautorunwebapp Operating system: Linux version 5.10.60-qnap (root@U16BuildServer118) (x86_64-QNAP-linux-gnu-gcc (toolchain config: [gcc-4.9.2 binutils-2.25 glibc-2.21]) 4.9.2, GNU ld Framework: .NET 6.0.8 OS/Process: x64/x64 Runtime: share/CACHEDEV1_DATA/.qpkg/EmbyServer/system/System.Private.CoreLib.dll Processor count: 4 Data path: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/programdata Application path: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/system System.NullReferenceException: System.NullReferenceException: Object reference not set to an instance of an object. at Emby.TopPicks.Drawing.SpotlightImageRenderer.RenderTopPicksThumbImage(Int32 rank, SKBitmap bitmapBackdrop, SKBitmap bitmapLogo, String output) at Emby.TopPicks.SpotlightLibraryUpdateScheduledTask.RenderImages(Int32 rank, BaseItem libraryBaseItem, String outputFolder, CancellationToken cancellationToken) at Emby.TopPicks.SpotlightLibraryUpdateScheduledTask.<>c__DisplayClass37_0.<<Execute>b__2>d.MoveNext() Source: Emby.TopPicks TargetSite: Void RenderTopPicksThumbImage(Int32, SkiaSharp.SKBitmap, SkiaSharp.SKBitmap, System.String) Input string was not in a correct format. at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, TypeCode type) at System.Convert.ToInt64(String value) at Emby.TopPicks.UserEngagement.EngagementStatistics.GetParentIds(PluginConfiguration config) at Emby.TopPicks.UserEngagement.EngagementStatistics.GetHighestRankedLibraryItems(PluginConfiguration config) at Emby.TopPicks.UserEngagement.EngagementStatistics.CalculateEngagement() at Emby.TopPicks.UserEngagement.EngagementStatistics.GetEngagementItems() at Emby.TopPicks.UserEngagement.UserEngagementRefreshScheduledTask.Execute(CancellationToken cancellationToken, IProgress`1 progress) at Emby.Server.Implementations.ScheduledTasks.ScheduledTaskWorker.ExecuteInternal(TaskOptions options) Any ideas what is going wrong here? Many thanks and keep up the awesome work!!!
woenk 62 Posted December 5, 2022 Posted December 5, 2022 5 hours ago, chef said: please let me know if I have fixed the episode duplication issue in .33 released this morning. if it is still an issue, I have a separate fix to put in place, however I think it will be fix.... 99% sure. looks good so far for me at least 1
chef 3810 Posted December 5, 2022 Author Posted December 5, 2022 3 hours ago, Fretawekakoep said: Hi guys, I was wondering if anyone else noticed that the scheduled task 'calculate user engagement' suddenly stopped working and is giving me errors? *** Error Report *** Version: 4.7.10.0 Command line: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/system/EmbyServer.dll -programdata /share/CACHEDEV1_DATA/.qpkg/EmbyServer/programdata -ffdetect /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffdetect -ffmpeg /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffmpeg -ffprobe /share/CACHEDEV1_DATA/.qpkg/EmbyServer/bin/ffprobe -defaultdirectory /share/CACHEDEV1_DATA/Public -updatepackage emby-server-qnap_{version}_x86_64.qpkg -noautorunwebapp Operating system: Linux version 5.10.60-qnap (root@U16BuildServer118) (x86_64-QNAP-linux-gnu-gcc (toolchain config: [gcc-4.9.2 binutils-2.25 glibc-2.21]) 4.9.2, GNU ld Framework: .NET 6.0.8 OS/Process: x64/x64 Runtime: share/CACHEDEV1_DATA/.qpkg/EmbyServer/system/System.Private.CoreLib.dll Processor count: 4 Data path: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/programdata Application path: /share/CACHEDEV1_DATA/.qpkg/EmbyServer/system System.NullReferenceException: System.NullReferenceException: Object reference not set to an instance of an object. at Emby.TopPicks.Drawing.SpotlightImageRenderer.RenderTopPicksThumbImage(Int32 rank, SKBitmap bitmapBackdrop, SKBitmap bitmapLogo, String output) at Emby.TopPicks.SpotlightLibraryUpdateScheduledTask.RenderImages(Int32 rank, BaseItem libraryBaseItem, String outputFolder, CancellationToken cancellationToken) at Emby.TopPicks.SpotlightLibraryUpdateScheduledTask.<>c__DisplayClass37_0.<<Execute>b__2>d.MoveNext() Source: Emby.TopPicks TargetSite: Void RenderTopPicksThumbImage(Int32, SkiaSharp.SKBitmap, SkiaSharp.SKBitmap, System.String) Input string was not in a correct format. at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, TypeCode type) at System.Convert.ToInt64(String value) at Emby.TopPicks.UserEngagement.EngagementStatistics.GetParentIds(PluginConfiguration config) at Emby.TopPicks.UserEngagement.EngagementStatistics.GetHighestRankedLibraryItems(PluginConfiguration config) at Emby.TopPicks.UserEngagement.EngagementStatistics.CalculateEngagement() at Emby.TopPicks.UserEngagement.EngagementStatistics.GetEngagementItems() at Emby.TopPicks.UserEngagement.UserEngagementRefreshScheduledTask.Execute(CancellationToken cancellationToken, IProgress`1 progress) at Emby.Server.Implementations.ScheduledTasks.ScheduledTaskWorker.ExecuteInternal(TaskOptions options) Any ideas what is going wrong here? Many thanks and keep up the awesome work!!! I know what that is. Give me until tonight. I will fix that. 1 1
Happy2Play 9780 Posted December 5, 2022 Posted December 5, 2022 I edited my test files but still see issues as items for nonexistent items are being made. Top Picks In Show folder have S04E01, S05E01, S06E01 thru S06E07. I will guess if you have all episodes, one will not see an issue.
Fretawekakoep 3 Posted December 5, 2022 Posted December 5, 2022 (edited) 1 hour ago, chef said: I know what that is. Give me until tonight. I will fix that. Take your time brother. Appreciate your support on this, good to know you’ve identified the problem! Edited December 5, 2022 by Fretawekakoep
chef 3810 Posted December 5, 2022 Author Posted December 5, 2022 2 hours ago, Happy2Play said: I edited my test files but still see issues as items for nonexistent items are being made. Top Picks In Show folder have S04E01, S05E01, S06E01 thru S06E07. I will guess if you have all episodes, one will not see an issue. By nonexistent do you mean virtual items? Would it be possible to see a log?
Happy2Play 9780 Posted December 5, 2022 Posted December 5, 2022 (edited) 38 minutes ago, chef said: By nonexistent do you mean virtual items? Would it be possible to see a log? Don't have missing enabled on this library. When in show\episode structure Top Pick creates its own stuff for episode that are missing vs show\season\episode structure shows the properly just like library. It is like it makes each season have the same number of episodes whether they exist or not. embyserver.txt Only these items exist in folder S04E01, S05E01, S06E01 thru S06E07, but placing these in season folders corrects the issue. Edited December 5, 2022 by Happy2Play 1
chef 3810 Posted December 6, 2022 Author Posted December 6, 2022 3 hours ago, Happy2Play said: Don't have missing enabled on this library. When in show\episode structure Top Pick creates its own stuff for episode that are missing vs show\season\episode structure shows the properly just like library. It is like it makes each season have the same number of episodes whether they exist or not. embyserver.txt 370.15 kB · 1 download Only these items exist in folder S04E01, S05E01, S06E01 thru S06E07, but placing these in season folders corrects the issue. I can reproduce this now. Why, oh why? 1
chef 3810 Posted December 6, 2022 Author Posted December 6, 2022 ... And it's fixed. Holy Mackinaw. I could get into the the whole "DisplayParent" vs. "Parent", and building libraries from the bottom up, instead of the top down. ... but perhaps some other time... when you want to be completely board out of your skull. Thank goodness Emby devs have these options... that you'd only ever use once in a life time. Someone was thinking when they built the API, and db, that is for certain. A little more testing, and I'll make a new release.
chef 3810 Posted December 6, 2022 Author Posted December 6, 2022 6 hours ago, Fretawekakoep said: Take your time brother. Appreciate your support on this, good to know you’ve identified the problem! This has been fixed in the new release. But, if the task still fails, please go into the config page select an options for the TV shows, and for the Movies under user engagement. Run the task, then go back and un-select those options if you don't want them selected. Apparently the configuration got a bit messed up in the last release. I apologize. 1
chef 3810 Posted December 6, 2022 Author Posted December 6, 2022 (edited) On 12/4/2022 at 6:52 AM, Painkiller8818 said: How exactly is the actual selection of the top-picks working? For me it generates always the same top-picks so i can use the plugin actually only with pinned top-picks. Even if i watch about 20 movies in a week, there are no new movies in the top-picks so not sure if it is using any movies from the history i watched or anything else to create new recommendations for me Another thing i recorgnized, on my Samsung TV, there is no option to sort top-picks so they are not displayed in the correct order. Any plans to add such an option in a future update? Thanks Hey Painkiller. I saw this and wanted to make sure I replied. The engagement task does take into consideration watched state of items. We hold a variable and add to it for each user who has watched an item (all the way through) if (item.IsPlayed(user)) entry.Value.TotalPlayedCount++; Which means, increment the total play count every time a user has watched that particular item. We then take that TotalPlayedCount and divide it into the total Users.Count on the server. That gives us a frequency rating (watched frequency) on the item. However, there is room for improvement here. The reason you may not see items change regularly is because of the Critic/Community ratings, which weighs heavily on the outcome. I'm starting to see (over time) that those ratings may weigh to much, and tip the over all outcome of the stat. Perhaps the best way to handle this is to do two things to the statistic calculations. Only give critic/Community a chunk of the over all stat to occupy. Like 50%. For example: if the Critic/Community rating was0.9, it would actually only be 0.45 (it's out of 50% of the whole stat.) Use the Inverse of TotalPlayCount / User.TotalRecordCount, if the percentage is less then 50% For example: 2 out of 5 users watched the item. It would currently rank 0.4. We could invert that and give the item 0.6 which would rank it higher because that is the percentage of users who have not watched the item yet. It would be interesting to hear from any other "stat guys" out there who are probably better then me at understand frequency/engagement ratings ( I've read a couple articles on the subject... enough to write the plugin with simplified stat logic). I would make the engagement task code public for anyone who wants to have a go Edited December 6, 2022 by chef 1
Fretawekakoep 3 Posted December 6, 2022 Posted December 6, 2022 (edited) 5 hours ago, chef said: This has been fixed in the new release. But, if the task still fails, please go into the config page select an options for the TV shows, and for the Movies under user engagement. Run the task, then go back and un-select those options if you don't want them selected. Apparently the configuration got a bit messed up in the last release. I apologize. Thanks a bunch - everything works back as intended! Edited December 6, 2022 by Fretawekakoep 1
Darkseidd 59 Posted December 7, 2022 Posted December 7, 2022 hi. i tried this and looks good on my emby HOWever, when i try to click movie entry of top pick, it will leads me to nothing. and few moments later, my rpi4 os will reboot on its own. it didnt happen on tvseries top pick this is server log..happens around 1:22pm before the server boot itself embyserver122pm.log
Darkseidd 59 Posted December 7, 2022 Posted December 7, 2022 ca'nt seems to edit previous post. Noticed weird issue where Continue Watching spawns two entry when pausing a tv series.
Junglejim 385 Posted December 7, 2022 Posted December 7, 2022 8 minutes ago, Darkseidd said: ca'nt seems to edit previous post. Noticed weird issue where Continue Watching spawns two entry when pausing a tv series. Yea that will happen, I don't think there's much that can be done about it. It happens with other plugins to (New Releases). It will go away after it's watched. This is just a sample from my admin account, it shows main lib movie, top picks(plugin) and new releases(plugin). Basically the two virtual library's also show the same progress as the main lib movie. 1
Bottles51 74 Posted December 7, 2022 Posted December 7, 2022 (edited) 11 hours ago, Junglejim said: Yea that will happen, I don't think there's much that can be done about it. It happens with other plugins to (New Releases). It will go away after it's watched. This is just a sample from my admin account, it shows main lib movie, top picks(plugin) and new releases(plugin). Basically the two virtual library's also show the same progress as the main lib movie. I think this could fix the problem but would be up to the devs to implement. Please support if you agree. Edited December 7, 2022 by Bottles51
Fretawekakoep 3 Posted December 8, 2022 Posted December 8, 2022 Hi chef sorry to bother you again, I think something is going wrong with the image render process? Tried the different cover options but got the same result, ironically it only affects those postions many thanks
chef 3810 Posted December 8, 2022 Author Posted December 8, 2022 On 12/7/2022 at 12:31 AM, Darkseidd said: hi. i tried this and looks good on my emby HOWever, when i try to click movie entry of top pick, it will leads me to nothing. and few moments later, my rpi4 os will reboot on its own. it didnt happen on tvseries top pick this is server log..happens around 1:22pm before the server boot itself embyserver122pm.log 75.19 kB · 1 download I don't see anything in the log. Can you run the update task again, and let me know if you still have that issue?
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now