DLNA Subtitle index is ignored by dlna plugin 1.0.89

[kelepop 6]

here attached the log @Luke

dlna-subtitle-select-is-wrong.txt

you can see that SubtitleStreamIndex=2 when request API

but ,kodi got SubtitleStreamIndex=3

 

related: 

 

[Luke 42077]

HI, what happens is we give Kodi all of the subtitle tracks, not just the selected ones. As far as I know there's no way to tell Kodi which track to pick. 

The only thing we could do is exclude the non-selected tracks, but then if we do that you won't be able to change tracks from within the menu in Kodi.

[kelepop 6]

8 hours ago, Luke said:

HI, what happens is we give Kodi all of the subtitle tracks, not just the selected ones. As far as I know there's no way to tell Kodi which track to pick. 

The only thing we could do is exclude the non-selected tracks, but then if we do that you won't be able to change tracks from within the menu in Kodi.

I make some sniff with wireshark, that‘s true , subtitle selection will change the order of `<res protocolInfo="http-get:*:text/srt:*">` or  `<res protocolInfo="http-get:*:text/ass:*">`

the problem is :

on the kodi side:

kodi only load the first subtitle found in the <res protocolInfo>, even we passed all subtitle, I will try to make a patch to see if multi subtitle works, then I will open a PR to kodi  along with the ASS support patch

on the EMBY side: 

basically，it did the right thing,but,if I set subtitle to off,it still send kodi all the subtitle we have.

Edited October 10, 2022 by kelepop

[Luke 42077]

Quote

basically，it did the right thing,but,if I set subtitle to off,it still send kodi all the subtitle we have.

Which I think makes sense otherwise you wouldn't be able to use the menu in Kodi to turn them back on.

[kelepop 6]

On 10/10/2022 at 12:40 PM, Luke said:

Which I think makes sense otherwise you wouldn't be able to use the menu in Kodi to turn them back on.

https://github.com/xbmc/xbmc/pull/22038 I pulled a new PR and waiting for any Futher steps of the kodi team

once they accept it I will open a back port PR to kodi 19 also

 

I'm glade to see a full functional DLNA subtitle selection on kodi

 

[Luke 42077]

Excellent, thanks !

[kelepop 6]

On 10/17/2022 at 1:05 AM, Luke said:

Excellent, thanks !

good news, The fix to KODI 20 was accepted

bad news,they seems not not interested in  backing port the fix to KODI 19

：（