chef 3810 Posted September 19, 2022 Author Posted September 19, 2022 (edited) 5 minutes ago, Happy2Play said: @chef APPROVED = 1 and does not show. For my test only G rating will appear. Oh, I'll change that to APPROVED, and see what happens. Edited September 19, 2022 by chef 1
chef 3810 Posted September 19, 2022 Author Posted September 19, 2022 Ah darn. I have set each country version. Approved is a top level enum option, but from what I can see, an item has to be set to "APPROVED" in the metadata. What are all the G ratings equivalents? G U ...
Happy2Play 9780 Posted September 19, 2022 Posted September 19, 2022 3 minutes ago, chef said: Ah darn. I have set each country version. Approved is a top level enum option, but from what I can see, an item has to be set to "APPROVED" in the metadata. What are all the G ratings equivalents? G U ... @Lukemay have to assist as I only have an old PM we worked adjusting country rating in the snippet I posted earlier.
Luke 42077 Posted September 20, 2022 Posted September 20, 2022 You really need them all? 1 is the lowest and G maps to that, as many others do.
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 (edited) 9 minutes ago, Luke said: You really need them all? 1 is the lowest and G maps to that, as many others do. But if you have other country rating it will not be G. RU-0+, UK-U and so one. Can the index be targeted or does the Channel need All country certifications to popular all items with a 1 index? Only G will popular no other new ParentalRating("TV-Y", 1), new ParentalRating("APPROVED", 1), new ParentalRating("G", 1), new ParentalRating("E", 1), new ParentalRating("EC", 1), new ParentalRating("TV-G", 1), Edited September 20, 2022 by Happy2Play
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 9 minutes ago, Luke said: You really need them all? 1 is the lowest and G maps to that, as many others do. So it does map back to 1 on the enum. That is what I thought would happen.
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 If the enum maps back for all the country codes, I had best double check the code and make sure it is not doing some kind of comparison to "G", and that it is mapping properly to the enum.
Luke 42077 Posted September 20, 2022 Posted September 20, 2022 4 minutes ago, Happy2Play said: But if you have other country rating it will not be G. I'm not entirely sure what you're asking, but if MovieDb has a rating that Emby Server doesn't have a mapping for, then we can add it.
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 1 minute ago, Luke said: I'm not entirely sure what you're asking, but if MovieDb has a rating that Emby Server doesn't have a mapping for, then we can add it. Unless it just the code for the channel no other country rating will display in channel except specifically US G rating. example from Reports all index 1.
b0dyr0ck2006 57 Posted September 20, 2022 Posted September 20, 2022 16 hours ago, chef said: If the enum maps back for all the country codes, I had best double check the code and make sure it is not doing some kind of comparison to "G", and that it is mapping properly to the enum. Could it be your code is looking for only G ratings instead of enum 1? If what luke says is correct then any other variation of country codes that point to the equivalent of US G rating should in theory all report back the same. the other reason I proposed the idea of adding options is due to age groups of ‘kids’ for example if you have a child that is 12 they would like the option of seeing higher rated media other than U (or G) it’s a brilliant idea and as it stands currently works well, I just think it could be improved slightly with the ability to raise or lower the rating
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 I think this fixes the ratings issue. Emby.KidsChannel_rating_fixes.zip 1
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 2 hours ago, b0dyr0ck2006 said: Could it be your code is looking for only G ratings instead of enum 1? If what luke says is correct then any other variation of country codes that point to the equivalent of US G rating should in theory all report back the same. Other countries rating point to the same index number 1 so if this channel only looks at G then other countries ratings will not work as they are not G. Since the US has more than one rating that has an index of 1 I can see how this can be an issue as for some. 1
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 (edited) If I limit the library query by using MinParentalRating = 1, and MaxParentalRating = 1 it seems to be okay. The thing that is tricky that you have to watch out for is that NR is 0. So if you just use MaxParentalRating= 1 you end up with kids movies and NR movies... Whoa! Watch out! Edited September 20, 2022 by chef 1
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 10 minutes ago, chef said: The thing that is tricky that you have to watch out for is that NR is 0. Is it 0 or 15? As Reports have them after R, but there are rating that are considered unknown though. 2
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 Just now, Happy2Play said: Is it 0 or 15? As Reports have them after R, but there are rating that are considered unknown though. Yes, that is what it is! Unknown. Nice work! The rating is a nullable integer, so that makes sense. If the rating was null, the query would return all null, and 1 with a MaxParentalRating of 1. Definitely watch out for that. 1
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 1 minute ago, chef said: Yes, that is what it is! Unknown. Nice work! The rating is a nullable integer, so that makes sense. If the rating was null, the query would return all null, and 1 with a MaxParentalRating of 1. Definitely watch out for that. Yes that is why user parental controls need additional settings But the fix appears to be working, online one in my test that isn't would be "APPROVED" but not to worry about it a only really old media us it. 2
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 1 minute ago, Happy2Play said: Yes that is why user parental controls need additional settings But the fix appears to be working, online one in my test that isn't would be "APPROVED" but not to worry about it a only really old media us it. I think I can fix the approved not showing up. One moment... 1
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 (edited) The thing that drives me nuts about the channels (it happens in all them I've tried to make), is that I can't combine the different quality version of an item together. In my kids channel, I have the movie Brave. I have two version of the movie one in 1080p and the other in 2160p. Only the 2160p is shown in the kids channel. Not so great because when someone starts playback of that item it will transcode unless it is on a 4k tv. I wonder how you get the different qualities, or of it is even possible? Edited September 20, 2022 by chef
b0dyr0ck2006 57 Posted September 20, 2022 Posted September 20, 2022 (edited) I may have to pull my finger out and learn how to build these myself so that I can also learn how to debug. I’ve been following your work for years chef and you bring some fantastic stuff to the table. @chefthank you for your efforts, the fix seems to have done the job. One question. In the presented list I have a film called Apollo 11, the metadata shows it as gb-u which obviously is why it’s showing up. If I change the meta rating to 15, and/or custom rating, after a channel refresh it is still showing in the Kids collection but does show the rating change as 15. something I’m doing wrong? Edited September 20, 2022 by b0dyr0ck2006
Happy2Play 9780 Posted September 20, 2022 Posted September 20, 2022 2 minutes ago, b0dyr0ck2006 said: I may have to pull my finger out and learn how to build these myself so that I can also learn how to debug. I’ve been following your work for years chef and you bring some fantastic stuff to the table. @chefthank you for your efforts, the fix seems to have done the job. One question. In the presented list I have a film called Apollo 11, the metadata shows it as gb-u which obviously is why it’s showing up. If I change the meta rating to 15, and/or custom rating, after a channel refresh it is still showing in the Kids collection but does show the rating change as 15. something I’m doing wrong? I have notice issues here also. Do you save metadata with media or database only? Which item did you edit Channel or library item? But a Library scan may be needed also when editing these duplicated items.
chef 3810 Posted September 20, 2022 Author Posted September 20, 2022 It seems like you have to change the custom rating on the original item. From what I can see, changing the parental rating may not stick if the item gets refreshed. So it is the custom rating that must be edited. After that, refreshing internet data should rebuild the kids movie library. But, I think happy2play is right, it might also need a library scan. Wether that needs to happen before or after the internet channels refresh... I'm not sure... Let me know how it goes. Thank you for the kind words also.
Happy2Play 9780 Posted September 21, 2022 Posted September 21, 2022 2 hours ago, chef said: But, I think happy2play is right, it might also need a library scan. Wether that needs to happen before or after the internet channels refresh... I'm not sure... A follow up on this as if users do not write nfo files library and Channel item info can be different as each has their own database entry. From a nfo standpoint they would uses the same information as it resides with media a both entries would update the nfo file. 1
b0dyr0ck2006 57 Posted September 21, 2022 Posted September 21, 2022 (edited) 22 hours ago, chef said: It seems like you have to change the custom rating on the original item. From what I can see, changing the parental rating may not stick if the item gets refreshed. So it is the custom rating that must be edited. After that, refreshing internet data should rebuild the kids movie library. But, I think happy2play is right, it might also need a library scan. Wether that needs to happen before or after the internet channels refresh... I'm not sure... Let me know how it goes. Thank you for the kind words also. Using the file 'Apollo 11' for reference. If i change the metadata through Emby for this file editing the rating from GB-U to GB-15, also changing the custom rating to the same (I've checked the NFO file and this shows my changes), then running a library scan and scanning the metadata folder then refreshing internet data fixes this on the channel. It would still be handy to be able to adjust the rating for older kids though, I'm not sure if this would be possible Edited September 21, 2022 by b0dyr0ck2006 2
chef 3810 Posted September 23, 2022 Author Posted September 23, 2022 here is an update that includes all the things we found out while creating new releases Emby.KidsChannel_v1.0.0.3.zip 2
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now