Jump to content

Recommended Posts

crusher11
Posted

So I still have all these phantom 0:00 chapters popping up everywhere and we're just not dealing with that anymore? Meaning all the time I spent detecting and editing intro and end credits times was completely wasted? 

Posted
On 7/9/2022 at 2:37 PM, crusher11 said:

So I still have all these phantom 0:00 chapters popping up everywhere and we're just not dealing with that anymore? Meaning all the time I spent detecting and editing intro and end credits times was completely wasted? 

I think everyone is feeling a little burnt out on this at the moment. Its been a hell of a ride over many months.

From what I can tell all intro detection will now be handled by the core Emby server implementation. I think the idea is uninstall the plugin and just use Emby server 4.7 implementation. My understanding is that a new plugin will be released (or a revamped SkipIntro) that has the intro detection removed so the sooner you move to  using the core implementation the better now that it is official and available in the latest Emby server 4.7 release.

https://emby.media/community/index.php?/topic/110226-save-time-with-embys-intro-skip/

I dont think there is a chapter editor at the moment, I was going to look at building something but was told it is coming in the core Emby server but I dont know when but am hesitant to do the work and then have the core release something that makes it redundant.

My biggest frustration at the moment is I can not see the Intro detection results using just the core implementation, so can not verify that it is working as intended.

 

  • Agree 1
crusher11
Posted

I'm pretty ticked off that they've done this while I still have a glitch that's causing endless streams of corrupt chapter data to ruin the usability of all my content. And as you say, we're now without an editor at all. I spent hours customising my data, as @Cheesegeezer and @chef were talking about smoothly integrating and making sure the core was up to where the plugin was before anything stopped, and now this.

Cheesegeezer
Posted
37 minutes ago, crusher11 said:

I'm pretty ticked off that they've done this while I still have a glitch that's causing endless streams of corrupt chapter data to ruin the usability of all my content. And as you say, we're now without an editor at all. I spent hours customising my data, as @Cheesegeezer and @chef were talking about smoothly integrating and making sure the core was up to where the plugin was before anything stopped, and now this.

Well if you had bothered to speak to me, i could have put you in the picture.  That i'm working on a fix for your issue & that i can give you a new dll to try.

So why not come and speak to me before you decide to throw your toys out of the pram all over the forums.

🤔

  • Agree 1
rbjtech
Posted (edited)

We are working on it and we are dependent on the core providing us with information as well - the same question as teamB is asking above - is the core providing an editor or not ?

The Plugin IS integrated with the Core - I use it everyday, this is what the chapter task does.

It has a minor bug which creates duplicate chapters on some scenerio's - it's fix depends on the above - we are not gonna spend time on a plugin that has no future.

To note - We all have busy day jobs - we develop/test these enhancements FOC - so please, respect that issues arise and take time to get resolved.

Edited by rbjtech
  • Like 2
crusher11
Posted

"It takes time" is fine, and I was waiting on progress within the thread. That's all fair enough.

But then @Cheesegeezer locked it, and said the plugin would be deleted and no further support would be provided.

To me, PMing Cheese to demand that he look further into my specific problem seemed more of a toys-out-of-pram move than the creation of this thread. If that's ongoing then fair enough, but the decision to pull the plugin and lock the thread still seems rather abrupt and odd.

Posted

An editor is in the works. At least it will give us something to use until the core team develop their own, or maybe even integrate what we write.

We'll try and write something that will take the data from the db, and copy into something useable.

Keep that database data @crusher11

  • Like 1
  • Agree 1
rbjtech
Posted
11 minutes ago, chef said:

An editor is in the works. At least it will give us something to use until the core team develop their own, or maybe even integrate what we write.

We'll try and write something that will take the data from the db, and copy into something useable.

Keep that database data @crusher11

The data is already 'imported' into the Core db - in the chapters table @chef :)

Dave did that a while back - but the part we are 'missing' is we are still editing the Introskip dB - we need to edit the Core dB directly for both Intro's and Credits - and as you said above, this is already in the works.

So as far as I'm concerned - no data has been lost, nobody is going to lose any data once we transition to the new editor/plugin ...

Removing the plugin was the right thing to do - as having both encouraged more users to use the plugin (as it was, and still is, more feature rich) BUT we then need to support them when the Core catches up - which is not ideal for both parties.

  • Like 1
Posted
1 hour ago, rbjtech said:

is the core providing an editor or not ?

Now, that isn't really very fair... we've answered that question a long time ago.  The answer has not changed.

Cheesegeezer
Posted (edited)

Crusher PM me. You don’t have to demand. You can just ask.

closing the plugin needed to be done. 
 

@chef chapter task does the heavy lift to migra To the core, i need to fix a couple of things from the intro issue PM’s then we should be good to go.

 

Edited by Cheesegeezer
Posted
38 minutes ago, rbjtech said:

The data is already 'imported' into the Core db - in the chapters table @chef :)

Dave did that a while back - but the part we are 'missing' is we are still editing the Introskip dB - we need to edit the Core dB directly for both Intro's and Credits - and as you said above, this is already in the works.

So as far as I'm concerned - no data has been lost, nobody is going to lose any data once we transition to the new editor/plugin ...

Removing the plugin was the right thing to do - as having both encouraged more users to use the plugin (as it was, and still is, more feature rich) BUT we then need to support them when the Core catches up - which is not ideal for both parties.

Cool, excellent work moving data over. 

That's is actually great news.

You can tell I got lost waaay back there. 🤦‍♂️

 

So if users can successfully utilize all their data for intro skip (which is provided by the Emby server), then then it's just a matter of being patient to see all the extras (like a editor, etc).

The core server team have to up keep huge amounts a code, and also try to implement intro skip, which kind of fell in their lap... Or forced in their lap 😆... Depending on how you look at it. 

"Surprise! Here is a feature that the community is keen on implementing in your existing  product, and it means changing some core functionality..." 😶😁

 

But, we are here to help in anyway we can, even if it is just by being patient. 😎

 

  • Like 1
  • Agree 1
Cheesegeezer
Posted

See my post above chef

  • Like 1
rbjtech
Posted (edited)
30 minutes ago, ebr said:

Now, that isn't really very fair... we've answered that question a long time ago.  The answer has not changed.

Hmm ok - the answer back on May 25th was 'yes' we are delivering an editor - but nothing has happened on that thread to suggest it's any closer.

So I think it's reasonable to ask the question again - as others are now putting effort into a plugin editor as a result of closing the main Introskip Plugin and they simply want to know if they are duplicating work - maybe you/Luke haven't started it yet (which is fair enough - you are busy people just like the rest of us ..), but then there is a definite GAP that needs to be resolved here, we can't take away the ability to edit.

Edited by rbjtech
Posted
43 minutes ago, rbjtech said:

So I think it's reasonable to ask the question again

The question was asked again just a few days ago in the PM with all the plug-in devs... and I answered it again there.

In fact, I said, don't spend time on an editor because one will be coming in the core.

  • Like 2
  • Thanks 1
Cheesegeezer
Posted
3 hours ago, ebr said:

The question was asked again just a few days ago in the PM with all the plug-in devs... and I answered it again there.

In fact, I said, don't spend time on an editor because one will be coming in the core.

Agreed and you liked my comment on not wasting time on it… in fact you loved it lol!! 
 

but @chef has put something together very quickly in the interim so all is not lost and we can keep moving forward with this awesome feature!!

 

Posted
4 hours ago, ebr said:

The question was asked again just a few days ago in the PM with all the plug-in devs... and I answered it again there.

In fact, I said, don't spend time on an editor because one will be coming in the core.

 That is the problem with using PM's to talk about this, not everyone is in the loop.

Also given the recent beta cycles of up to 12 months an editor may well be a long way off for main stream users.

Cheesegeezer
Posted
1 hour ago, TeamB said:

 That is the problem with using PM's to talk about this, not everyone is in the loop.

but they don’t always need to be in the loop and a lot of users muddy the thread with unnecessary comments which get lost.  A PM thread is a focused group.

1 hour ago, TeamB said:

Also given the recent beta cycles of up to 12 months an editor may well be a long way off for main stream users.

Can you elaborate? I don’t understand what you mean!

Posted (edited)
25 minutes ago, Cheesegeezer said:

but they don’t always need to be in the loop and a lot of users muddy the thread with unnecessary comments which get lost.  A PM thread is a focused group.

There are multiple dev forums on this system, if you start a dev discussion in a dev forum and a user comes in asking for yellow instead of green you move the post to a none dev thread. I dont normally get involved in PM discussions but that is for personal reasons.

25 minutes ago, Cheesegeezer said:

Can you elaborate? I don’t understand what you mean!

Lets say today Luke releases a kick ass chapter editor in the beta, it is now available for beta users, not everyone, given that beta cycles are taking upwards of 11 months these days it will be months before that chapter editor is available to none beta users. That is all.

Edited by TeamB
Cheesegeezer
Posted
17 minutes ago, TeamB said:

There are multiple dev forums on this system, if you start a dev discussion in a dev forum and a user comes in asking for yellow instead of green you move the post to a none dev thread. I dont normally get involved in PM discussions but that is for personal reasons.

 

17 minutes ago, TeamB said:

Lets say today Luke releases a kick ass chapter editor in the beta, it is now available for beta users, not everyone, given that beta cycles are taking upwards of 11 months these days it will be months before that chapter editor is available to none beta users. That is all.

Have you not been here for the rapid succession of beta builds? 
 

jeez i was using 4.7.0.36 pre releases in nuget for a very short time before we progressed very quickly to 4.8. 
when the core dev team have something in their sights they move fast. 
 

build a plugin… release it or keep as test, you will find how hard it is to maintain and keep up and thats only a plugin.

build an ecosystem for users and thats a mammoth task to orchestrate, and keep up.

perspective my friend

Posted
1 hour ago, Cheesegeezer said:

jeez i was using 4.7.0.36 pre releases in nuget for a very short time before we progressed very quickly to 4.8. 
when the core dev team have something in their sights they move fast. 

is 4.8 released? I though it was the new beta?

1 hour ago, Cheesegeezer said:

build a plugin… release it or keep as test, you will find how hard it is to maintain and keep up and thats only a plugin.

I do, playback reporting, if you stick with the current released nuget and ignore beta it works fine.

1 hour ago, Cheesegeezer said:

build an ecosystem for users and thats a mammoth task to orchestrate, and keep up.

perspective my friend

umm it must be, cos I have no idea what you are talking about, I was just commenting on the beta cycles and if something is in beta now it will be months before it is available to stable release. I am not trying to be controversial here, this is just how it is.

Posted

4.8 is only in beta.

Posted

Every time I see any kind of threads regarding intro skip they are  some arguing going, I suggest you guys change it to into fighting, j/k of course.

I agree with TeamB here, the reason I give up on beta and went to release, that most of the time some info about it spread in either threads or you guys doing PM's, and we do not know nothing about it.

That goes to beta plugins as well.

Posted
17 hours ago, TeamB said:

That is the problem with using PM's to talk about this, not everyone is in the loop.

The user who asked the question here is actively involved in the PM I mentioned because he is a key participant in the plug-in development.

Posted

So happy with intro skip.

Finally ran the task on my production server over night.

It's awesome!

So glad to have this option. 👍😁

  • Haha 1
Posted

I loved this plug in and it worked great for all the shows I owned but after having a bad server failure and having reinstall I noticed it was gone and I didnt have a way to get it back and assumed it was now only a built in feature of emby until i started realizing mine wasnt working at all anymore

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...