Angelblue05 4130 Posted November 6, 2018 Share Posted November 6, 2018 Ok. That's fine. Is there a way to know if an item is remote or was that never needed to know? Link to comment Share on other sites More sharing options...
ebr 14913 Posted November 6, 2018 Share Posted November 6, 2018 Android TV references LocationType quite a bit and is not expecting it to be null... Mostly I look for Virtual but also check for Offline and FileSystem in some places. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted November 7, 2018 Share Posted November 7, 2018 Hi My app needs LocationType as well. Checks for Virtual and Offline. Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 7, 2018 Author Share Posted November 7, 2018 Offline has not been used for a long time. We don't have any database storage to indicate something is offline. All we have is error handling during the library scan for offline content. So the only thing this should be used for is to check if something is virtual Link to comment Share on other sites More sharing options...
ebr 14913 Posted November 7, 2018 Share Posted November 7, 2018 The TV app is using an enum at this point so I'm not sure if that will ever equate to null but, if it does, it will be a problem. The app also has special handling for offline items. When was that removed? Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 7, 2018 Author Share Posted November 7, 2018 A long time ago. We have proper error handling in the library scan for offline, but we don't have knowledge at the database level if something is offline or not. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted November 7, 2018 Share Posted November 7, 2018 Hi @@Luke Is LocationType the only breaking change in .61? I have pretty much hammered out all the other changes and had a fully functional app as of .60..... If it is at all possible can you revert this one? maybe hold it off to the next major dev cycle? Thanks!! Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 7, 2018 Author Share Posted November 7, 2018 This is bloating the api output. It is a trivial change to adapt to if you follow my guidelines above. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted November 7, 2018 Share Posted November 7, 2018 Hi @@Luke Thanks for the answer for the second part of my question, No there is no way this change is going to be delayed. For the first part are there any other breaking changes in .61? And a new one . Will there be a point with a reasonable lead time when breaking changes are frozen before the next stable release? Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 7, 2018 Author Share Posted November 7, 2018 There are no others, and hopefully that was the last one before stable release. 1 Link to comment Share on other sites More sharing options...
Vicpa 556 Posted November 21, 2018 Share Posted November 21, 2018 Hi @@Luke,@ebr A couple more basic questions about location.type offline. Want to make sure I understand …. 1) In the past the type was set to offline if the content was still defined to emby, but the drive etc. was unavailable. Basically some kind of error or removable media? That is correct I hope. Or was it used for anything else? 2) How does the playback manager in the apiclient handle "offline" content is the IsOffline property still valid? or does the client need additional logic there? Thanks sorry for the simple questions... To ebr's comment the enum in the apiclient will be changed at some point Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 21, 2018 Author Share Posted November 21, 2018 Playback has never checked offline. You just try to play and handle the failure appropriately if it fails. the property was never really used for much Link to comment Share on other sites More sharing options...
Vicpa 556 Posted November 21, 2018 Share Posted November 21, 2018 Thanks !!@@Luke Is my assumption in 1) above correct? This is not a big issue for me just making sure I got it right Link to comment Share on other sites More sharing options...
Luke 37071 Posted November 21, 2018 Author Share Posted November 21, 2018 Well yes for #1 that was our goal but it never really materialized. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted December 17, 2018 Share Posted December 17, 2018 Hi @@Luke I am testing ember with 3.6.x for @@7illusions Is there a change to IsRepeat or IsSeries in TV guide info ? In 3.5.3 ember returns "New" as expected (matches web client etc) in 3.6.x everything is flagged as new. Thanks Link to comment Share on other sites More sharing options...
Luke 37071 Posted December 17, 2018 Author Share Posted December 17, 2018 Yes they are two separate properties now, rather than inferring one from the other. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted December 17, 2018 Share Posted December 17, 2018 Hi @@Luke the api in 3.6.x only/always returns null for IsRepeat. That doesn't seem right. Link to comment Share on other sites More sharing options...
Luke 37071 Posted December 17, 2018 Author Share Posted December 17, 2018 It is only true if it is a repeat. Link to comment Share on other sites More sharing options...
Vicpa 556 Posted December 17, 2018 Share Posted December 17, 2018 Thanks for bearing with me "It is only true if it is a repeat." That I understand (I think) The real question is what is the logic to flag a show as being new. in 3.5.3 it looks like if IsRepeat was null and IsSeries is true, Then the show was "New" the 3.6.x logic is different. Link to comment Share on other sites More sharing options...
Luke 37071 Posted December 17, 2018 Author Share Posted December 17, 2018 In 3.5 and below, the server always automagically decided that something was a repeat if it wasn't New. However, i have since learned that these are two independent data fields, and so now in 3.6, a show is only a repeat if the guide data says that it is. Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted December 30, 2018 Share Posted December 30, 2018 @@Luke What is the verdict for Mixed Libraries with 3.6? Are series no longer supported for it? If so, I need to change how Kodi treats that library. OP https://emby.media/community/index.php?/topic/63973-55-mixed-content-failed-detection/?hl=mixed Link to comment Share on other sites More sharing options...
Luke 37071 Posted December 31, 2018 Author Share Posted December 31, 2018 There shouldn't be any change. Hopefully we'll get to the bottom of that. Thanks. 1 Link to comment Share on other sites More sharing options...
Vicpa 556 Posted January 11, 2019 Share Posted January 11, 2019 In 3.5 and below, the server always automagically decided that something was a repeat if it wasn't New. However, i have since learned that these are two independent data fields, and so now in 3.6, a show is only a repeat if the guide data says that it is. Hi @@Luke Still trying to wrap my head around this. Bottom Line How do I determine if a TV show is New? the apiclient. has.. isRepeat isLive isPremiere isSeries Missing from that is an "isNew" Link to comment Share on other sites More sharing options...
Luke 37071 Posted January 11, 2019 Author Share Posted January 11, 2019 Here is some javascript logic that will support both old and new servers: https://github.com/MediaBrowser/emby-webcomponents/blob/master/guide/guide.js#L579-L581 Please note the c# apiclient is a bit out of date and doesn't yet have the IsNew property. 1 Link to comment Share on other sites More sharing options...
7illusions 1249 Posted January 11, 2019 Share Posted January 11, 2019 Thanks @@Luke, I will be spending next week in the US and will have plenty of Jetlag-time and airport-time to spend on fixing the major issues in Ember. From your point of view, what are the most important things that needs to be fixed in the c# apiclient for 3.6? 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now