HDHomeRun.cs logic ? tweak?

[Vicpa 559]

Hi @@Luke,

 

I realize that you haven't had a chance to look at the issue with the HDHR3-CC that I have posted about. Perhaps it is not a model specific issue at all.

 

In my research I think that line is causing my problem.

"var videoCodec = !string.IsNullOrWhiteSpace(GetEncodingOptions().HardwareAccelerationType) ? null : "mpeg2video";

 

The above will only evaluate to "mpeg2video" if encoding is set to auto. which currently means none.

​I have always had my setting at quick sync (qsv).  so it is evaluated to null.

 

with auto you get the codec identified correctly and things that can direct play like the fire work as expected. With "Auto" as the default most users will have the expected experience.

 

Is this check needed ? As a proof of concept I replaced the above with

"var videoCodec =  "mpeg2video";

 

The logic flow in that module is not effected. (it is what auto is doing anyway). The Fire directs plays. and based on the
encode settings either mpeg2video or mpeg2video_qsv decoder is used.

 

I think that is the expected behavior? or am I missing something?

 

When you get a chance can you take a look?

 

Thanks

-Vicpa