Jump to content

dlna custom profile update bug?


luxflow

Recommended Posts

luxflow

how to reproduce bug?

1. prepare emby version 3.0.5986 and install it on linux

(I suspect this bug affect all version of emby, but mine is 3.0.5986)

2. enter emby manager -> DLNA -> Profiles -> Press New button to create custom dlna profile

3. press save button to save custom profile

4. click custom profile which created by previous step

5. change any option and save

 

6. it raises error `Profile is missing Id`

 

I quickly reviewd source code

 

 

https://github.com/MediaBrowser/Emby/blob/923ab2ab3543dc36ddf291775ecd29c1836fb379/MediaBrowser.Dlna/DlnaManager.cs#L453

 

https://github.com/MediaBrowser/Emby/blob/9a02eef8b13a3f966d5d0d605c658659564f5990/MediaBrowser.Api/Dlna/DlnaService.cs#L34

 

In DlnaManager.cs, changing source code from

[ApiMember(Name = "ProfileId", Description = "Profile Id", IsRequired = true, DataType = "string", ParameterType = "path", Verb = "GET")]

publicstringProfileId { get; set; }

to

[ApiMember(Name = "Id", Description = "Profile Id", IsRequired = true, DataType = "string", ParameterType = "path", Verb = "GET")]

publicstringId { get; set; }

 

and after compiling modified source, it seems working

 

but I'm not sure I solved problem correctly. thanks!

Edited by luxflow
Link to comment
Share on other sites

anderbytes

I just noticed that trying to create a new profile from nothing takes me back to dashboard screen, without saving.

Is that what happens to you, too?

 

PS: I was adding HTTP Header... after "OK" inside that screen, goes to dashboard.

Edited by anderbytes
Link to comment
Share on other sites

PS: I was adding HTTP Header... after "OK" inside that screen, goes to dashboard.

 

Thanks, will test that out.

Link to comment
Share on other sites

anderbytes

Correction: brings me back to "New Custom Profile" screen, as if I just clicked to create a new one.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...