Bug with thumb image used for collections

[Deathsquirrel 741]

When a movie doesn't have a thumb image the system creates a fake one for thumb views using a backdrop image with the movie title overliad as plain text.  Collections generate a thumb using a poster image instead so the fake thumb is the wrong aspect ratio compared to all the other thumb images.  You can see the issue below.  Thse poster images are collections that don't have a downloaded thumb.jpg.

 

[jmos1277 9]

I have a couple of similar issues:

 

(1) For movies that are part of a collection and don't have a thumb.jpg file, NO fake thumb is getting generated.  Not even one that uses the wrong aspect ratio art like the original poster's issue.  For movies that are NOT part of a collection and don't have a thumb.jpg file, the generation of a fake thumb seems to be working fine.

 

(2) I use CoverArt.  I've noticed that treatments that are applied to thumbs by CoverArt are ONLY applied to real thumb.jpg images.  CoverArt treatments are NOT applied to the fake generated thumb images.  This can look really odd depending on what CoverArt treatment you apply to your thumb.jpg images.

Edited April 20, 2015 by jmos1277

[ebr 14910]

What are you calling a "fake thumb image"?

[jmos1277 9]

I'm going with the original poster and referring to a fake thumb image as a thumb image that is not actually a thumb.jpg file but rather a backdrop.jpg file that is treated as a thumb when no thumb.jpg exists.

[ebr 14910]

I'm going with the original poster and referring to a fake thumb image as a thumb image that is not actually a thumb.jpg file but rather a backdrop.jpg file that is treated as a thumb when no thumb.jpg exists.

 

Okay, that isn't a "fake" thumb.  That is a backdrop.  It is up to the client app to decide what to do when there is no thumb image and the web client displays the backdrop (with some text overlaid) instead.  

[Deathsquirrel 741]

What are you calling a "fake thumb image"?

 

I should have said generated thumb.  In any case the screenshot illustrates the issue.  One thumb view is generated from a 16X 9 image and the other from 1X3 image.  Looks a bit odd.  If the thumb generated for collections used the collection backdrop instead that would solve it.

Edited April 20, 2015 by Deathsquirrel

[ebr 14910]

I should have said generated thumb.  In any case the screenshot illustrates the issue.  One thumb view is generated from a 16X 9 image and the other from 1X3 image.  Looks a bit odd.

 

Those don't look like generated images to me.  They just look like posters that have been saved as thumbs.

[Deathsquirrel 741]

Yeah, I just checked and it looks like this is solved.  The generated thumbs for collections without a thumb.jpg now use the tiling engine that creates the icons for the views.

 

[Happy2Play 8279]

These poster images are collections that don't have a downloaded thumb.jpg.

I saw this behavior before,  if collections only had poster.jpg and no other images.

[jmos1277 9]

Okay, that isn't a "fake" thumb.  That is a backdrop.  It is up to the client app to decide what to do when there is no thumb image and the web client displays the backdrop (with some text overlaid) instead.  

 

Correct.  When there is no thumb.jpg the web client SHOULD display a backdrop.

I'm encountering the bug when using the web client and attempting to view my Movies using Thumbs (or view Latest Media since it also uses thumbs).

ALL of my movies have backdrop.jpg images.  Not all of my movies have thumb.jpg images.

 

I'll write some code for clarification:

if thumb.jpg exists  // doesn't matter if movie is in collection
{    
    web client behaves as expected and displays thumb.jpg
} 
else if thumb.jpg does NOT exist 
{
    if movie is NOT part of a collection 
    {
        web client behaves as expected and displays backdrop.jpg
    } 
    else if movie is part of a collection 
    {
        web client behaves INCORRECTLY
        displays movie title in white text on empty image frame
        no image is displayed in image frame
    }
}

Just to be clear.  This isn't an issue with just one or two movies.  It behaves EXACTLY as described in the above code for ALL movies in my library.  Therefore, it is not simply an issues with one or two of my backdrop.jpg files.  This is a semantic issue in how the Emby server is handling the use of backdrop.jpg files when a thumb.jpg files does not exist.  It should be fairly easy to hunt down for someone familiar with the code base.

[Vidman 589]

Would it be possible for the dynamic thumbs generated for collections with less than 8 titles to have the numbers of panels in the thumb equal the number of titles? I think it would look much better than a bunch of repeated images for those titles/generated thumbs. And I don't think it would be distracting having differently spaced panels as currently mine are mixed in with collections that do have a thumb image so they are not all uniform anyway.

Oh and how about overlaying the collection logo if it exists instead of plain text?

Edited April 21, 2015 by Vidman

[jmos1277 9]

ebr, just wondering if you've been able to replicate the behavior that I described in post #10.  

I've attached an image that demonstrates the behavior.  The image shows the "Latest Media" section

of my home screen.  

 

The four movies that are missing images are ALL in collections, do NOT have a thumb.jpg, but DO have a backdrop.jpg.

 

[Luke 37053]

so then it seems there's no issue with the web client but rather the movies just don't have the images. is that correct?

[jmos1277 9]

so then it seems there's no issue with the web client but rather the movies just don't have the images. is that correct?

 

The movies don't have thumb.jpg images. However, they do have backdrop.jpg images.

It was my understand that in the absence of a thumb.jpg, the web client would use backdrop.jpg in its place.

And it does for most movies.  Just not for movies that are part of a collection.  

 

For example, in the image in post #12, Fright Night does NOT have a thumb.jpg, but is not part of a collection.  So the web client is showing the backdrop.jpg file.

Likewise, Jason X has no thumb.jpg but it does have a backdrop.jpg image.  However, since it's part of a collection the backdrop.jpg is shown.  

Friday the 13th Part VIII is part of the same collection but it has a thumb.jpg and therefore the thumb.jpg is shown.