[Plugin] Watch Party

[Brendon 124]

@yockerhave now tested a watch party and all seems to be good apart from one thing. The search to select a movie or tv show does not seem to be working, only way to find a movie is via the drop down and that does not work well at all when you have 12,000 movies lol

Edited Monday at 05:53 AM by Brendon

[yocker 1301]

3 hours ago, Brendon said:

@yockerhave now tested a watch party and all seems to be good apart from one thing. The search to select a movie or tv show does not seem to be working, only way to find a movie is via the drop down and that does not work well at all when you have 12,000 movies lol

Will look into it.

[yocker 1301]

17 hours ago, Brendon said:

@yockerhave now tested a watch party and all seems to be good apart from one thing. The search to select a movie or tv show does not seem to be working, only way to find a movie is via the drop down and that does not work well at all when you have 12,000 movies lol

See if this fixed it for you.

WatchPartyForEmby.dll

[Brendon 124]

5 hours ago, yocker said:

See if this fixed it for you.

WatchPartyForEmby.dll 491.5 kB · 2 downloads

No good mate, I selected the movies library, then typed in 'Predator' and nothing came up at all and the 'select content' drop down was still at the very start of the library.

[yocker 1301]

2 hours ago, Brendon said:

No good mate, I selected the movies library, then typed in 'Predator' and nothing came up at all and the 'select content' drop down was still at the very start of the library.

The search is made a bit more intuitive to use.
Select a library and then use the search field.

WatchPartyForEmby.dll

[Brendon 124]

15 hours ago, yocker said:

The search is made a bit more intuitive to use.
Select a library and then use the search field.

WatchPartyForEmby.dll 498.5 kB · 3 downloads

Still no love @yockerI made a video so you can see what i see, have tested in both Firefox and Edge, neither work.

 

 

 

[yocker 1301]

10 minutes ago, Brendon said:

Still no love @yockerI made a video so you can see what i see, have tested in both Firefox and Edge, neither work.

 

 

 

Ahh, i forgot about the limit i added to not bog down the plugin.

I will try and fix it but i need you as test subject as i don't have that many movies in my library to test with.

[Brendon 124]

3 minutes ago, yocker said:

Ahh, i forgot about the limit i added to not bog down the plugin.

I will try and fix it but i need you as test subject as i don't have that many movies in my library to test with.

Happy to test mate, sitting here working from home so can test in between jobs haha

[yocker 1301]

@Brendon
I've added a very, very simple hide function to the limit when search is used.
See if that fixes it.

WatchPartyForEmby.dll

[Brendon 124]

17 minutes ago, yocker said:

@Brendon
I've added a very, very simple hide function to the limit when search is used.
See if that fixes it.

WatchPartyForEmby.dll 498.5 kB · 1 download

Still no luck mate, I tried it on a few different libraries and no luck if there are over 100 items, it seems to be limited to the initial look up. If I tell it to load another 100 and then another etc. so in this test, I loaded up 500 items, and it could search any of those 500 but nothing beyond that.

[yocker 1301]

2 minutes ago, Brendon said:

Still no luck mate, I tried it on a few different libraries and no luck if there are over 100 items, it seems to be limited to the initial look up. If I tell it to load another 100 and then another etc. so in this test, I loaded up 500 items, and it could search any of those 500 but nothing beyond that.

Thank you.
I have a good idea what's wrong, will take a little while to fix.
It only loads a certain number of items into memory to save on resources, so if i search is outside those in memory it just "gives up".

[Brendon 124]

15 minutes ago, yocker said:

Thank you.
I have a good idea what's wrong, will take a little while to fix.
It only loads a certain number of items into memory to save on resources, so if i search is outside those in memory it just "gives up".

No rush mate, take your time, I'll test them as you drop them.

[yocker 1301]

3 hours ago, Brendon said:

No rush mate, take your time, I'll test them as you drop them.

Try this one.

WatchPartyForEmby.dll

[Brendon 124]

19 hours ago, yocker said:

Try this one.

WatchPartyForEmby.dll 511 kB · 2 downloads

Good news mate that one seems to be working  I have a busy morning with work but I will run some more tests as soon as I catch up and report back.

[yocker 1301]

19 minutes ago, Brendon said:

Good news mate that one seems to be working  I have a busy morning with work but I will run some more tests as soon as I catch up and report back.

Good to hear that it's working now!  

Edited 9 hours ago by yocker

[Brendon 124]

@yockerMovie search is working excellent now mate, I have come across a bug when making a watchparty from admin though, when I click create party, I get this...

The default 15 does not seem to work, even if I type it in again. If I put in 1 it worked (I didn't try any others but 15 definitely didn't work for some reason)



Can I suggest some improvements on user security, if possible, that is. At the moment I have to give the same admin password to everyone so they can create watch parties, that same password is used to delete them so someone could go rogue and delete everyone's watch parties and plenty of us have that one family member or friend that will bloody do that 

I would suggest using emby login credentials to create a watch party and deleting a watch party can only be done on the party page by the creator or admin via the admin panel.

 

[yocker 1301]

2 hours ago, Brendon said:

@yockerMovie search is working excellent now mate, I have come across a bug when making a watchparty from admin though, when I click create party, I get this...

The default 15 does not seem to work, even if I type it in again. If I put in 1 it worked (I didn't try any others but 15 definitely didn't work for some reason)



Can I suggest some improvements on user security, if possible, that is. At the moment I have to give the same admin password to everyone so they can create watch parties, that same password is used to delete them so someone could go rogue and delete everyone's watch parties and plenty of us have that one family member or friend that will bloody do that 

I would suggest using emby login credentials to create a watch party and deleting a watch party can only be done on the party page by the creator or admin via the admin panel.

 

Wops, i will fix that.

I don't feel comfortable with messing with the Emby user and passwords (if even possible) but i can look into making the password system better.
I just never really felt it was needed as it was just watch parties.

All i can think of for now is separate passwords for creating and deleting though.
Both and be equally destructive.