Emby NFO Reader using tmdb id as imdb

[m7eesn 13]

Hi, it seems sometimes the NFO reader uses tmdb id as imdb id for example doing quick sync on my library i found the following problematic records

[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [Banner of the Stars Movie (2001)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [89496]. { (backend_id: 318609), (item: [ (id: None), (year: 2001) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [Before I Knew It, I Was Here: Documentary of Nogizaka46 (2019)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [655809]. { (backend_id: 319097), (item: [ (id: None), (year: 2019) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [Dororo (1968)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [726174]. { (backend_id: 318424), (item: [ (id: None), (year: 1968) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [The Laws of the Sun (2000)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [248904]. { (backend_id: 318698), (item: [ (id: None), (year: 2000) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [One Piece Film Gold: Episode 0 (2016)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [779813]. { (backend_id: 318174), (item: [ (id: None), (year: 2016) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [The Prince of Tennis: A Gift from Atobe (2005)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [408973]. { (backend_id: 318496), (item: [ (id: None), (year: 2005) ]) }
[2022-06-12T23:32:43+03:00] WARNING: Ignoring [emby_server] movie [Tales of Zestiria: The Shepherd's Advent (2014)] [guid_imdb] external id. Unexpected value expecting [tt(number)] but got [315843]. { (backend_id: 318289), (item: [ (id: None), (year: 2014) ]) }

I tried to manually remove them, but on next meta refresh it seems Emby reinsert the <id> into imdb external id, one example of NFO they are auto generated by radarr/sonarr

<movie>
  <title>Banner of the Stars Movie</title>
  <originaltitle>星界の戦旗 特別編</originaltitle>
  <sorttitle>banner stars movie</sorttitle>
  <userrating />
  <top250 />
  <outline />
  <plot>A compilation of the Seikai no Senki series with additional footage. Three years of uneasy have passed since the Four Nations Alliance declared war on the Abh Empire. With both sides decimated by the first encounter, the lull in violence has provided enough time to build fleets massive enough to span the entire galaxy. Just before the Abh complete preparations for their conquest, however, the Alliance launches a pre-emptive strike, forcing them to take the defensive. Now in command of her own ship, Lafiel is assigned to the fleet as a destroyer captain, and eagerly awaits the opportunity to prove herself as a true Abriel. But when a new class of enemy ship appears on the front lines, the tides quickly turn for the worse. With her vessel now little more than cannon fodder, her dreams are turned into a desperate race for survival - can she and her crew survive amidst a battlefield of endless death and destruction?</plot>
  <tagline />
  <runtime>120</runtime>
  <thumb aspect="poster" preview="https://image.tmdb.org/t/p/original/dK38rfl7HllIPQ1pMUqTHJWfDWg.jpg">https://image.tmdb.org/t/p/original/dK38rfl7HllIPQ1pMUqTHJWfDWg.jpg</thumb>
  <playcount />
  <lastplayed />
  <id>89496</id>
  <uniqueid type="tmdb" default="true">89496</uniqueid>
  <genre>Science Fiction</genre>
  <genre>Animation</genre>
  <genre>Action</genre>
  <country />
  <set>
    <name>Seikai Collection</name>
    <overview />
  </set>
  <tag>anime</tag>
  <director>Yasuchika Nagaoka</director>
  <year>2001</year>
  <studio></studio>
  <trailer>plugin://plugin.video.youtube/play/?video_id=</trailer>
  <fileinfo>
    <streamdetails>
      <video>
        <aspect>1.4833333</aspect>
        <bitrate>0</bitrate>
        <codec>x264</codec>
        <framerate>59.940063091482649842271293375</framerate>
        <height>480</height>
        <scantype>Progressive</scantype>
        <width>712</width>
        <duration>121.22203333333333</duration>
        <durationinseconds>7273</durationinseconds>
      </video>
      <audio>
        <bitrate>0</bitrate>
        <channels>2</channels>
        <codec>AAC</codec>
        <language>jpn</language>
      </audio>
      <subtitle>
        <language>eng</language>
      </subtitle>
    </streamdetails>
  </fileinfo>
</movie>

 

f

 

from reading kodi NFO spec "

<id></id>

No

No

The default ID. Do not use. This is a Kodi generated tag. See next item.

 

it seem you are expected to parse 

 

<uniqueid type="" default=""></uniqueid>

Yes

Yes

The ID from the scraper site. type="" Identifier of the ID. Do not use "default". Examples of identifier include... <uniqueid type="imdb" <uniqueid type="tvdb" <uniqueid type="tmdb" For non-scraped items, use simple values like "home", "sport", "doco" etc The value can be alpha-numeric eg tt3480556 for imdb, 286668 for tmdb, home001 for home movies, etc default="true" default="false" Only one uniqueID can be set as default="true", additional uniqueID's must be set as default="false" or ommit the default attribute Example of complete entry... <uniqueid type="tmdb" default="true"> <uniqueid type="imdb" default="false"> or <uniqueid type="imdb">

Edited June 12, 2022 by m7eesn
clarify kodi

[Happy2Play 9837]

Would have to look at the code but Emby is expecting the <id> node to have a IMDBid. 

<id>89496</id>

example from a Emby nfo

  <id>tt2395427</id>

 

[m7eesn 13]

1 minute ago, Happy2Play said:

Would have to look at the code but Emby is expecting the <id> node to have a IMDBid. 

<id>89496</id>

example from a Emby nfo

  <id>tt2395427</id>

 

Indeed, i understand that. However, from reading https://kodi.wiki/view/NFO_files/Movies it seems id is unreliable and should only be used as last resort, this problem was present in another media server as well that got fixed recently. If fixing this not possible, at least some sanity check for the imdb id might be needed.

[Luke 42763]

Yea perhaps we should stop looking for that node.

[m7eesn 13]

2 minutes ago, Luke said:

Yea perhaps we should stop looking for that node.

That would be nice. However you may still want to look at this node as last resort if uniqueid not available. people may have older nfo format.  

[m7eesn 13]

@Luke any news regarding potential fix for this issue coming any time soon?

Edited June 29, 2022 by m7eesn

[Luke 42763]

1 hour ago, m7eesn said:

@Luke any news regarding potential fix for this issue coming any time soon?

I started on it but I don't have any other news than that right now, sorry.

[m7eesn 13]

On 6/29/2022 at 10:59 PM, Luke said:

I started on it but I don't have any other news than that right now, sorry.

4 years later this still an issue luke.

[sh0rty 766]

3 hours ago, m7eesn said:

4 years later this still an issue luke.

Why do you use the Sonarr/Radarr nfo functionality when all you need is a proper folder naming for Emby to generate them?

[m7eesn 13]

47 minutes ago, sh0rty said:

Why do you use the Sonarr/Radarr nfo functionality when all you need is a proper folder naming for Emby to generate them?

Many reason for consistently using exactly same metadata, for preserving custom descriptions etc, there is many reasons, not all use case are limited to media servers. Only emby fails to have a check for imdb identifiers, which is really simple bug fix to implement. `^tt` could be used to prevent this mistake from happening. or have proper uniqueid support and drop this legacy thing.

[Luke 42763]

In terms of Emby reading the nfo, couldn't you also configure your other software to not write that value?

[m7eesn 13]

5 minutes ago, Luke said:

In terms of Emby reading the nfo, couldn't you also configure your other software to not write that value?

pray tell how would other software behave exactly? it's not them writing tmdb ids into imdb GUID the issue is limited to emby, AFAIK a simple id.startsWith('tt') could solve it, or more complex regex if you want. I am not sure why the push back against fixing real bug and and for all intent and purposes emby is giving misleading and incorrect info. 

 

and all softwares that are writing nfo files uses tmdb for movies and tvdb for shows. at least that the current standards.

Edited 23 hours ago by m7eesn

[Luke 42763]

If they skip parsing the id node and then on unqiueid check the type attribute for tmdb, imdb, etc. It will indicate what the id is.

[m7eesn 13]

3 minutes ago, Luke said:

If they skip parsing the id node and then on unqiueid check the type attribute for tmdb, imdb, etc. It will indicate what the id is.

 

This might be solution, however as you indicated emby already supports a uniqueids, would it make more sense to prioritize it over the deprecated id? kodi docs mark it as deprecated as well and shouldn't be used if uniqueids is present

[Luke 42763]

Sure, but shouldn't the other software do the same? Because if they already had that implemented then the current nfo's would not cause them any problems because they would just be ignoring the id node.

[m7eesn 13]

8 hours ago, Luke said:

Sure, but shouldn't the other software do the same? Because if they already had that implemented then the current nfo's would not cause them any problems because they would just be ignoring the id node.

I already have a workaround so we dont consider emby randomly generated imdb, see https://github.com/arabcoders/watchstate/blob/master/src/Libs/Guid.php#L66 

My question is, why do you not want to fix a simple bug? i am quite puzzled its not like i am asking for new feature or massive change if the code was open i would happily send PR alas its not. If you dont want to fix it thats fine, i'll just point the people this thread when they complain about about incorrect matching. i just want confirmation from you that you marked this `WONTFIX`

[Luke 42763]

I think we should probably change it, but then we'll have to deal with those that might be impacted by the change. I was just looking for you to confirm that it's really a change that is required on both sides, not just one. emby should stop writing the id node, but your other software should also stop reading it.