PabsTheGeek 3 Posted May 28, 2015 Share Posted May 28, 2015 Just thought I would say "hi" I've been a Plex user for about 6 month and I must say it was great. But in the last few weeks I've been having issues withteh Android client and no help from the official forums. An alternative was sought after, and I've found Emby .. and well I'm still setting up. But the fact its Open Source is a big plus for me!! Assuming all goes well I want to apologize for not find you sooner and I know if I do have trouble, I should hopefully get a better support experience ;-) 3 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted May 28, 2015 Share Posted May 28, 2015 Welcome! 1 Link to comment Share on other sites More sharing options...
ebr 14913 Posted May 28, 2015 Share Posted May 28, 2015 Welcome aboard. If you run into problems or questions come back here and post them and I'm sure you'll get plenty of response. Link to comment Share on other sites More sharing options...
mgworek 121 Posted May 28, 2015 Share Posted May 28, 2015 Welcome to the dark side! I started my switch back in November and I deleted my Plex docker a couple of months ago. I couldn't be happier. Everyone is super friendly & helpful here. The admins actually look at the forums and respond. It reminds me of what Plex used to be many years ago. Link to comment Share on other sites More sharing options...
Luke 37066 Posted May 28, 2015 Share Posted May 28, 2015 how did we get to be the dark side? 3 Link to comment Share on other sites More sharing options...
mgworek 121 Posted May 28, 2015 Share Posted May 28, 2015 You're not. Isn't that the normal joke whenever you switch to something else / the other side, it's always the dark side? Or maybe its just the star wars geek in me.... Link to comment Share on other sites More sharing options...
Raff 51 Posted May 28, 2015 Share Posted May 28, 2015 how did we get to be the dark side? Maybe you have cookies? Back on topic, I never installed Plex, but it was in the running especially since they had the XB1 app. I started on the home media server path as a smaller piece of my larger home automation effort. As a result, Emby got installed because you had APIs - though that Java one needs some love. Link to comment Share on other sites More sharing options...
Luke 37066 Posted May 28, 2015 Share Posted May 28, 2015 Maybe you have cookies? Back on topic, I never installed Plex, but it was in the running especially since they had the XB1 app. I started on the home media server path as a smaller piece of my larger home automation effort. As a result, Emby got installed because you had APIs - though that Java one needs some love. what kind of love? the java lib is in pretty good shape. there's three apps using it now. Link to comment Share on other sites More sharing options...
Raff 51 Posted May 28, 2015 Share Posted May 28, 2015 I pulled revision 307, and it looks like there is a 310 but something is goofy with my sync so maybe these don't apply: 1. There were unnecessary imports, specifically some appeared to be left over from the Android app. I believe both the API Client and the Open Live Stream Request had them. Maybe others, but those were the only two I was playing with. I had to import Guava to build the jar file for the Files object, so maybe you are actually using the android jars to build if they include Google's helper libraries. 2. Almost always guilty of this myself - javadocs could use some updating. When I am reviewing an API I generate javadocs just after checkout. There is a lot of async calls, so, knowing what goes in the id String or what I should expect in the Response object makes me happy. Especially early in learning someone else's API I lean heavy on the Eclipse hover-to-show-docs. 3. This is going to be contentious, but in my mind, there are some code style issues. Most of them are minor (like * imports) but there are several methods that start with a capital letter, which would normally be reserved for classes. Most of them start with good verbs, but things like "Report" could be a noun or a verb, making the class vs. method distinction a little harder to understand when reading the source. But, this is veering OT - I really like all the APIs, it is what drew me to the project. We can take this discussion over to the dev forum or you can get me in touch with whoever "owns" that code (if not you) because I may have just volunteered to help... Dang you and your Open Source... Link to comment Share on other sites More sharing options...
Luke 37066 Posted May 28, 2015 Share Posted May 28, 2015 the caps is just because a lot of the code was generated from c# versions. i'm not necessarily going to manually change the current sigs but certainly going forward. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now