Jump to content

Why is the theme so anti css modifications? Why are you not adding unique css hooks to buttons?


cd01
Go to solution Solved by Happy2Play,

Recommended Posts

Hi,

 

The theme appears to have changed again, now the login page again shows "Manual Login" and "Reset Password".

 

I have no problem with the theme changing but it is annoying as hell that you keep coding the buttons without giving us actual css hooks to use to disable them or modify them.

 

The reset password button now has no unique selector, the only way to disable it is to :

 

div.card:nth-child(4) {display:none;} but this will obviously disable other buttons that are the 4th child somewhere else in emby.

 

why are buttons not coded with proper unique selectors so you can specify where the css goes easily? Why even include custom css if no hooks are being made in the theme?

 

class="card squareCard card-hoverable card-nofocustransform card-touchzoom card-withuserdata"

 

is not unique! This is _all_ the buttons on the login page, why not have something like

 

class="card squareCard card-hoverable card-nofocustransform card-touchzoom card-withuserdata reset-password"

 

giving us ability to hook up with only this button and make modifications to it?

Link to comment
Share on other sites

  • Solution
Happy2Play

Well the theme hasn't changed the html of the pages themselves has changed as they were forms before instead of actual pages.  The issue is these new pages do not have page ids, as discussed in the CSS forum.
 

/*Remove Manuallogin and Forgot Password from login.html*/
div[data-type="ManualLogin"], div[data-type="ForgotPassword"] {display: none;}


or

div.card[data-type="ManualLogin"], div.card[data-type="ForgotPassword"] {display: none;}

 
 
 

  • Like 1
Link to comment
Share on other sites

Hi.  This is an advanced feature that you have to understand both the limitations and the consequences of.  We do not wish to hold back improvements in the interface that 95%+ of users see in order to maintain every possible backward compatibility for the few who try to make these customizations.

 

Thanks.

Link to comment
Share on other sites

Well the theme hasn't changed the html of the pages themselves has changed as they were forms before instead of actual pages.  The issue is these new pages do not have page ids, as discussed in the CSS forum.

 

/*Remove Manuallogin and Forgot Password from login.html*/
div[data-type="ManualLogin"], div[data-type="ForgotPassword"] {display: none;}


or

div.card[data-type="ManualLogin"], div.card[data-type="ForgotPassword"] {display: none;}

 

 

 

that worked great, thanks, i need to get better at css!

 

Hi.  This is an advanced feature that you have to understand both the limitations and the consequences of.  We do not wish to hold back improvements in the interface that 95%+ of users see in order to maintain every possible backward compatibility for the few who try to make these customizations.

 

Thanks.

i understand, i wish emby was more costumizable though and i would wish that 99% of the focus was made on the web app, i really don't see the point in all the other apps as all modern hardware can use a browser you can just focus all your efforts at the webapp and all other are covered by the standard of browser/html5 or whatever, maintaining a million different apps for different platforms seems... not great.

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...