Jump to content

Plugin - Iconic Image Enhancer


Recommended Posts

GrimReaper
Just now, lundblad said:

Takes very long time for me, i dont know why..

Maybe because i have 4 rules? First i tried one rule with  "Property Value:  srt/subrip/pgsub/ASS/" but that did not work.


image.thumb.png.56d2accfda9123d2276ad3851d9ae053.png

You can make only one rule out of those, with Type:subtitle/DisplayTitle:Swe, that should cover all your different subtitle types. 

Link to post
Share on other sites
lundblad
2 minutes ago, GrimReaper76 said:

You can make only one rule out of those, with Type:subtitle/DisplayTitle:Swe, that should cover all your different subtitle types. 

thx for quick answer! Like this? I will try :)

image.thumb.png.68ee52b19253c6696b0e0d19d2443841.png

Link to post
Share on other sites
GrimReaper
9 minutes ago, lundblad said:

thx for quick answer! Like this? I will try :)

image.thumb.png.68ee52b19253c6696b0e0d19d2443841.png

That would mark items with either Swedish language and/or Swedish subtitles. For subtitled-ones only, you need to specify property TYPE. 

So, Add MediaStream rule, 1st Property Key: Type & Value: subtitle, 2nd Property Key: DisplayTitle & Value: Swe. 

Edited by GrimReaper76
Typos
Link to post
Share on other sites
lundblad
21 minutes ago, GrimReaper76 said:

That would mark items with either Swedish language and/or Swedish subtitles. For subtitled-ones only, you need to specify property TYPE. 

So, Add MediaStream rule, 1st Property Key: Type & Value: subtitle, 2nd Property Key: DisplayTitle & Value: Swe. 

Ok, Thank you so much for helping me :)image.thumb.png.c33fec5790c198df93e63061a5fd7d09.png
 

  • Like 1
Link to post
Share on other sites
roaku
1 hour ago, lundblad said:

Ok, now i have icons for swedish subtitles so it works, but damn library loading really slow. or maby just first time when makin the icons? 

It's just on the initial image generation. After that, the cache is used.

I've added some changes to make things more efficient about library querying that aren't in the betas but will be in the release, but the main bottleneck is the actual generating of the images by the system image library.

It just takes time to create a lot of images on the fly.

https://emby.media/community/index.php?/topic/94635-plugin-iconic-image-enhancer/&do=findComment&comment=979766

Edited by roaku
Link to post
Share on other sites
crusher11

How often does this refresh itself? I just replaced a DVD of one of my films with the Blu-ray version, which adds a commentary. But I don't see the Commentary icon on the poster.

 

Link to post
Share on other sites
roaku
6 hours ago, crusher11 said:

How often does this refresh itself? I just replaced a DVD of one of my films with the Blu-ray version, which adds a commentary. But I don't see the Commentary icon on the poster.

 

If the rule results changed for that item, the image should get regenerated the next time your app/browser requests that image.

Some of the client apps seem to do their own local caching, but a hard refresh on the web app of a page with that image on it works quickly.

If you want to regenerate all your images, regardless of whether anything's changed, you can re-save the configuration.

 

Edit: This turned out to be a bug in Iconic:

 

Edited by roaku
Reality check
Link to post
Share on other sites
roaku
6 minutes ago, crusher11 said:

Hard refresh? If you mean Ctrl-F5, it didn't work.

 

It's possible there's a bug, and it's also possible that your commentary rule isn't evaluating to true for that item.

Is this the only icon on that image? Because the betas will only repeat the icon of the first matched rule for additional badges on that image.

Edited by roaku
Link to post
Share on other sites
crusher11

The commentary rule is the only one I currently have set up.

Tried a different browser, nothing there either. Nor on my phone.

Link to post
Share on other sites
roaku
Just now, crusher11 said:

The commentary rule is the only one I currently have set up.

Tried a different browser, nothing there either. Nor on my phone.

Try deactivating the plugin, then refreshing the image.

Then reactivate and refresh again.

If that still doesn't work, then it's most likely that your rule isn't evaluating to true for some reason.

Link to post
Share on other sites
roaku
Just now, crusher11 said:

What do you mean by refreshing the image?

Easiest way is to use the web app to go to a page where the problem image is on the screen and refresh that page.

Link to post
Share on other sites
roaku
4 minutes ago, crusher11 said:

Yes. It's just Witness for the Prosecution that's the problem.

 

Screenshot 2021-02-18 02.00.17.png

Okay.

Can you deactivate the plugin again and make sure to save the configuration after?

Once that's done, refresh the page you just showed me and make sure all of the icons have disappeared.

Then, reactivate.

It might not fix anything, but it will rule out caching as the problem.

 

iconic-deactivate.png.0522a23a1f815856b0bfbb657b098579.png

 

Link to post
Share on other sites
crusher11

That's literally exactly what I just did. Deactivate, save, refresh. Icons all disappeared. Activate, save, refresh. All icons returned. Still no icon on WftP.

 

Link to post
Share on other sites
roaku

@crusher11

Playing with this a bit more, it looks like the 'latest movies' section might have its own caching layer on top of the enhanced-images one Iconic can purge.

Instead of refreshing from the home screen, try navigating into your Movies library and find that movie.

If that image isn't already updated with the icon, refresh that page, or click into that individual movie and refresh that page.

Hopefully, you'll see the icon for that movie now.

If so, go back to 'latest movies' and refresh the page for the thousandth time.

 

Edited by roaku
Link to post
Share on other sites
roaku
2 minutes ago, crusher11 said:

That's literally exactly what I just did. Deactivate, save, refresh. Icons all disappeared. Activate, save, refresh. All icons returned. Still no icon on WftP.

 

Thanks. I needed to make sure you saw the icons disappear from the other images.

Link to post
Share on other sites
roaku
7 minutes ago, crusher11 said:

No icon on the movies page, no icon on the item details page either.

Okay. That's my list of possibilities.

The only other thing I can think of is that because that movie already existed in your library and you swapped out the versions, some part of Emby is still sharing the outdated metadata with Iconic. But I'm just speculating.

If you're willing to go to the trouble, I can generate an Iconic build that will write out the rule analysis so we can see exactly what Iconic sees for that item.

Link to post
Share on other sites
crusher11

It's not showing up on my TV, either.

And I changed the poster art just before changing the video file, so the TV, phone, and alternate browser wouldn't have their own caches of the poster image at all. So unless it's cached by Emby itself, it can't be a caching thing.

 

Link to post
Share on other sites
roaku
19 minutes ago, crusher11 said:

It's not showing up on my TV, either.

And I changed the poster art just before changing the video file, so the TV, phone, and alternate browser wouldn't have their own caches of the poster image at all. So unless it's cached by Emby itself, it can't be a caching thing.

 

Ya, I think we've ruled out caching.

If you're willing, I've attached an Iconic build that will generate a log like the one below for the MediaStream rule analysis.

You *DO NOT* need to turn on Debug logging for this.

I'd also recommend navigating to the single item view for this movie and refreshing from there, so the log will only have an entry for that movie.

This should tell us what Iconic is seeing for that movie's MediaStream properties and whether or not something is strange there.

 

2021-02-17 13:13:15.293 Info App: Testing rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Checking MediaSources: 2
2021-02-17 13:13:15.293 Info App: Testing MediaStream property type for value audio
2021-02-17 13:13:15.293 Info App: MediaStream has property type
2021-02-17 13:13:15.293 Info App: MediaStream property type does not match value audio
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 0 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property title for value commentary
2021-02-17 13:13:15.293 Info App: MediaStream has property title
2021-02-17 13:13:15.293 Info App: MediaStream property title does not match value commentary
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 0 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property type for value audio
2021-02-17 13:13:15.293 Info App: MediaStream has property type
2021-02-17 13:13:15.293 Info App: MediaStream matched property type
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 1 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property title for value commentary
2021-02-17 13:13:15.293 Info App: MediaStream has property title
2021-02-17 13:13:15.293 Info App: MediaStream property title does not match value commentary
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 1 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property type for value audio
2021-02-17 13:13:15.293 Info App: MediaStream has property type
2021-02-17 13:13:15.293 Info App: MediaStream matched property type
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 1 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property title for value commentary
2021-02-17 13:13:15.293 Info App: MediaStream has property title
2021-02-17 13:13:15.293 Info App: MediaStream property title does not match value commentary
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 1 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property type for value audio
2021-02-17 13:13:15.293 Info App: MediaStream has property type
2021-02-17 13:13:15.293 Info App: MediaStream matched property type
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Skipping rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Only matched 1 properties out of required 2
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Testing MediaStream property title for value commentary
2021-02-17 13:13:15.293 Info App: MediaStream has property title
2021-02-17 13:13:15.293 Info App: MediaStream matched property title
2021-02-17 13:13:15.293 Info App: --------
2021-02-17 13:13:15.293 Info App: Adding Icon for rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: Testing complete for rule: New MediaStream Rule
2021-02-17 13:13:15.293 Info App: *******************

 

 

 

Edited by roaku
Removed attachment
Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...