Jump to content

Plugin - Iconic Image Enhancer


Recommended Posts

roaku

New Beta 0.9.2.0 is up.

This will be the last beta with any new features.

I'm now just trying to track down bugs and then get a 1.0.0 released.

 

  • Now supports separate badge and icon opacities
  • Tweaks to badge drawing to improve quality
  • Only draw badge border when the stroke is greater than 0
  • Only draw badge when opacity is greater than 0
  • Modularize javascript for maintainability and development efficiency.

 

 

Link to post
Share on other sites
GrimReaper
18 hours ago, crusher11 said:

Is there a way to rule in movies with different cuts, but rule out movies with different resolutions? I don't use "cut" every time in the name, unfortunately, but all my different-resolution stuff has its own folder. So any multi-version film, where all versions are in Movies and no versions are in 4K Movies, for example.

How do you differentiate between those cuts? How does Emby present them in the dropdown menu? Is there any other common denominator between them, not necessarily "cut"? 

Link to post
Share on other sites
crusher11

I mean, they all contain space-dash-space in the file name, and I don't think any films include that in their titles (I checked the M:I series and they're all "Mission Impossible Subtitle" in filename rather than "Mission: Impossible - Subtitle" as they are in the metadata). All 4K films are in the same folder and contain "4K" in their name, all 1080p versions of 4K films contain "1080p SDR" in their name (I have one 4K SDR film, which buggers up having all the 4Ks as "4K HDR").

But I think that's it.

 

Link to post
Share on other sites
GrimReaper
1 minute ago, crusher11 said:

I mean, they all contain space-dash-space in the file name, and I don't think any films include that in their titles (I checked the M:I series and they're all "Mission Impossible Subtitle" in filename rather than "Mission: Impossible - Subtitle" as they are in the metadata). All 4K films are in the same folder and contain "4K" in their name, all 1080p versions of 4K films contain "1080p SDR" in their name (I have one 4K SDR film, which buggers up having all the 4Ks as "4K HDR").

But I think that's it.

 

For 4K HDR you can use Type:video/DisplayTitle:4K HDR. Works for 4K HEVC in my case, DisplayTitle field supports multi-word entries as far as I've surmised. 

Link to post
Share on other sites
GrimReaper
Just now, crusher11 said:

Yes, but I'm trying to include multi-cut films while excluding multi-resolution films.

 

If I understood correctly, Emby displays "Mission: Imposible - Subtitle"? Or "Mission Impossible Subtitle"? 

Link to post
Share on other sites
crusher11

Emby displays "Mission: Impossible - Subtitle" but the filename is "Mission Impossible Subtitle".

 

Link to post
Share on other sites
GrimReaper
8 minutes ago, crusher11 said:

Emby displays "Mission: Impossible - Subtitle" but the filename is "Mission Impossible Subtitle".

 

Nvm filename, you can try using that "- " in DisplayTitle field with Type:video, that should work. But it'll mark any other single-version movie with dash, if you have any?

Edit: Or maybe few Rules, "- S" for Subtitles, "- D" for Director's cut, "- C" for Commentary and such? 

Or 26 rules for whole alphabet? 🤣

Edited by GrimReaper76
Afterthought
Link to post
Share on other sites
crusher11

I don't mean "Subtitle" literally, it was a placeholder. ie the actual titles are "Mission: Impossible - Ghost Protocol", "Mission: Impossible - Fallout", etc.

 

Link to post
Share on other sites
GrimReaper
8 minutes ago, crusher11 said:

I don't mean "Subtitle" literally, it was a placeholder. ie the actual titles are "Mission: Impossible - Ghost Protocol", "Mission: Impossible - Fallout", etc.

 

Guess we misunderstood each other. I understand those are items in your Library, but I was asking how do you differentiate between versions of that same movie, once in detail screen, how does Emby show those? 

Edit: To put things in perspective, I thought Mission:Impossible - Subtitle is alternate cut of your original Mission:Impossible movie, listed in drop-down menu. 

Edited by GrimReaper76
Link to post
Share on other sites
GrimReaper

OK, grabbed few minutes to do some tests (note that all my multi-versions have one of the common suffixes: - extended, - directors cut, - alternate ending and such, alltogether maybe 5 in total, not knowing your method it might differ): Filename rule with " - " (space-dash-space) correctly iconized all my multi-version movies and several single-versions that have that same expression in filename. Making 5 rules instead, with " - e", " - d", " - a", " - c" and " - o", resulted in literally ONE extra single movie being iconized, quick rename of that one, rescan and voila, only multi-versions iconized. Handy, at that, thanks for the tip. 👍

Edited by GrimReaper76
Typo
Link to post
Share on other sites

Hola @roaku

En primer lugar, te felicito por este gran complemento, ¡es genial!

Pero tengo un par de problemas que no puedo resolver y me gustaría que me ayudaras.

1º Utilizo otro gran complemento llamado Auto Movie Version Grouping, que agrupa las películas en una sola con diferentes versiones de calidad.
Quería usar el icónico para determinar en una película el tipo de calidad que tienen, 4K, BDrip, FullBD, doblyvision, etc.

Hago esto como una regla de nombre de archivo. 
El problema es que si una película, por ejemplo, cumple la regla de 4K, BDrip y BDremux, repite el ícono por 3 del primer video que cumple con la regla ...

Me imagino que al ser una beta, esto aún no se habrá detectado, pero sería genial poder complementarlo con la Agrupación automática de versiones de películas y así saber en cualidades que tiene esta película y no repetir la interfaz emby con 4 o 5 tipos de biblioteca.

Captura-de-pantalla-2021-02-10-120053.jp

Captura-iconic.jpg

El 2do, podría agregar mis íconos personalizados ... como expliqué anteriormente tengo varias calidades, sé que está el ícono de 4K, pero quiero agregar el ícono para los diferentes tipos de calidades, 4Kmicro, Dobly Visio, Bdrip 1080p , Micro 1080, etc, etc ...
¿Sería posible que cada usuario tuviera una carpeta donde alojar sus iconos?

Gracias de nuevo por este gran complemento.
Saludos

 

Edited by moha85
add images
Link to post
Share on other sites
roaku
3 hours ago, moha85 said:

Hola @roaku

En primer lugar, te felicito por este gran complemento, ¡es genial!

Pero tengo un par de problemas que no puedo resolver y me gustaría que me ayudaras.

1º Utilizo otro gran complemento llamado Auto Movie Version Grouping, que agrupa las películas en una sola con diferentes versiones de calidad.
Quería usar el icónico para determinar en una película el tipo de calidad que tienen, 4K, BDrip, FullBD, doblyvision, etc.

Hago esto como una regla de nombre de archivo. 
El problema es que si una película, por ejemplo, cumple la regla de 4K, BDrip y BDremux, repite el ícono por 3 del primer video que cumple con la regla ...

Me imagino que al ser una beta, esto aún no se habrá detectado, pero sería genial poder complementarlo con la Agrupación automática de versiones de películas y así saber en cualidades que tiene esta película y no repetir la interfaz emby con 4 o 5 tipos de biblioteca.

 

Hola @moha85

And thank you for trying out Iconic.

I think the issue that you are seeing is an intentional restriction of the beta releases. The betas will use the icon from the first rule that matches for a movie and repeat it for the rest of the matches for that movie.

The release version will not have this restriction. The icon you configure for each rule will be used when that rule matches for a movie.


 

Quote

 

El 2do, podría agregar mis íconos personalizados ... como expliqué anteriormente tengo varias calidades, sé que está el ícono de 4K, pero quiero agregar el ícono para los diferentes tipos de calidades, 4Kmicro, Dobly Visio, Bdrip 1080p , Micro 1080, etc, etc ...
¿Sería posible que cada usuario tuviera una carpeta donde alojar sus iconos?

Gracias de nuevo por este gran complemento.
Saludos

 

Right now, custom images are not available.

In fact, Iconic doesn't use images at all. The badges are drawn programatically, and the icons come from a font set.

But I am thinking about ways to provide more customization options.

 

Thanks again for trying out the plugin.

Link to post
Share on other sites
crusher11
5 hours ago, GrimReaper76 said:

Guess we misunderstood each other. I understand those are items in your Library, but I was asking how do you differentiate between versions of that same movie, once in detail screen, how does Emby show those? 

Edit: To put things in perspective, I thought Mission:Impossible - Subtitle is alternate cut of your original Mission:Impossible movie, listed in drop-down menu. 

No, I only mentioned them because they were the only films I could think of that might have been picked up by a space-dash-space search that weren't actually multi version. 

Link to post
Share on other sites
GrimReaper
5 minutes ago, crusher11 said:

No, I only mentioned them because they were the only films I could think of that might have been picked up by a space-dash-space search that weren't actually multi version. 

Well, as I mentioned above, Filename search on space-dash-space gave too broad of a result in MY library, as I obviously have a number of filenames containing that expression, but narrowing it down through several specific-letter targeted rules worked quite well, had to rename only one single item, and, as far as I can tell at a first glance, looks ok from my side. Maybe rename those few dubious items? 

Link to post
Share on other sites
crusher11
15 hours ago, GrimReaper76 said:

Well, as I mentioned above, Filename search on space-dash-space gave too broad of a result in MY library, as I obviously have a number of filenames containing that expression, but narrowing it down through several specific-letter targeted rules worked quite well, had to rename only one single item, and, as far as I can tell at a first glance, looks ok from my side. Maybe rename those few dubious items? 

Going by filename, as far as I know it shouldn't throw any false positives except for my 4K movies, which I want to exclude. Which is my point.

RegEx on the filename would make this super easy. Negative matching might be able to do it. But I don't think it can be done without one of those.

Link to post
Share on other sites
GrimReaper
33 minutes ago, crusher11 said:

Going by filename, as far as I know it shouldn't throw any false positives except for my 4K movies, which I want to exclude. Which is my point.

RegEx on the filename would make this super easy. Negative matching might be able to do it. But I don't think it can be done without one of those.

As a temporary workaround, you could create 2 rules: first for 4K, second for Multi-version. That way your 4K movies would have 2 badges, 4K and Multi, and different cut ones only one, Multi, making it easy to discern between them? Which, come to think of it, is actually correct, for Multi-version to encompass both multi-resolution and multi-edition? 

Link to post
Share on other sites
crusher11

But I don't want it to encompass both multi-resolution and multi-edition, that's my point. Nor do I want the clutter of an extra 4K badge.

@roaku any chance of getting RegEx put in?

 

Link to post
Share on other sites
GrimReaper
7 minutes ago, crusher11 said:

But I don't want it to encompass both multi-resolution and multi-edition, that's my point. Nor do I want the clutter of an extra 4K badge.

@roaku any chance of getting RegEx put in?

 

Some of my items have 8 badges on them. 🤭😂

Edit: And I don't think I'm through, yet. 🙄

Edited by GrimReaper76
Link to post
Share on other sites
18 hours ago, roaku said:

Hola @moha85

And thank you for trying out Iconic.

I think the issue that you are seeing is an intentional restriction of the beta releases. The betas will use the icon from the first rule that matches for a movie and repeat it for the rest of the matches for that movie.

The release version will not have this restriction. The icon you configure for each rule will be used when that rule matches for a movie.

 

Hello again @roaku


I think the previous thread was written in Spanish, I don't know why.... But well it doesn't matter, that's what the translator is for it 😂

First of all I would like to thank you again for the replies and listen to the community.

Returning to the topic, when do you think version 1.0 will be ready and you will be able to enjoy what you have talked about?

 

18 hours ago, roaku said:

Right now, custom images are not available.

In fact, Iconic doesn't use images at all. The badges are drawn programatically, and the icons come from a font set.

But I am thinking about ways to provide more customization options.

 

Thanks again for trying out the plugin.

And secondly, I would like to contribute something to the project with custom icons of the different types of video qualities, for the community and me to enjoy :)

Thanks again

  • Like 1
Link to post
Share on other sites

Hi, this is a wonderful looking plugin @roaku! I'm super excited to implement it in my server!

I'm very eagerly awaiting the TV show functionality addition as I have a LOT of anime but only maybe a third of it is Dual Audio (partner and their friend HATES subtitles with a passion meanwhile I find dubbed anime... not all that appealing more often than not and much prefer JPN audio).
With my Dual Audio anime, it's kind of 50/50 whether or not English is the default audio track and most of my friends / emby users are in the same camp as me, not a fan of dubbed anime but they also don't really pay attention to the fact that it's actually Dual Audio and also rarely visit the actual episode info page so don't notice the track selection.. And are also apparently blind to the audio track selection while something is playing.. lol

Anyway! My use case is less about showing an icon per audio track such as commentary or whatever, my plan was to use this to have an icon shown for if the episode/movie has more than one audio language track.

Now my dilemma comes from my renaming tool not always detecting the audio tracks properly for different reasons but normally I would have any Dual Audio content have [JA+EN] added to the filename. As an example: Violet Evergarden - Eternity and the Auto Memory Doll (2019) [x265][Bluray-1080p][2.0][EN+JA].mkv
Having a filename rule works great!... With.... the stuff that gets named properly. Also depending on the audio track order or other languages it could be like [CN+EN+JPN+SPN] etc etc so it's difficult to cover all instances. So far I'm just using 2 filename rules of [EN+JA]/[JA+EN] which covers maybe half my movies but I know majority of my anime collection won't be so simple

Any chance of a rule that's something along the lines of "if 2 or more audio track languages exist then true"?
Or I guess I could work with regex in this instance too so a +1 to that also from me

Thanks for your work on this plugin, I appreciate you ♥

Link to post
Share on other sites
GrimReaper
9 minutes ago, diogee said:

Hi, this is a wonderful looking plugin @roaku! I'm super excited to implement it in my server!

I'm very eagerly awaiting the TV show functionality addition as I have a LOT of anime but only maybe a third of it is Dual Audio (partner and their friend HATES subtitles with a passion meanwhile I find dubbed anime... not all that appealing more often than not and much prefer JPN audio).
With my Dual Audio anime, it's kind of 50/50 whether or not English is the default audio track and most of my friends / emby users are in the same camp as me, not a fan of dubbed anime but they also don't really pay attention to the fact that it's actually Dual Audio and also rarely visit the actual episode info page so don't notice the track selection.. And are also apparently blind to the audio track selection while something is playing.. lol

Anyway! My use case is less about showing an icon per audio track such as commentary or whatever, my plan was to use this to have an icon shown for if the episode/movie has more than one audio language track.

Now my dilemma comes from my renaming tool not always detecting the audio tracks properly for different reasons but normally I would have any Dual Audio content have [JA+EN] added to the filename. As an example: Violet Evergarden - Eternity and the Auto Memory Doll (2019) [x265][Bluray-1080p][2.0][EN+JA].mkv
Having a filename rule works great!... With.... the stuff that gets named properly. Also depending on the audio track order or other languages it could be like [CN+EN+JPN+SPN] etc etc so it's difficult to cover all instances. So far I'm just using 2 filename rules of [EN+JA]/[JA+EN] which covers maybe half my movies but I know majority of my anime collection won't be so simple

Any chance of a rule that's something along the lines of "if 2 or more audio track languages exist then true"?
Or I guess I could work with regex in this instance too so a +1 to that also from me

Thanks for your work on this plugin, I appreciate you ♥

Do all your files have japanese language and some have english dub OR they all have english with some having japanese original? Are you trying to identify ones that have English as additional track? 

Link to post
Share on other sites

I'd say about 200 out of the 1400 animated series I have are English only
Probably around 100 are a mix of Korean or Chinese audio only

The remaining 1100 or so all contain Japanese audio
Of that 1100, if I had to guess, somewhere around 300 of those contain English audio in addition to the Japanese audio
But not all 300 series has both english and japanese for every season. Uhh as an example off the top of my head, Attack On Titan? Still currently airing new episodes so Season 1 through to 3 contain Dual Audio but current season is Japanese only
Maybe about 70 out of the 1100 contain 3 or more audio track languages

So my goal would be not trying to identify if it has English, I'm specifically trying to identify if it has quite literally, 2 or more audio languages. Not so much WHICH 2 languages, just that it HAS 2 or more languages.
If that makes any more sense?

Edited by diogee
Wording
Link to post
Share on other sites
GrimReaper

@roaku, further to above, made some tests and the internal logic breaks somewhere, details below:

Setup is:

Movie A - Japanese/English audio, Japanese/English subs

Movie B - Japanese audio, English subs

Test 1: MediaStream rule with DisplayLanguage:Jap (no Type property, assuming both audio and subs will be evaluated in that case) 

Movie A iconized (Japanese audio, Japanese subs - don't know which one was argument=true) 

Movie B iconized (Japanese audio) 

Test 2: MediaStream rule with DisplayTitle:Jap

Movie A iconized (same as above) 

Movie B iconized (same as above) 

Test 3: MediaStream rule with DisplayLanguage:Eng

Movie A iconized (English audio, English subs - don't know which one was argument=true) 

Movie B iconized (English subs)

So, the assumption that it's type-independent looks correct. 

Test 4: MediaStream rule with DisplayTitle:Eng

Movie A iconized (same as above) 

Movie B iconized (same as above) 

Again, confirmation that evaluation is type-independent. 

Following all above, with all 4 MediaStream rules iconizing BOTH movies as conditions being true, Test 5 was done with:

2-properties MediaStream rule:

DisplayLanguage:Jap

DisplayTitle:Eng

However, that produced no result and neither movie being iconized, although based on the previous test ALL conditions were true and with AND operator between properties, BOTH movies should've been iconized again. 

My intention was to introduce third property, as Type:audio (which I did, btw, Test 6 was MediaStream rule with: Type:Audio/DisplayLanguage:Jap/DisplayTitle:Eng - didn't work, of course, since it broke down already in the less complex test previously; to clarify, first I wanted to ensure that DisplayLanguage and DisplayTitle can coexist as properties inside a single rule, later restricting it to only Audio stream, hence resulting in only Movie A being iconized.) 

Hope you could follow. 

Cheers

 

 

 

Edited by GrimReaper76
Append
Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...