Jump to content

Reports Plugin not woking

Smaky

By Smaky
in Plugins

 Share

Recommended Posts

Carlo Emby Team

Carlo   4330

Posted
Posted

Looks like it.

I don't have VS installed at the moment.  Let us know what you find @chef

If you don't see anything right away try changing the GUID for a quick test.

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)

First thing first, guys, I'm going to remove all the JQuery from the plugin. 

It looks like the entire JQuery source is pasted into the code.

Please speak up, if anyone (the dev who wrote it) has an issue with this.

I'm going to write the existing plugin code in vanilla JS (like the rest of the plugin on Github), and make sure that it is following the guidelines of plugin development.

There is nothing wrong with the JQuery, but form my experience we should be using Vanilla JS for Emby plugin development.

We should all really try and keep a consistent product both in the UI and what is happening behind.

this might take a moment or two to get it done.

 

Edited by chef
Link to comment
Share on other sites
Carlo Emby Team

Carlo   4330

Posted
Posted
7 minutes ago, chef said:

this might take a moment or two to get it done.

Dang, you're fast.  LOL

chef, we appreciate this very much!

  • Like 1
Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)

Here is the fixed version of Reports Plugin.

It is working now for me. Lemme know how I can help out to fix any issues :)

Note: After you install this, clear browsing data to load the new JS into the cache.

 

 

EmbyReports.zip

Edited by chef
  • Thanks 1
Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted

@Luke how will this update be handled?

@chef saw a few quirks until I cleared my browser cache as instructed above.

Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted (edited)

@chef It looks like the three dot menu is loaded before the table when clicking Reports, then 3 dot menu is not accessible.  Also when there is not items the three dot menu is displayed over the table.

Opening transition

transition.thumb.jpg.758c0e2fdaecfb5e5996533419f1a208.jpg

 

then table loads but 3 dot menu is not accessible

transition2jpg.thumb.jpg.80a90540e978e99a5884ba8116a61659.jpg

If table contains no items menu appears on table

1096887607_notable.thumb.jpg.64339f1dc76e0c0e9e1f5aa33756a6a9.jpg

 

Will have to look a previous version but get these console errors. (these console errors apply to old and new versions.) 

apiclient.js?v=4.5.0.21:1 GET http://localhost:8096/emby/Items/Filters?UserId=954310eedbf54c14b743e61b34746e82&IncludeItemTypes=Movie&ReportView=ReportData&X-Emby-Client=Emby%20Web&X-Emby-Device-Name=Chrome&X-Emby-Device-Id=3ba97415-e61b-4d16-8b0c-44549f395391&X-Emby-Client-Version=4.5.0.21&X-Emby-Token=db18c3dffe614765b51c2d32395fa24c 404 (Not Found)
getFetchPromise @ apiclient.js?v=4.5.0.21:1
value @ apiclient.js?v=4.5.0.21:1
value @ apiclient.js?v=4.5.0.21:1
loadFilters @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1842
reloadFiltersIfNeeded @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1659
(anonymous) @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1919
dispatch @ jquery.slim.min.js?v=4.5.0.21:2
v.handle @ jquery.slim.min.js?v=4.5.0.21:2
trigger @ jquery.slim.min.js?v=4.5.0.21:2
(anonymous) @ jquery.slim.min.js?v=4.5.0.21:2
each @ jquery.slim.min.js?v=4.5.0.21:2
each @ jquery.slim.min.js?v=4.5.0.21:2
trigger @ jquery.slim.min.js?v=4.5.0.21:2
(anonymous) @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:2248
onViewChange @ viewmanager.js?v=4.5.0.21:1
(anonymous) @ viewmanager.js?v=4.5.0.21:1
Promise.then (async)
ViewManager.loadView @ viewmanager.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
Promise.then (async)
loadContentUrl @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
onInitComplete @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
Promise.then (async)
(anonymous) @ router.js?v=4.5.0.21:1
handleRoute @ router.js?v=4.5.0.21:1
page.dispatch @ page.js?v=4.5.0.21:1
page.show @ page.js?v=4.5.0.21:1
page.handleAnchorClick @ page.js?v=4.5.0.21:1
onAnchorClick @ emby-button.js?v=4.5.0.21:1
index.html#!/configurationpage?name=ReportPluginConfiguration:1 Uncaught (in promise) Response {type: "basic", url: "http://localhost:8096/emby/Items/Filters?UserId=95….21&X-Emby-Token=db18c3dffe614765b51c2d32395fa24c", redirected: false, status: 404, ok: false, …}
Promise.then (async)
loadFilters @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1850
reloadFiltersIfNeeded @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1659
(anonymous) @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:1919
dispatch @ jquery.slim.min.js?v=4.5.0.21:2
v.handle @ jquery.slim.min.js?v=4.5.0.21:2
trigger @ jquery.slim.min.js?v=4.5.0.21:2
(anonymous) @ jquery.slim.min.js?v=4.5.0.21:2
each @ jquery.slim.min.js?v=4.5.0.21:2
each @ jquery.slim.min.js?v=4.5.0.21:2
trigger @ jquery.slim.min.js?v=4.5.0.21:2
(anonymous) @ configurationpage?name=ReportPluginConfigurationJS&v=4.5.0.21:2248
onViewChange @ viewmanager.js?v=4.5.0.21:1
(anonymous) @ viewmanager.js?v=4.5.0.21:1
Promise.then (async)
ViewManager.loadView @ viewmanager.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
Promise.then (async)
loadContentUrl @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
onInitComplete @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
(anonymous) @ router.js?v=4.5.0.21:1
Promise.then (async)
(anonymous) @ router.js?v=4.5.0.21:1
handleRoute @ router.js?v=4.5.0.21:1
page.dispatch @ page.js?v=4.5.0.21:1
page.show @ page.js?v=4.5.0.21:1
page.handleAnchorClick @ page.js?v=4.5.0.21:1
onAnchorClick @ emby-button.js?v=4.5.0.21:1

 

**Also if you leave and return to Reports, you return to where every you where last versus defaulting to Movies as it previously dids.

Edited by Happy2Play
update on console errors
Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted

Another Update to above: the 3 dot menu is always open at the bottom of the table, so no table has it open on screen.  So the 3 dot menu buttion does nothing now with it always presented.

 

reports1.thumb.jpg.c63f5493d135e7fb8fed600d3a1bed15.jpg

 

Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted

@cayars just to confirm, are you seeing this same behavior.  All the options still work but are somewhat a pain as they jump back to the top with every option selected.

Link to comment
Share on other sites
Carlo Emby Team

Carlo   4330

Posted
Posted
3 minutes ago, Happy2Play said:

@cayars just to confirm, are you seeing this same behavior.  All the options still work but are somewhat a pain as they jump back to the top with every option selected.

I'm getting something similar but find it very difficult to switch between some media types.  For example right now I can't "reset" to view movies again after looking at trailers.

I get the same 3 dot menu functionality at the bottom.

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)

@Happy2Play @cayars (I think I'll @Luke here too)

 

The reports plugin had an enormous over-head of code. Was that the entire JQuery library??

When I quick fixed it last night I realized that in order to get it working properly it had to be refactored.

 I have spent the day re-working the entire thing. I stripped out all the JQuery and refactored the code to use Vanilla JS.

There are a few things that I want to make sure are working perfect with this plugin, because the whole is is quite amazing. the back-end code is written very well. But the front-end needed updating. I can see that Luke was maintaining it on Git, but probably to busy to update the whole thing.

I'll post some pictures of it working now:

 

reports1.png

reports2.png

 

I think this is better. Right?

Edited by chef
Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted (edited)

@chef it functioned properly without the Movie Themes Videos plugin installed, so wouldn't that just be some sort of conflict in the two plugins?

Edited by Happy2Play
Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)
26 minutes ago, Happy2Play said:

@chef it functioned properly without the Movie Themes Videos plugin installed, so wouldn't that just be some sort of conflict in the two plugins?

Maybe, but even in the backend code I couldn't see why there would be an issue between to the two plugins. 

I changed up the pluginIds to see if maybe (for some weird reason) they were trying to the load the same Id, but that wasn't it.

 

Once I reworked the project into proper Plug-In Namespace structure, updated the Plugin Class, and the .csproj file with the latest Server dependency version, the thing started loading fine.

But, I would also say that it is the JQuery which was causing some loading issues as well. 

 

Edited by chef
Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)

@Happy2Play @cayars

This version of the reports plugin is still very preliminary. 

All the filter options are currently enabled (meaning clickable) dispite the media type value (movie, episode), but will only act upon the media type they are coupled with.

Example: "Is Missing Episodes" will only work with Media Type Episode, and not with movie, even if it is enable.

What is it missing that you notice right away? (besides a lot maybe even).

I know that currently grouping is a bit strange.

You'd probably want to copy the old version somewhere safe if you guys decide to try this out, and empty the browser cache.

 

 

 

Edited by chef
Link to comment
Share on other sites
chef

chef   3745

Posted
Posted (edited)

If you load the entire jQuery library into the UI twice, would it cause issues?

Maybe the movie theme plugin also loads the entire jQuery library too since it is no longer hosted inside emby web app and dashboard?

Edited by chef
Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted

Anyone that had the original problem with the Plugin still having it with Reports plugin v1.0.40.0?

 

 

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted
27 minutes ago, Happy2Play said:

Anyone that had the original problem with the Plugin still having it with Reports plugin v1.0.40.0?

 

 

Are you seeing issues still?

It seemed to work here.

Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted
3 minutes ago, chef said:

Are you seeing issues still?

It seemed to work here.

Yes everything appears to work except the outstanding issue with Artists that hasn't been fixed since Artists query changed a long time ago (reported in Jan 2019).

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted
2 minutes ago, Happy2Play said:

Yes everything appears to work except the outstanding issue with Artists that hasn't been fixed since Artists query changed a long time ago (reported in Jan 2019).

Okay let me see what I can do

  • Thanks 1
Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted
Just now, chef said:

Okay let me see what I can do

I know softworkz looked at it back then and got Albums working but never go Artists working.

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted

@Happy2Play I don't use emby for music, so you'll have to help me understand something.

 

What is the difference between "Audio.AlbumArtists" and "Audio.Artists"?

Both are string arrays.

I think I found out why Artists is broken.

Link to comment
Share on other sites
Happy2Play

Happy2Play   8237

Posted
Posted
2 minutes ago, chef said:

@Happy2Play I don't use emby for music, so you'll have to help me understand something.

 

What is the difference between "Audio.AlbumArtists" and "Audio.Artists"?

Both are string arrays.

I think I found out why Artists is broken.

I honestly don't know I just know this actually broke when we went for 3.5 to v4 and I reported it. 🙂

Link to comment
Share on other sites
chef

chef   3745

Posted
Posted
Just now, Happy2Play said:

I honestly don't know I just know this actually broke when we went for 3.5 to v4 and I reported it. 🙂

Okay, so it sounds like using "AlbumArtists" could be legacy API.

I'll be right back!

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...