NextPVR v5 Emby plugin

[emveepee 112]

Ok a new episode of Prodigal Son was added last night and it is there but the missing Prodigal Son and Evil episodes are still not showing up.  They both continue to show up under NextPVR recordings

 

Martin

 

 

[Luke 37060]

When the channel returns lists of items, is the Id you're setting guaranteed to be unique?

https://github.com/MediaBrowser/NextPVR/blob/master/MediaBrowser.Plugins.NextPvr/RecordingsChannel.cs#L258

[emveepee 112]

Yes each row in the NextPVR table has a unique id and it seems to reported ok

sqlite> select * from ( select seriesname, name, externalid, path, premieredate, datecreated, datelastrefreshed from mediaitems where type = 8 order by datecreated desc limit 10);
 
Prodigal Son|The Trip|21915|http://172.16.3.105:8866/live?recording=21915|1571616000|1571706000|1571761599
Blue Bloods|Another Look|21905|http://172.16.3.105:8866/live?recording=21905|1571356800|1571450340|1571517473
Evil|Rose390|21867|http://172.16.3.105:8866/live?recording=21867|1571270400|1571363940|1571517486
Evil|3 Stars|21825|http://172.16.3.105:8866/live?recording=21825|1570665600|1571194740|1571517483
Emergence|No Outlet|21848|http://172.16.3.105:8866/live?recording=21848|1571097600|1571191141|1571517473
Prodigal Son|Designer Complicity|21845|http://172.16.3.105:8866/live?recording=21845|1571011200|1571112000|1571517443
Evil|3 Stars|21821|http://172.16.3.105:8866/live?recording=21821|1570665600|1570769940|1571593529
Law & Order: Special Victims Unit|Down Low in Hell's Kitchen|21822|http://172.16.3.105:8866/live?recording=21822|1570665600|1570762071|1571517441
Evil|3 Stars|21818|http://172.16.3.105:8866/live?recording=21818|1570665600|1570761339|1571593529
Les Simpson|Homer va à la FAC|21760|http://172.16.3.105:8866/live?recording=21760|750556800|1570567349|1571517441

Martin

Edited October 22, 2019 by emveepee

[Luke 37060]

Hmm. Would the "old" next pvr plugin still work with nextpvr v5? If so can you install that to see if it has the same issue? Thanks.

[emveepee 112]

No it won't the API was completely removed.  There is a field called PresentationUniqueKey that is not unique how is that one formed?  It looks like just Season Episode number

 

Martin

Edited October 23, 2019 by emveepee

[Luke 37060]

For an episode that would be based on the combination of series id, season number + episode number. So it's possible they are getting grouped together as multi-version. If you click on one, can you select from the two versions? This hasn't been tested with channel plugin content so I'm not positive it will work.

[emveepee 112]

We are closer, there is no series id in there which could be part of the problem.   When I click on Evil I do see three versions of the one episode.  When I click on Emergence I see 3 versions two are the missing episodes that don't belong to Emergence and the proper episode name shows up.    They all are "-001 - 004" for the unique key and I can play them but the all say Emergence 1 4 on the main screen and player

 

Martin

Edited October 23, 2019 by emveepee

[emveepee 112]

O k there is a button on Emergence to split episodes, I did that and Prodigal Son appeared.  Then I went in Emergence again and could split it and Evil appeared.

 

After the split the missing rows have a guid for a unique key  There is a seriesid field in the database and it is blank, but I don't see any way to populate it via the ChannelItemInfo

 

Martin

Edited October 23, 2019 by emveepee

[Luke 37060]

So for series you have to first send because a series folder, and then the episodes under that. I'm still surprised they got grouped in the first place without a series. I'll have to see what happened there. You may just want to leave it as is and I'll just make sure they don't get grouped.

[emveepee 112]

Don't worry this is dev only and I can easily delete the library.db to recreate the problem.  Perhaps move the posts back to #121 to  here https://emby.media/community/index.php?/topic/73609-new-plugin-for-nextpvr/ I thought it was something I am doing wrong

 

I compared with MP and I don't fill out OriginalTitle could that be an issue?

 

Martin

Edited October 24, 2019 by emveepee

[Luke 37060]

No, no problem with that.

[emveepee 112]

I realized that recordings for v5 and v4 are similar and used my v5 database with v4 and the behavior is not the same at all, perhaps because the v4 addon is not using season and episode numbers.  The v4 sortname is the episode name and the PresentationUniqueKey is a guid.   The change in v5 channels include

                IndexNumber = item.EpisodeNumber,
                ParentIndexNumber = item.SeasonNumber,

The new v5 server with the new addon are much improved visually and speed wise.

 

Martin

Edited October 24, 2019 by emveepee

[pünktchen 1258]

@@emveepee your problems are not new: https://emby.media/community/index.php?/topic/72498-live-tv-plugin-recording-channel-creates-multiple-versions-for-episode-items/

[emveepee 112]

Thanks @pünktchen that is exactly what I am seeing now.  It isn't clear from your post that Killljoys Boondoogie S3E1 was also missing from the Emby recording list but it sure sounds the same.

 

Martin

[pünktchen 1258]

Thanks @pünktchen that is exactly what I am seeing now. It isn't clear from your post that Killljoys Boondoogie S3E1 was also missing from the Emby recording list but it sure sounds the same.

 

Martin

I've never checked recordings under live tv...

I think the problem is Emby expects episodes to be in a season folder, not a general folder.

But if i use ChannelFolderType.Season then i get no episode recordings at all. This is another bug i've also reported here:

https://emby.media/community/index.php?/topic/72827-recording-channel-of-live-tv-plugins-multiple-problems/ although the bug exists already much longer.

[emveepee 112]

It is all likely related to the fact that  plugins use the pseudo series_md5(name) logic and that gets confused when series/episodes are added.  When I change the code to add S/E in front of the episode name and also don't provide the s/e info I get each single recording. 

 

Martin

Edited October 24, 2019 by emveepee

[emveepee 112]

Luke any thoughts on this?  If I have to turn off the support for S/E and fake it I will, but if I can avoid having to do that I feel that is better.

 

Martin

[Luke 37060]

I've never checked recordings under live tv...

I think the problem is Emby expects episodes to be in a season folder, not a general folder.

But if i use ChannelFolderType.Season then i get no episode recordings at all. This is another bug i've also reported here:

https://emby.media/community/index.php?/topic/72827-recording-channel-of-live-tv-plugins-multiple-problems/ although the bug exists already much longer.

 

It's never setting the SeasonId internally, that could be why. I'll fix that for the next beta update.

[emveepee 112]

What about with shows that don't have a season/episode numbers?  I just noticed I am getting two entries for each of these for World Series recordings this past week.  I do still follow this https://emby.media/community/index.php?/topic/21264-series-record-ability-missing-in-emby-epg/&do=findComment&comment=239633 and set isSeries to true but the values of season/episode should be nulls.

 

Martin

[pünktchen 1258]

Provided we can use now ChannelItemType.Series and ChannelItemType.Season with season and episode numbers then only use this when your recordings have those numbers. Otherwise just group them with ChannelItemType.Folder. and set them to ChannelMediaContentType.Clip.

[Luke 37060]

It shouldn't matter whether they have episode numbers, but yes they would need at least season numbers.

[emveepee 112]

Provided we can use now ChannelItemType.Series and ChannelItemType.Season with season and episode numbers then only use this when your recordings have those numbers. Otherwise just group them with ChannelItemType.Folder. and set them to ChannelMediaContentType.Clip.

Thanks that solved the problem with the duplicates.    I am wondering in the MP code there is this https://github.com/MediaBrowser/MediaPortalTVPlugin/blob/master/MediaBrowser.Plugins.MediaPortal/RecordingChannel.cs#L429 which is similar to NextPVR code.  Should that be changed to series?

 

Martin

[pünktchen 1258]

Thanks that solved the problem with the duplicates. I am wondering in the MP code there is this https://github.com/MediaBrowser/MediaPortalTVPlugin/blob/master/MediaBrowser.Plugins.MediaPortal/RecordingChannel.cs#L429 which is similar to NextPVR code. Should that be changed to series?

 

Martin

If it's working now with new Emby beta, then yes.

I can't remember if it's ItemType or FolderType that holds the Series and Season property.

Anyway the MediaPortal code needs really some updates, but i'm too lazy. And as long as nobody complains, there's no need for me to solve problems.

[pünktchen 1258]

It's never setting the SeasonId internally, that could be why. I'll fix that for the next beta update.

Emby beta 4.3.0.19:

ChannelFolderType.Series
|__ChannelFolderType.Season
   |__ChannelMediaContentType.Episode

-> Ends up with empty season folders

ChannelFolderType.Series
|__ChannelMediaContentType.Episode

-> Ends up with empty series folders after a library scan

 

What's really scary is that Emby creates virtual season folders and deletes them right after that and also calls the recording delete method of the live tvplugin to do this!!!

embyserver-63708506040.txt

[Luke 37060]

yea I apologize but I've just never gone through implementing this with channel plugins. The existing next pvr plugin just sends back a flat list of recordings, and I realize it's not as feature rich, but it does work and allow you to play your recordings. I will look at supporting these more complex structures when I can.