Jump to content

Genre cleaner


arrbee99

Recommended Posts

arrbee99

Does anyone know how to get rid of duplicates like this -

 

5cfecff69041e_EmbyGenresduplicates.jpg

 

I already have Genre Cleaner installed and ran a Start Library Scan but they were there before and after.

 

For Animation and Comedy theres nothing mapped but for Science fiction there already is - 

 

5cfed10571e70_EmbyGenresduplicates1.jpg

 

5cfed1177b4b5_EmbyGenresduplicates2.jpg

 

How and where do I find those extra genres in the plugin to map them to existing ones ?

Link to comment
Share on other sites

arrbee99

@@Happy2Play

I know its going to be aggravatingly obvious but I don't see how to. If I click on that Map to button above I hope / expect it to somewhere show, say, Comedy / Comedy so I can map it to Comedy but nothing shows up.

Link to comment
Share on other sites

Happy2Play

Can you post your genrecleaner.xml (*\programdata\plugins\configurations).  But something would be wrong if Genres are appearing that is not in the initialization list.

 within the plugin

Only the genres defined below will be allowed. All other genres from any source will be discarded unless mapped to one of these.

But have you tried to "+Add" that "Comedy / Comedy" genre to the list then map it?

 

5d002f1dea1ba_cleaner.jpg

 

 

And where are these genres coming from?  

Edited by Happy2Play
Link to comment
Share on other sites

arrbee99

Xml is attached.

 

No, didn't try adding Comedy-Comedy and mapping it, should I ? I thought it would find stuff like that automatically and then I fix up the new stuff it finds.

 

Don't know where they're coming from, I haven't added anything myself, so I guess its some kind of metadata.

 

Might be relevant that that xml file hasn't I think been updated since November last year.

 

Also in the images I posted it shows Science Fiction mapped from Science-Fiction and Sci-Fi but Science-Fiction still shows up as a separate genre.

 

 

GenreCleaner.xml

Link to comment
Share on other sites

Happy2Play

Well every genre not on the initialization list should be blocked if not mapped to another genre.

 

I would assume @@ebr or @@Luke would need to see a server log after a library scan.  But with my testing the plugin in working on my Windows test system with and without nfo metadata.

 

I deleted a genre from the list and genre was removed from item during scan.

2019-06-11 16:28:32.332 Info App: Genre 'Music' removed from metadata for The Page Turner.

Only other thing I can think of is shutting down Emby, deleting the genrecleaner.xml, restarting Emby and going to the plugin setting a initializing each type again and remapping.

Link to comment
Share on other sites

arrbee99

Interesting it works for you. Am probably doing something really basic wrong.

 

Still, if anyone gets a chance, here's a log. Restarted server, did normal scheduled tasks library update then did a Genre Cleaner Start Library Scan at about 12:07.

 

I'll try deleting / renaming the xml file if no one gets a chance to have a look at the logs in a day or two, if that sounds ok.

embyserver.txt

Edited by arrbee99
Link to comment
Share on other sites

Happy2Play

I can reproduce this "Comedy / Comedy" Genre issue.  
 
But deleting my genrecleaner.xml and reinitializing allowed the "Comedy / Comedy" to appear on the list.
 
This test was done in 4.2.0.15.
 
I was getting mixed results adding the genre directly to the nfo ( <genre>Comedy / Comedy</genre> ) would only show Comedy in the UI, but had best results adding "Comedy / Comedy" via metadata manager.  
 
I am guessing that name is being parsed when reading the metadata and Comedy is a allowed Genre.  Since foreign genres ie not on the list get nuked everytime.
 
 
Additional information
 
When I got "Comedy / Comedy" to appear on the list, when I deleted it and performed a scan it was removed from the media.
 
 
So to me there is a quirk in the combine genres where it is somewhat parsed.

@@arrbee99

Does Emby provide all your metadata?

Edited by Happy2Play
reworded
Link to comment
Share on other sites

arrbee99

Personally I wouldn't edit nfo's directly.

 

I don't know where it gets Comedy/Comedy or Science-Fiction from. Browsing through quite a few of the movies that are in those categories, when I click on Edit Metadtata, non of them have 'Comedy/Comedy', either literally like that or Comedy twice in the genres metadata and non have 'Science-Fiction' either, just 'Science Fiction'.

 

Maybe that just shows I don't know what I'm talking about.

Link to comment
Share on other sites

Happy2Play

Personally I wouldn't edit nfo's directly.

 

I don't know where it gets Comedy/Comedy or Science-Fiction from. Browsing through quite a few of the movies that are in those categories, when I click on Edit Metadtata, non of them have 'Comedy/Comedy', either literally like that or Comedy twice in the genres metadata and non have 'Science-Fiction' either, just 'Science Fiction'.

 

Maybe that just shows I don't know what I'm talking about.

 

Since it looks like a parsing issue to me when reading metadata, I would try renaming your genrecleaner.xml and allowing a new one to be built to see if it lists these problem genres and remap them.  Or manually add them to the list and map them. 

 

But the "Science-Fiction" is slightly different.  But rebuilding the genrecleaner.xml and remap may resolve that issue also.

Link to comment
Share on other sites

Happy2Play

If that doesn't work, we will have to look at the metadata for items within those genres and hopefully it is not a database issue.

Edited by Happy2Play
Link to comment
Share on other sites

I think the problem with that specific setup is the fact that a "/" is considered a delimiter in our parsing because - at least back in the day - the metadata providers used to separate genres that way.  Luke will have to confirm if we still parse out individual genres from something like "Comedy/Comedy".

 

As for the plug-in showing you the genres you have, it only does that on initial setup because, back when it was designed, searching for every genre in your entire library was a very expensive task.

Link to comment
Share on other sites

  • 3 weeks later...
arrbee99

Just to mention, I decided to rebuild my library.db to get rid of some TV channels that just wouldn't disappear, and now that's done, it seems all my genre duplicates have fixed themselves up as well. Yay.

Link to comment
Share on other sites

  • 1 year later...
GrimReaper
On 6/12/2019 at 6:47 AM, Happy2Play said:

within the plugin


Only the genres defined below will be allowed. All other genres from any source will be discarded unless mapped to one of these.

Shouldn't this logic be rewritten to actually SHOW any new 'unknown' genre imported, i.e. one not in allow list nor mapped, as opposed to discarded? That way, user would actually be made aware ot it's presence and decide what to do with it: allow, map to existing one or discard? 

Link to comment
Share on other sites

I think the original intention was essentially to have it put up a wall so that only genres that you've approved would pass through. But yes that kind of option is possible.

Link to comment
Share on other sites

GrimReaper
Just now, Luke said:

I think the original intention was essentially to have it put up a wall so that only genres that you've approved would pass through. But yes that kind of option is possible.

Yes, but that would imply one already having ALL the genres upon initialization. That's hardly a case, ever. 

Link to comment
Share on other sites

10 hours ago, Luke said:

I think the original intention was essentially to have it put up a wall so that only genres that you've approved would pass through. But yes that kind of option is possible.

Correct.  The problem this plugin was created to solve is actually not really a problem anymore.  A long time ago, tmdb used to put about 15 genres on every item which made them fairly useless in our system.

Link to comment
Share on other sites

  • 4 months later...
CarlosLima

Hi,
I use the this plugin and after upgrading to EmbyServer 4.6.4.0 it doesn't seem to work anymore because the button doesn't respond.
Thanks for any tips.

download.png

Link to comment
Share on other sites

  • 1 year later...
Clangrijan

Hello!

I installed the plugin and on the first scan, it correctly mapped some genres. But then, I modified some other genres by adding more mappings, and it stopped working. For example, 'Documental mapped from: Documentary' is not working anymore. And the other mappings I configured are not working either.

Can anyone help me out?

Link to comment
Share on other sites

Clangrijan
9 minutes ago, Clangrijan said:

Hello!

I installed the plugin and on the first scan, it correctly mapped some genres. But then, I modified some other genres by adding more mappings, and it stopped working. For example, 'Documental mapped from: Documentary' is not working anymore. And the other mappings I configured are not working either.

Can anyone help me out?

Sorry about that. It happens when the mapping is for more than one genre. For instance: 'Aventuras Mapped from: Aventura; Adventure'. It correctly maps 'Aventura' but not 'Adventure'.

Link to comment
Share on other sites

Clangrijan
1 hour ago, ebr said:

Hi.  Can we please see a log from when you refreshed those items?

@softworkz

Hi. I'm attaching the log. I'm not sure if this is what you're looking for.

Thanks a lot.

embyserver.txt

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...