Jump to content


Photo
Completed

Feature Request: Add additional Art to PlayItem



  • This topic is locked This topic is locked
16 replies to this topic

#1 cgrey000 OFFLINE  

cgrey000

    Advanced Member

  • Alpha Testers
  • 114 posts
  • Local time: 04:54 AM
  • LocationRaleigh, NC, USA

Posted 19 May 2014 - 09:40 PM

Noticed a couple of issues with artwork in the video player OSD. When the OSD is activated (video paused), if the option to show the poster in the OSD is set, there is no poster shown (see below). The poster DOES show when a movie is paused. Also, not shown, in the lower-right corner (just above sxxexx) native XBMC shows the clearart for the TV series. Finally - this is a little harder to explain ... Start a video, pause it (you will get the OSD below) - while it is paused, press "i" (info) - the TV content rating (TV-G, MA, etc) will appear in the 3rd position on he top bar. Would be nice if that showed up without having to press "i" (and strange that it behaves this way, I think)..

537ab24ec8330_Capture.jpg


Edited by cgrey000, 19 May 2014 - 09:45 PM.


#2 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 20 May 2014 - 08:15 AM

These are both actually XBMB3C things - not Aeon Nox - I think they are easy.  Will look into it tonight.

 

xnappo


  • tube82 likes this

#3 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 09:39 AM

@cgrey000

I added several new things to the item properties during playback:

- Clearart

- Posters

- Discart

- Studios

 

I can't figure out what you mean regarding the MPAA rating though.  We are setting that property.

 

xnappo


  • tube82 likes this

#4 cgrey000 OFFLINE  

cgrey000

    Advanced Member

  • Alpha Testers
  • 114 posts
  • Local time: 04:54 AM
  • LocationRaleigh, NC, USA

Posted 21 May 2014 - 10:45 AM

@cgrey000

I added several new things to the item properties during playback:

- Clearart

- Posters

- Discart

- Studios

 

I can't figure out what you mean regarding the MPAA rating though.  We are setting that property.

 

xnappo

Cool - thanks. Just grab from GIT to get the updates?

 

I will try to post a couple of screenshots to illustrate what I mean - I can only assume it's a skin thing.

 

Can you replicate this sequence of events:

 

1) Start playing a TV show episode (movies don't seem to do this)

 

2) Press Pause - note if the MPAA rating appears in the 3rd spot from the left on the top bar (on my setup, it doesn't - that spot is empty)

 

3) While paused, press "i" (or whatever you have configured for INFO). The MPAA rating now appears in that 3rd position on the top (it seems to re-draw the entire top bar, but the MPAA rating is all that changes).

 

In "native" XBMC (putting the skin OUT of XBMB3C mode and playing the file from the XBMC library), the rating is properly in place when you do step #2 above,

 

** Update: In fact, when performing step 3 above, it seems that NR (not rated) is always displayed, where in "native" mode, the correct rating (TV-14, TV-MA, etc) is displayed..

 

Hope that made sense... ??


  • xnappo likes this

#5 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 10:54 AM

Yep - makes sense - I will see what I can figure out.

 

@im85288 - any ideas here?

 

xnappo



#6 im85288 OFFLINE  

im85288

    Kodi Kruncher

  • Developers
  • 2699 posts
  • Local time: 08:54 AM
  • LocationGeordie Land

Posted 21 May 2014 - 12:00 PM

Sorry no idea, $INFO[ListItem.MPAA] works fine in Eminence on the info screen.



#7 cgrey000 OFFLINE  

cgrey000

    Advanced Member

  • Alpha Testers
  • 114 posts
  • Local time: 04:54 AM
  • LocationRaleigh, NC, USA

Posted 21 May 2014 - 01:55 PM

I think they are two separate (but related) problems. Even in other views (like Info view) that have a field for MPAA rating - every TV series seems to say "NR" even when the rating is "known" (example below). The same views in "native" (again, xbmb3c mode turned off) pulling from the XBMC library show the correct rating.

 

I'm wondering if NR is being shown because whatever property holds this is "empty", and as a result that is contributing to the first problem (blank place on the top info bar in the player OSD, and pressing "i" is forcing it in)

 

Dunno, just thinking out loud and hoping to help...

 

Edit: I think I have a little more on this - looks like at least part of it may be an XBMB3C thing... The MPAA rating field doesn't seem to be getting populated at the episode level. I checked through the web interface, and found that several of the episodes I've tested had the "parental rating" field empty. I put a value in, and sure enough, that came through in both the views that it was missing from previously. However, the web interface DOES seem to know that the show itself has a rating, because it is properly displayed when viewing the show info (in the web interface AND in XBMC).

 

Edit2: Similarly, it doesn't seem that Studio is being populated at the episode level either, but does exist at the show level


Edited by cgrey000, 21 May 2014 - 02:23 PM.

  • xnappo likes this

#8 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 06:00 PM

Okay - that is easy to fix.  I put in a similar feature request against the server - missing data at the episode level really needs to fall through from the parent automatically and not have to be done by the client.

 

Thanks a lot for testing - will get this in the Git in a couple of hours.

 

Still doesn't explain it not showing up until you hit 'i' though right?  I have an idea on that I will look into too.

 

xnappo



#9 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 07:24 PM

Can you post a screenshot of the ratings icon showing up on a 'Pause' screen and not a 'Info' screen?  I can't get it to do that with the native library either.

 

xnappo



#10 cgrey000 OFFLINE  

cgrey000

    Advanced Member

  • Alpha Testers
  • 114 posts
  • Local time: 04:54 AM
  • LocationRaleigh, NC, USA

Posted 21 May 2014 - 08:23 PM

Okay - that is easy to fix.  I put in a similar feature request against the server - missing data at the episode level really needs to fall through from the parent automatically and not have to be done by the client.

 

Thanks a lot for testing - will get this in the Git in a couple of hours.

 

Still doesn't explain it not showing up until you hit 'i' though right?  I have an idea on that I will look into too.

 

xnappo

I completely agree this should be "fixed" at the server side. Among other things, it would be possible for different episodes of the same show/series to have a different MPAA rating. If it doesn't get fixed (and scraped) at the server side, we'd never see that happen on the client.

 

I'm purely guessing here, but I think the reason it isn't showing up in pause and is in "info" is that they are handling it differently. I suspect the pause screen just leaves that spot blank if there is nothing in the MPAA property, where the info screen substitutes the "NR" (not rated) assuming blank means none.. But I could be completely wrong. 

 

All of this said, I don't think we need to "fix" the pause vs. info thing. If we actually get a rating to be passed, it WILL be displayed on the pause screen also. It is only the "empty" ones that we are seeing this behavior...  If you still want some screenshots, though, I'd be happy to snap a few...


  • xnappo likes this

#11 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 08:44 PM

Thing is - even on movies I am not seeing the rating on the pause screen(with or without XBMB3C).  I don't think I know the display you are talking about...

 

I got most of this sorted in the client - but I need to clean up the code a bit.  Would be nicer if the server handled it, but we are already doing this sort of thing for artwork all over, so doing it for studio and rating isn't too bad.

 

xnappo


Edited by xnappo, 21 May 2014 - 08:44 PM.


#12 elcabong OFFLINE  

elcabong

    Advanced Member

  • Alpha Testers
  • 131 posts
  • Local time: 01:54 AM

Posted 21 May 2014 - 09:42 PM

I added several new things to the item properties during playback:

- Clearart

- Posters

- Discart

- Studios

 

can we have fanart available as well.



#13 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 21 May 2014 - 10:30 PM

Sure - is there something out there I can test it with?

 

xnappo



#14 elcabong OFFLINE  

elcabong

    Advanced Member

  • Alpha Testers
  • 131 posts
  • Local time: 01:54 AM

Posted 22 May 2014 - 11:16 AM

movies

http://XBMCIP:PORT/jsonrpc?request={"jsonrpc": "2.0", "method": "Player.GetItem", "params": { "properties": [      "duration","fanart","director","tagline","plot","originaltitle","writer","studio","mpaa","premiered","runtime","file","disc"], "playerid": 1 }, "id": "1"}

 

tv

http://XBMCIP:PORTjsonrpc?request={"jsonrpc": "2.0", "method": "Player.GetItem", "params": { "properties": [ "duration","fanart","director","plot","writer","studio","premiered","runtime","firstaired","season","episode","showtitle","thumbnail","file","watchedepisodes","disc","genreid"], "playerid": 1 }, "id": "1"}

 

a browser should return the json.

 

thanks, i use a webpage to control my xbmc/media, so im limited to json for getting now playing info and controlling them.

 

-- edit

 

for any curious, this is what i use to control my home media

https://github.com/e...g/ControlCenter


Edited by elcabong, 22 May 2014 - 11:19 AM.


#15 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 24 May 2014 - 10:01 AM

I have checked in these changes - quite a bit of squirrelly code due to info not being propagated to the episode level by the server - so please test.

 

xnappo


Edited by xnappo, 24 May 2014 - 10:01 AM.


#16 cgrey000 OFFLINE  

cgrey000

    Advanced Member

  • Alpha Testers
  • 114 posts
  • Local time: 04:54 AM
  • LocationRaleigh, NC, USA

Posted 27 May 2014 - 02:07 PM

I have checked in these changes - quite a bit of squirrelly code due to info not being propagated to the episode level by the server - so please test.

 

xnappo

Awesome! - Thanks for putting some time in to this. Was away for the long weekend, but will pull from GIT and have a look tonight. 

 

Again - THANKS!

 

Did you get the movie OSD info worked out? If not, I can get some screenshots up in the coming days if it would help...


Edited by cgrey000, 27 May 2014 - 02:08 PM.


#17 xnappo OFFLINE  

xnappo

    Advanced Member

  • Developers
  • 4755 posts
  • Local time: 02:54 AM
  • LocationAustin, TX

Posted 27 May 2014 - 03:01 PM

I think I am still missing one bit - the displaying of rating on 'pause' rather than 'info' screen.  However I couldn't get that to work with native either.  I tried a skin mod that I thought might help but it didn't do anything.  

 

xnappo







Also tagged with one or more of these keywords: Completed

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users