Bug: Aspect ratio for cast & crew isn't maintained

[BrendenCA 0]

Hi,

 

I just noticed today while browsing emby (the webapp), The aspect ratios aren't maintained for some cast images.

 

For example,

In the movie American Made, there is a member of the cast Jesse Plemons, his pic seems to be squeezed horizontally, making it look a bit weird.

 

The exact pic in question can be found here for your testing,

https://image.tmdb.org/t/p/original/4fdE4D8e2DEtFL4QgdorQOAI9RT.jpg

 

I have narrowed down the issue to,

https://github.com/MediaBrowser/emby-webcomponents/blob/master/cardbuilder/card.css#L277

 

Changing background-size to 'cover' seems to have solved the problem, and from my testing there doesn't seem to be any negative effect to the other images.

 

I hope that helps you figure it out.

 

Thanks,

[Happy2Play 8277]

@@Luke

Some will not like the odd AR but why can't images be displayed like here?  Instead of stretch to fit.

 

 

Edited August 16, 2018 by Happy2Play

[Luke 37049]

I guess but the bordering at the top is kind of an eyesore.

[Happy2Play 8277]

I guess but the bordering at the top is kind of an eyesore.

 

At the same time it lets the user know to look for better quality images.

[BrendenCA 0]

@@Luke

 

Does the modification look good? Can, I make a PR? It would really help me build up my GH profile.

 

Thanks,

[Luke 37049]

To be honest I lean towards keeping it the way it currently is.

[BrendenCA 0]

 

@@Luke, That's what the situation currently is,

 

Surely, you want the aspect ratio to be maintained, poor chap above looks thin 

 

Plus, this image isn't that bad, it has a AR of 1.38.

However, the more closer the image AR is to 1 the more badly skewed it will be.