Jump to content

Bug: Aspect ratio for cast & crew isn't maintained


BrendenCA
 Share

Recommended Posts

BrendenCA

Hi,

 

I just noticed today while browsing emby (the webapp), The aspect ratios aren't maintained for some cast images.

 

For example,

In the movie American Made, there is a member of the cast Jesse Plemons, his pic seems to be squeezed horizontally, making it look a bit weird.

 

The exact pic in question can be found here for your testing,

https://image.tmdb.org/t/p/original/4fdE4D8e2DEtFL4QgdorQOAI9RT.jpg

 

I have narrowed down the issue to,

https://github.com/MediaBrowser/emby-webcomponents/blob/master/cardbuilder/card.css#L277

 

Changing background-size to 'cover' seems to have solved the problem, and from my testing there doesn't seem to be any negative effect to the other images.

 

I hope that helps you figure it out.

 

Thanks,

Link to comment
Share on other sites

Happy2Play

@@Luke

Some will not like the odd AR but why can't images be displayed like here?  Instead of stretch to fit.

 

5b75bb50e6bb3_Untitled.jpg
 

Edited by Happy2Play
Link to comment
Share on other sites

Happy2Play

I guess but the bordering at the top is kind of an eyesore.

 

At the same time it lets the user know to look for better quality images.

Link to comment
Share on other sites

BrendenCA

5b76e326cd738_Untitled.png

 

@@Luke, That's what the situation currently is,

 

Surely, you want the aspect ratio to be maintained, poor chap above looks thin  :lol:

 

Plus, this image isn't that bad, it has a AR of 1.38.

However, the more closer the image AR is to 1 the more badly skewed it will be.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...