Completed Bug: SetSubtitleStreamIndex General Command

[rhodges 37]

Looking at the source:

 

https://github.com/MediaBrowser/plugin.video.emby/blob/04d4865074994e6f71243b7d62847897371264e5/resources/lib/websocket_client.py

 

Line 221  

player.setSubtitleStream(index - audio_tracks - 1)

 

I think "index" should be "emby_index" because index hasn't be initialized yet. This raises an exception. I haven't yet tried replacing it. There may be other changes to make it work.

 

I also think there may be an issue in websocket.py, due to the error that is logged: (Note, ignore the lne 228, it should be 221. I modified the file to log some other information while I was troubleshooting).

20:50:25 T:55460   ERROR: No handlers could be found for logger "root"
20:50:25 T:55460   ERROR:   File "C:\Users\XXX\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\websocket.py", line 894, in _callback
20:50:25 T:55460   ERROR:     callback(self, *args)
20:50:25 T:55460   ERROR:   File "C:\Users\XXX\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\websocket_client.py", line 91, in on_message
20:50:25 T:55460   ERROR:     self._general_commands(data)
20:50:25 T:55460   ERROR:   File "C:\Users\XXX\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\websocket_client.py", line 228, in _general_commands
20:50:25 T:55460   ERROR:     player.setSubtitleStream(index - audio_tracks - 1)

[Angelblue05 4130]

Thanks for reporting. This will be fixed for the next beta release.

[rhodges 37]

No problem. My quick check shows that, for me at least, changing it to emby_index does indeed work, except, when I try to turn subtitles off. The Emby wiki says to send -1 to the api to turn them off. I think maybe -1 is not interpreted by the plugin as a turn off command.

 

https://github.com/MediaBrowser/Emby/wiki/Remote-control

 

Thanks for the great plugin and your quick responses to my questions.

[Angelblue05 4130]

Both issues should be corrected with the latest emby for kodi beta 2.2.41