Completed 1.1.64 boxset crash

[xnappo 1593]

Hi @@Angelblue05 - seeing a crash in boxsets setup during initial sync.

18:16:28 T:3444  NOTICE: EMBY Movies -> New addition to boxset Barbie Collection: Barbie: Fairytopia
18:16:28 T:3444  NOTICE: EMBY Movies -> New addition to boxset Barbie Collection: Barbie in A Mermaid Tale 2
18:16:28 T:3444  NOTICE: EMBY Movies -> New addition to boxset Barbie Collection: Barbie in the Pink Shoes
18:16:28 T:3444  NOTICE: EMBY Movies -> New addition to boxset Barbie Collection: Barbie: Mariposa and The Fairy Princess
18:16:32 T:3444   ERROR: Exception in thread Thread-10:
                                            Traceback (most recent call last):
                                              File "C:\Program Files (x86)\Kodi\system\python\Lib\threading.py", line 810, in __bootstrap_inner
                                                self.run()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 1212, in run
                                                self.run_internal()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 1294, in run_internal
                                                librarySync = self.startSync()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 97, in startSync
                                                completed = self.fullSync()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 237, in fullSync
                                                completed = process[itemtype](embycursor, kodicursor, pDialog, compare=manualrun)
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 592, in movies
                                                movies.add_updateBoxset(boxset)
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\itemtypes.py", line 524, in add_updateBoxset
                                                movieid = emby_dbitem[0]
                                            TypeError: 'NoneType' object has no attribute '__getitem__'
18:16:33 T:1012  NOTICE: Storing total System Uptime
18:16:33 T:1012  NOTICE: Saving settings

I can investigate more if you don't know the cause off the top of your head.

 

xnappo

[Angelblue05 4130]

Give me a few minutes, I'll look into it. 

[Angelblue05 4130]

Hmmm, seems a movie from the boxset was not imported during the movies import. Ok, I'll put something in place in this event. I didn't think it could happen.  

[Angelblue05 4130]

@@xnappo

 

I'm a bit unsure about this fix. Can you install this version, let me know if it works for you. If so I'll push to beta.

 

Edited December 25, 2015 by Angelblue05

[xnappo 1593]

Changed the error - but still crashed.  I can look into it more tomorrow - family time now   Not a boxset I pay particular attention to obviously!

19:23:19 T:8572  NOTICE: EMBY Movies -> New addition to boxset Barbie Collection: Barbie: Mariposa and The Fairy Princess
19:23:23 T:8572   ERROR: Exception in thread Thread-10:
                                            Traceback (most recent call last):
                                              File "C:\Program Files (x86)\Kodi\system\python\Lib\threading.py", line 810, in __bootstrap_inner
                                                self.run()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 1212, in run
                                                self.run_internal()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 1294, in run_internal
                                                librarySync = self.startSync()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 97, in startSync
                                                completed = self.fullSync()
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 237, in fullSync
                                                completed = process[itemtype](embycursor, kodicursor, pDialog, compare=manualrun)
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\librarysync.py", line 592, in movies
                                                movies.add_updateBoxset(boxset)
                                              File "C:\Users\xnappo\AppData\Roaming\Kodi\addons\plugin.video.emby\resources\lib\itemtypes.py", line 527, in add_updateBoxset
                                                self.update_add(movie)
                                            AttributeError: 'Movies' object has no attribute 'update_add'
19:23:25 T:9788  NOTICE: Storing total System Uptime
19:23:25 T:9788  NOTICE: Saving settings
19:23:25 T:9788  NOTICE: stop all
19:23:25 T:9788  NOTICE: stop player

[Angelblue05 4130]

it's my bad. Derp moment, the method is named add_update, not update_add. Doh! 

[Angelblue05 4130]

Out of curiousity, the other content in the boxset is a movie right? Not some other type of content?

[xnappo 1593]

Hi @@Angelblue05 - I had two 'problem' boxsets.  One had a multi-part movies in it (part1.avi, part2.avi) and the other had a bad directory structure (extra directory containing the actual movie).

 

I just fixed these because I have been trying to merge all my stupid multi-parts anyway, but they were both still failing with the last version you posted.

 

Another VERY minor bug - when I do the initial sync, I have two movie collections - 'Kids' and 'Movies' - however the text does not update after it processes 'Kids' - it still says processing 'Kids' when it is really doing 'Movies'.

 

xnappo

[Angelblue05 4130]

I believe the boxset situation is fixed with 1.1.66

 

However, for the initial sync I do not have this issue. Very strange. The process is a loop so it should behave correctly since we grab the view name and apply it everywhere.

 

One test would be to check if your Movies are tagged as Kids, because the same var for tags is displayed in the dialog. Let me know.