Anyone using Roku's and NextPVR able to duplicate my issue ?

[vaise 304]

Hi,

 

Iv posted it a while back and provided logs in the NextPVR area.  Basically, I use 6 roku's (never more that 2 at a time), all wired, Latest Emby backend and NextPVR on the server doing the TV recording.  We dont watch live TV.  The NextPVR plugin works well, can see all the stuff, just playing that causes random issue.  We just want to watch the recorded TV.

 

Issue is :

 

'Loading, Please wait' randomly when watching via Roku

 

This is repeatable all the time - usually once per half hour - sometimes more.  When it happens, we just click back, and click to start where it left off and we are away again.  Bit of a pain.  The files are TS files as they are the recorded TV stream.  The are being transcoded (as you would expect).   I know I can use post production stuff to convert to a more 'steam friendly' format - but that is not what I want to do - seeing as it was never done by the WMC/XBoxes.  The wife wants to watch stuff once it has finished.    

 

Anyone doing it this way ?  I had a large investment in WMC and XBOX360 extenders, now I have a large investment in Roku players and still not quite there on the recorded TV front.

 

Note - all other aspects of Emby are fine (Movies, Rips etc).

 

Anyone in this same situation ?  Is it my config ?

 

Thanks.

 

 

 

[Luke 37008]

As a test, try creating an emby library out of these files so that you don't need to route them through the plugin

[vaise 304]

OK, I have done that - I will report back after we watch some shows.  As we dont use live TV - and if this works fine, then it is simply a matter of removing the plugin. Thanks.

[vaise 304]

Reporting back -

 

when I add the NextPVR recorded TV folder to emby directly, and it has scanned (as Home Movies type)I have not had any of these lockups so far - only watched two shows - but that is a good sign.  Downside is we cant delete shows once watched in this 'mode'.  Suggests the issue is with the plugin then ? 

[Luke 37008]

I think it's possible that the delete function in the app is currently limited to content delivered from the live tv plugins, so we'll need to expand on it

[speechles 1917]

@@vaise

 

In VideoSpringboardScreen.brs

    if video.ContentType = "Recording"
        m.AddButton("Delete", "delete")
    end if

Luke is right, currently it is only tied to recordings. To get it to delete TV Episodes would also be:

    if video.ContentType = "Recording" or video.ContentType = "Episode" Then
        m.AddButton("Delete", "delete")
    end if

But should this be tied to only administrative users? ATM the roku isnt checking much beyond the contenttype before bestowing this option. Anyways, to make a long story short, I've included this in the Blue Neon Night app (update!) as a setting in preferences. You will find "Allow Deleting Episodes" option, turn this to yes. A delete option will appear now with tv episodes. This isn't tied to adminstrative users, so will let just anyone delete so use this with caution or risk chagrin. Merry Christmas.

Edited December 23, 2015 by speechles

[vaise 304]

Hi,  From my perspective, it needs to be locked down in some way - maybe a tick box in the folder add section (allow deletions ?)  I dont want the kids to able to delete all the normal ripped movies and TV Shows.  Thanks.

[vaise 304]

p.s - Im really liking the Blue Neon Night app.

[Luke 37008]

@@vaise

 

In VideoSpringboardScreen.brs

    if video.ContentType = "Recording"
        m.AddButton("Delete", "delete")
    end if

Luke is right, currently it is only tied to recordings. To get it to delete TV Episodes would also be:

    if video.ContentType = "Recording" or video.ContentType = "Episode" Then
        m.AddButton("Delete", "delete")
    end if

But should this be tied to only administrative users? ATM the roku isnt checking much beyond the contenttype before bestowing this option. Anyways, to make a long story short, I've included this in the Blue Neon Night app (update!) as a setting in preferences. You will find "Allow Deleting Episodes" option, turn this to yes. A delete option will appear now with tv episodes. This isn't tied to adminstrative users, so will let just anyone delete so use this with caution or risk chagrin. Merry Christmas.

 

Actually I've just checked in the right way to do it. Only problem is the delete is going to fail because it needs to use a different api method that supports all content types. if you can dig it out of the web client and submit a PR that would be great. Otherwise i'll get to it when i can.

 

The change is available now in the zip install.

[speechles 1917]

Hi,  From my perspective, it needs to be locked down in some way - maybe a tick box in the folder add section (allow deletions ?)  I dont want the kids to able to delete all the normal ripped movies and TV Shows.  Thanks.

 

Ok, it is locked down. You need to update the blue neon app, again. heh

 

You must be administrator to change the option now. You also must be administrator to even see the delete option on the detail page. Non-administrators will still see the option in  preferences, but will not be able to change what it is set to. Non-administrators wont be able to use, or see the option to delete on detail pages. Only administrators can delete, and only with that option set.

 

Combined this should make it near impossible for someone who shouldn't be deleting things to be able to delete things.

 

@@Luke

 

I didn't see your post before I posted. Your method also locks down the delete button to admins? Ok, no it doesn't but you do use a cleaner method to delete any item. This looks better. To check for isadministrator is the same way you did the candelete. The user object just isn't passing that field and you add it to the parseuser function to pass back. Anyways, here's how I cleaned it up:

    user = getGlobalVar("user")
    if video.CanDelete = true and DeleteEpisodes = "1" and user.IsAdmin Then
        m.AddButton("Delete", "delete")
    end if

This locks it down to just admins and lets me have that toggle in preferences as a 2nd layer of security.

 

After the kids go to sleep in a bit I'll dig around the web client source and get the backend working correctly for all types. This isn't that hard.

Edited December 23, 2015 by speechles

[Luke 37008]

you don't need to do those checks because it is already handled by the data coming from the server

[vaise 304]

That's great.  I have had a look in the user config - Do I define an 'admin' as someone with 'Allow this user to manage the server' ticked ?

I would like to request that this be added per Library, or per library/user - that is a better lockdown ?  As I can imagine it will only be for a 'recorded TV type folder.  As it is though - this will work for me - however I have had to instruct the wife to never click delete on the 'normal' libraries.  

[vaise 304]

Hi,  I just updated and had a play with this - I noticed my Recorded TV did not show the DELETE, but my normal ripped TV Shows did show the DELETE.  

 

I suspect this is because my library type I have set for the Recorded TV library is 'Home Video's', rather than TV Shows.  

 

The reason I set it to that rather than TV Shows is the metadata stuff really stuffs them up if I leave them as TV Shows as there is not enough guide info to decide what they are and they seem to be randomly tagged - all over the place.  Hence I wanted no metadata/no renaming etc - So they stay as showname-datetime etc etc.  This is what the recommendation was ages back if you don't want any metadata work done on the files.  

[speechles 1917]

@@Luke

url = GetServerBaseUrl() + "/Items/" + HttpEncode(ItemId)
request = HttpRequest(url)
request.AddAuthorization()
request.SetRequest("DELETE")
response = request.PostFromStringWithTimeout("", 5)

Okay, this does delete the item. So on the right track, but the problem is how do you then delete the other things, such as images?

url = GetServerBaseUrl() + "/Items/" + HttpEncode(itemId) + "/Images"

But with this I need imageType and imageIndex. This appears to not be what I want, and it would only delete images.

 

How do you delete the file, and it's metadata/images/subtitles/etc with it? Is there a way? Can you only remove the file itself? Ive searched around and found no answer.

@@vaise
The delete method isnt complete yet. It wont work yet, as Luke has mentioned. The backend needs work. This new version I have (not released yet) does indeed delete the item, but leaves metadata/image remnants. Just letting you know where I am on it. When I hear from Luke I can move forward.

Edited December 23, 2015 by speechles

[vaise 304]

No worries, I am in no rush - Take a breather and enjoy Xmas!

[vaise 304]

With regards to my specific issue, as I use home movies as the library type - there is NO metadata - so it would all be fine if these were deleting.  But that is just for me.  

[speechles 1917]

@@vaise

 

Indeed, home movies would have no metadata xml/nfo, but these would have images. The server would create *-poster.jpg for these. The http url endpoint I am using now lets you delete from anywhere, but there must be a field I am missing. An &include=images,subtitles,metadata or something which would let you remove the extraneous irrelevant data for this item. I already have it working to delete from anywhere, just very very curious how to make it delete the other things. So I'm not withholding it from you really, just waiting for the man who knows the answer so I can button this up. The documentation for this api call, well, there is none. Using the web client sources to reverse engineer knowledge takes longer than it should. But Ive gone as far as I can that way. There is no more to learn without talking to the man who made it. I need @@Luke

Edited December 23, 2015 by speechles

[vaise 304]

Cool.  As I said, there is no rush, and this looks like it is heading where Id like it to go.  The left over poster* etc etc wont bother me - as NextPVR creates a TV Show folder, and all the episodes are in the one folder anyway - and as I am recording the same things over and over, no big deal if it is left behind.  I can see how it is an issue for others though.  Cheers for what has been done so far.

V.

[speechles 1917]

@@vaise

Okay, updated the blue neon night app today, so update your roku. You can delete any item if you have that user able to delete items. You must first enable the option in preferences "Allow deleting items" and set this to yes to allow the delete option to show. You can only change this option if you are an administrator. It will show for all users, but they can't change the option even when trying. When you delete, the metadata/images/subtitles/etc wont be deleted.

Edited December 23, 2015 by speechles

[speechles 1917]

@@Luke

 

https://github.com/MediaBrowser/Emby.Roku/pull/118

 

Didnt notice there was a pull request for the same thing, #116 does the same thing. It goes a little overboard adding "CanDelete" to the url fields. So yeah, pretty sure do not want to do that. So What I've done was just merge the delete function and pass a ContentType and ID. Now the single function can delete everything. This is exactly what I am using in the blue neon night app. Still hoping for a way to delete the "other stuff" too.. heh

Edited December 23, 2015 by speechles

[vaise 304]

Just updated the roku, saw it doing the neon blue update.  Tested first that Kids cannot change the deleted files, change to Yes, clicked ok, saw it was still no - so that is good.  Logged on as myself, changed to yes, saw it stay as yes - so that's OK.  Went to my recorded TV library (not plugin, native Emby), saw no delete option however ?  Thought maybe I had to watch some, did so, still no delete.  Looked at TV Shows library, also no delete option.  Not sure where iv gone wrong as I saw the delete on TV Shows in one of the updates yesterday.  No rush as I said before - enjoy Xmas.

[speechles 1917]

 

In the web dashboard, choose the manage server tab in the slide-out. Then in the tabs choose users. Now click the user you wish to modify. On this screen, make sure the ability to delete is there. If it is this makes the canDelete option true. Have you already done this? To ensure its used correctly it requires also an administrator (the allow this user to manage the server checked) to enable the option in preferences "Allow Deleting Items" first before those users with canDelete privelege can delete.

 

Keep in mind, the homescreen will reupdate the deletions from it. But the TV season screen will not. After you delete things from here I havent gotten it to update the TV season metadata yet. I can get it to update the screen, but without new metadata showing its deleted you will still see it. It is only the TV season screen with this behavior. All the other methods will update correctly. So keep this in mind too.

 

I will work on getting the TV season screen to update after deletions I just dont have time at the moment. I dislike the idea of delete from the * menu, so there is no way to delete from the TV season screen. You have to drill into the episode. You also cant delete a series, or entire season. You also cant delete music or photos, yet. Not sure that other stuff is wanted. Delete in the wrong hands can cause severe damage. So limiting how fast one can do it to me was better.

Edited December 24, 2015 by speechles

[vaise 304]

Oops - not done that - all good now.  

 

Almost perfect for my use now - even though it may not suit others.

 

The last thing that would make this perfect (for me anyway) it a tick box on the library definition to override no deletions (or something). That way the wife will not accidentally delete the real TV Shows / Movies - or the kids when they don't log off and on as them selves in the shared Media Room and Lounge Room.  I sort of trust them, but a general override to never allow deletions on a library would be ideal.

This method suggested by Luke to add a library over the NextPVR files has solved the initial reason for my post.  This suggests there is an issue with the NextPVR plugin method of viewing Recorded TV (as I originally posted in the NextPVR section).  I don't mind now - as this new library method is fantastic - and a very quick turnaround for the solution so well done on that.  I have removed the nextPVR plugin now.

 

Thanks again. 

[speechles 1917]

Make sure to set the "remember me" option to no, and change the "allow deleting items" option to no, then sign out. You have to sign out to make it not remember you. Then close the app at the login screen. This will force the next user to login. If you are the only administrator this will ensure nobody with canDelete privelege can, until you turn delete back on.

 

Sent from my Nexus 7 using Tapatalk

[vaise 304]

Yep - that sort of works, but as the roku is never powered off, it means I have to remember to log out after every time I or the wife use it - not likely to happen all the time - so a bit closer but not quite perfect.  Plus as the wife and I share my logon, it would only protect the kids.  So very close to perfect, and I am happy as it is now.  Great Work.