Jump to content

after playing kodi movie in a set, plugin removes it from kodi set?


pgemby

Recommended Posts

i currently run

	kodi 19.4/matrix
	emby for kodi next gen v7.9.4

on

	lsb_release -rd
		Description:    Fedora release 36 (Thirty Six)
		Release:        36
	uname -rm
		6.0.7-200.fc36.x86_64 x86_64

and

	Emby Version 4.7.9.0-704070900

on

	Synology DSM Version: 7.1.1-42962 Update 2 

my libs/sets are fully & correctly sync'd between my Emby server backend & Kodi frontend.

if I play a movie, selected from within a Kodi set, the movie plays fine ...
... then, once done, is removed from the Kodi set.  not from available movie listings, ONLY from the Kodi set.

it's, as expected, read-only w.r.t. Emby -- the Emby set is not touched.  that's verified.

and, if I re-sync sets from within the Kodi/Emby plugin, the movie "missing" from the Kodi set reappears.

why is the movie removed from a Kodi set after playing?
is there a config I've missed that's allowing that?

how can I disable that 'deletion'?
after Kodi plays a movie in a set, i'd prefer that it simply leaves the set alone ... and does not delete it.

missing config?  or bug?

 

Link to comment
Share on other sites

quickmic

Sounds Kodi is doing that, not the plugin. Not sure which option s responsible here.

btw, are you sure it's removed and not hidden. I know there is an option in Kodi to hide watched content.

Link to comment
Share on other sites

> Sounds Kodi is doing that, not the plugin.

if I point kodi at a non-emby library source, i.e. not using the plugin, and setup a collection, then watch a movie in that non-emby-managed collection, the movies does not disappear from the kodi set.

if I manually remove a movie from a kodi-managed set, it stays removed from the set.

only in the emby-set case are movies disappearing from sets after playing.

that seems emby-plugin related to me :-/

> btw, are you sure it's removed and not hidden.

no, not certain at all.  just know that i don't "see" it in the displayed set.

>  I know there is an option in Kodi to hide watched content.

there is for items in libraries.  e.g., listing 'Movies', i can select to display "All/Watched/Unwatched".  here it's "All".

in any case, it seems to have no effect on what's shown, or not, in a set display.

and, so far, i have not found an option that controls just the set's display ...

 

  • Like 1
Link to comment
Share on other sites

quickmic
1 hour ago, pgemby said:

> Sounds Kodi is doing that, not the plugin.

if I point kodi at a non-emby library source, i.e. not using the plugin, and setup a collection, then watch a movie in that non-emby-managed collection, the movies does not disappear from the kodi set.

if I manually remove a movie from a kodi-managed set, it stays removed from the set.

only in the emby-set case are movies disappearing from sets after playing.

that seems emby-plugin related to me 😕

> btw, are you sure it's removed and not hidden.

no, not certain at all.  just know that i don't "see" it in the displayed set.

>  I know there is an option in Kodi to hide watched content.

there is for items in libraries.  e.g., listing 'Movies', i can select to display "All/Watched/Unwatched".  here it's "All".

in any case, it seems to have no effect on what's shown, or not, in a set display.

and, so far, i have not found an option that controls just the set's display ...

 

I performed a test and indeed, seems to be a plugin bug.

btw, only happens after Kodi restart, I'll fix it. That's why it SOOO important to design a reproducible test case and step by step instructions to trigger an issue.

Edited by quickmic
Link to comment
Share on other sites

  • 4 weeks later...
On 11/15/2022 at 11:14 AM, quickmic said:

I performed a test and indeed, seems to be a plugin bug.

v7.10.5, v7.11.1 & v7.12.0 seemd to have cured this behavior

the disappear-after-play has returned after upgrade from e4k 7.12.0 -> 7.13.0

 

  • Thanks 1
Link to comment
Share on other sites

quickmic
On 12/13/2022 at 1:01 AM, pgemby said:

v7.10.5, v7.11.1 & v7.12.0 seemd to have cured this behavior

the disappear-after-play has returned after upgrade from e4k 7.12.0 -> 7.13.0

 

I can confirm that, was a collateral damage 🙄 I'll fix it in next version

  • Thanks 1
Link to comment
Share on other sites

  • 2 weeks later...
On 12/15/2022 at 4:11 AM, quickmic said:

I can confirm that, was a collateral damage 🙄 I'll fix it in next version

@quickmic

7.13.1 & 7.13.2 were good.

After upgrade to 7.13.3, the disappear-after-play has returned again

Link to comment
Share on other sites

quickmic
32 minutes ago, pgemby said:

@quickmic

7.13.1 & 7.13.2 were good.

After upgrade to 7.13.3, the disappear-after-play has returned again

Are you sure? I'll check it, but actually this is very strange 7.13.2 -> 7.13.3 are just minimal changes. Must be some other bug this time and not specific to 7.13.3

Edited by quickmic
Link to comment
Share on other sites

Yep.  I'm 100% sure that the disappear-after-play is happening now, with 7.13.3.

And, I'm also sure that after your

> I can confirm that, was a collateral damage 🙄 I'll fix it in next version

fix, it was in fact fixed for 7.13.1 & 7.13.2.

I'm "95%" sure that it was at the 7.13.2 -> 7.13.3 update that the behavior returned.

Kodi flatpak updated 19.4 -> 19.5 somewhere in there as well.  I can't say for sure in what order 😕

So, currently, I've  e4k 7.13.3 + kodi 19.5/flatpak ...

Edited by pgemby
Link to comment
Share on other sites

quickmic
13 minutes ago, pgemby said:

Yep.  I'm 100% sure that the disappear-after-play is happening now, with 7.13.3.

And, I'm also sure that after your

> I can confirm that, was a collateral damage 🙄 I'll fix it in next version

fix, it was in fact fixed for 7.13.1 & 7.13.2.

I'm "95%" sure that it was at the 7.13.2 -> 7.13.3 update that the behavior returned.

Kodi flatpak updated 19.4 -> 19.5 somewhere in there as well.  I can't say for sure in what order 😕

So, currently, I've  e4k 7.13.2 + kodi 19.5/flatpak ...

I think I can reproduce the issue, still thinking this was a bug in previous versions as well (under different circumstances as I already fixed). However, I'll fix it in next version.

  • Thanks 1
Link to comment
Share on other sites

quickmic

I tried to reproduce the issue with a fresh installation, no "luck".

With my older database I was able to trigger the issue, but the database was already broken. Currently not sure what actually caused the issue. I'll continue review...

 

EDIT:

I think I found the problem. It only appears if the movie was twice updated (by EMby serer). A single update is fine.

Edited by quickmic
Link to comment
Share on other sites

>  twice updated (by EMby serer). A single update is fine.

'updated' in what way?  e.g. fully stopped, with a resume-from timestamp update?

 

Link to comment
Share on other sites

quickmic
2 minutes ago, pgemby said:

>  twice updated (by EMby serer). A single update is fine.

'updated' in what way?  e.g. fully stopped, with a resume-from timestamp update?

 

Twice updated from Emby server side.

Stop Kodi, Play movie on Emby, start Kodi -> First update

Same procedure for seconds update.

 

Link to comment
Share on other sites

quickmic
7 minutes ago, pgemby said:

Ah.  That I did not do ...

But, I DID in several instances: Stop movie, exit Kodi, start Kodi, resume movie.

 

 

It was just an example for (simple) verification.

Content updates are also send if the content was played on a different device etc.

Realtime progress updates send from Emby server are not causing the issues.

 

My analysis is:

After Kodi, init sync: kodi-emby and kodi-video database both correct.

1. update, kodi-emby database out of sync, kodi-video database still fine. -> (Box)Set view still ok at this point

2. update, kodi-emby database out of sync, kodi-video database out of sync. -> (Box)Set broken.

 

This is a different bug as the one I fixed in previous versions. Also this is not only related to 7.13.3, also previous versions have this issue. It only affects to (Box)Sets sync. Everything else is still fine.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...