Luke 37004 Posted November 21, 2022 Author Share Posted November 21, 2022 2 minutes ago, Bigmack3000 said: example: What artist image fetchers do you have enabled? Link to comment Share on other sites More sharing options...
Bigmack3000 84 Posted November 21, 2022 Share Posted November 21, 2022 A few, with discogs up top. Link to comment Share on other sites More sharing options...
Luke 37004 Posted November 21, 2022 Author Share Posted November 21, 2022 3 minutes ago, Bigmack3000 said: A few, with discogs up top. Was that on before, or after the scan? (notice the help text at the top of the dialog). When you install it will not be checked by default. Link to comment Share on other sites More sharing options...
Bigmack3000 84 Posted November 21, 2022 Share Posted November 21, 2022 It was on before I ran the scan. Link to comment Share on other sites More sharing options...
Luke 37004 Posted November 22, 2022 Author Share Posted November 22, 2022 Just now, Bigmack3000 said: It was on before I ran the scan. Ok well I can see lots of too many request errors in your log coming from discogs, so that could be the reason. I haven't had a chance to circle back to this yet but we're going to have to look at how to manage that. Link to comment Share on other sites More sharing options...
Bigmack3000 84 Posted November 22, 2022 Share Posted November 22, 2022 Ah ok. Could that be a problem for large libraries? If I ran it again, do you think it would add images since it's already linked? Or still have too many requests? Link to comment Share on other sites More sharing options...
Bigmack3000 84 Posted November 22, 2022 Share Posted November 22, 2022 Separately, it's having trouble bringing over text that is hyperlinked: Discogs: Emby: Link to comment Share on other sites More sharing options...
Luke 37004 Posted November 22, 2022 Author Share Posted November 22, 2022 Just now, Bigmack3000 said: Separately, it's having trouble bringing over text that is hyperlinked: Discogs: Emby: Right well that's just going to have to be stripped out. 1 Link to comment Share on other sites More sharing options...
jiggity 21 Posted March 22 Share Posted March 22 (edited) On 21/11/2022 at 17:00, Luke said: Ok well I can see lots of too many request errors in your log coming from discogs, so that could be the reason. I haven't had a chance to circle back to this yet but we're going to have to look at how to manage that. This is still a major issue. According to the discogs API docs, it is limited to 60 requests per minute. My logs are filled with hours upon hours of discogs errors and Musicbrainz errors. So many that it affects the ability to do any other scans. Can we get a timeout when processes begin to endlessly error out and a good API call timing. I know there have been requests to revamp the order in which music files are scanned for info; preferably so that the embedded info is first before going to the online meta. The online info being stripped out of Discogs is a bit too aggressive now. Previously there were the html/markup tags remaining, now the actual info is being removed if it is a a hyperlink. Still creating a situation where the meta that is imported requires manual editing. Except that instead of just having a few errant markup tags, now there are entire words and parts missing. Compare attached pic with the description here Edited March 22 by jiggity added image 1 1 Link to comment Share on other sites More sharing options...
jiggity 21 Posted March 25 Share Posted March 25 More info about how this is not working properly Spent a while this afternoon retagging some stuff, and Emby goes and adds the wrong discogs tags to albums that have discogs release id tags Somehow the right info didn't even get imported Link to comment Share on other sites More sharing options...
Happy2Play 8241 Posted March 25 Share Posted March 25 15 minutes ago, jiggity said: More info about how this is not working properly Spent a while this afternoon retagging some stuff, and Emby goes and adds the wrong discogs tags to albums that have discogs release id tags Somehow the right info didn't even get imported Dev will have to comment but I don't believe the embedded DiscogReleaseID tag is being read and ends up getting from musicbrainz. MusicBrainz api result musicbrainz.emby.tv/ws/2/release/9d087a31-4788-41e4-8f0e-0f5c83994faf?inc=url-rels <metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#"> <release id="9d087a31-4788-41e4-8f0e-0f5c83994faf"> <title>The Aeroplane Flies High</title> <status id="4e304316-386d-3409-af2e-78857eec5cfe">Official</status> <quality>normal</quality> <packaging id="815b7785-8284-3926-8f04-e48bc6c4d102">Other</packaging> <text-representation> <language>eng</language> <script>Latn</script> </text-representation> <date>1996-11-26</date> <country>US</country> <release-event-list count="1"> <release-event> <date>1996-11-26</date> <area id="489ce91b-6658-3307-9877-795b68554c98"> <name>United States</name> <sort-name>United States</sort-name> <iso-3166-1-code-list> <iso-3166-1-code>US</iso-3166-1-code> </iso-3166-1-code-list> </area> </release-event> </release-event-list> <barcode>724383858323</barcode> <asin>B000000W3G</asin> <cover-art-archive> <artwork>true</artwork> <count>10</count> <front>true</front> <back>false</back> </cover-art-archive> <relation-list target-type="url"> <relation type="amazon asin" type-id="4f2e710d-166c-480c-a293-2e2c8d658d87"> <target id="f4402a2f-2796-4a45-a863-fdc61ce9bc02">https://www.amazon.com/gp/product/B000000W3G</target> <direction>forward</direction> </relation> <relation type="discogs" type-id="4a78823c-1c53-4176-a5f3-58026c76f2bc"> <target id="a2b8819f-78f7-4b6d-b059-023ae019de6a">https://www.discogs.com/release/2038075</target> <direction>forward</direction> </relation> <relation type="discogs" type-id="4a78823c-1c53-4176-a5f3-58026c76f2bc"> <target id="689dc432-1c98-4a19-8171-ba98203fceae">https://www.discogs.com/release/2515432</target> <direction>forward</direction> <ended>true</ended> </relation> </relation-list> </release> </metadata> As you can see that is where your mis-match comes from tagged vs provider adding. So the question becomes why is MBZ superseding tagged DiscogReleaseID? Link to comment Share on other sites More sharing options...
Happy2Play 8241 Posted March 25 Share Posted March 25 Not sure how much of an issue mixing and matching release information per provider is though. As they are just links to their perspective site and are not used to query against each other that I know of. Link to comment Share on other sites More sharing options...
jiggity 21 Posted March 26 Share Posted March 26 20 hours ago, Happy2Play said: Not sure how much of an issue mixing and matching release information per provider is though. As they are just links to their perspective site and are not used to query against each other that I know of. It is a big issue as in this case the imported MBZ discogs ID is for a Drum and Bass 12" and the actual Discogs ID is for The Smashing Pumpkins limited edition box set Pisces Iscariot Link to comment Share on other sites More sharing options...
Happy2Play 8241 Posted March 26 Share Posted March 26 True and you can find just as many complaints for wrong info in MBZ and Discogs as they are both user input making neither completely correct. Do agree Tagged info should supersede provider info. But to me currently the DISCOGS_RELEASE_ID is not read from media. Unless something has changed but In my test, it appears to be ignored. Link to comment Share on other sites More sharing options...
Luke 37004 Posted March 27 Author Share Posted March 27 On 3/26/2024 at 4:38 PM, Happy2Play said: True and you can find just as many complaints for wrong info in MBZ and Discogs as they are both user input making neither completely correct. Do agree Tagged info should supersede provider info. But to me currently the DISCOGS_RELEASE_ID is not read from media. Unless something has changed but In my test, it appears to be ignored. We can look at importing that. 1 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now